From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 84CEFA04F0;
Thu, 19 Dec 2019 13:43:11 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id BE4D31BDFD;
Thu, 19 Dec 2019 13:43:10 +0100 (CET)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 425431BC25
for <dev@dpdk.org>; Thu, 19 Dec 2019 13:43:09 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1576759388;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=CXX0rcjjEH/QFiDhGlXMM84th/5amUlflTRKCTqlsS8=;
b=bMQwj/RHvDbgJ8jxU7co+2iNSA8O+FT4Cr0MDIlFlcH+05SDRmAVMy2Qv7MeerJgD11h7Q
hjI2fG+fYY43biOwutlV6O0KkNt3xIG8tHs0Tc7ZH4BX2Ec4HP+9uThI8LhB+ysq5BW2D5
6oUyYnkQOs5Vfz6+GcEjWPsXPgkURN0=
Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com
[209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-126-AZl19aUlM-mcAgOx1S61iQ-1; Thu, 19 Dec 2019 07:43:05 -0500
Received: by mail-ua1-f72.google.com with SMTP id s22so1298152uar.17
for <dev@dpdk.org>; Thu, 19 Dec 2019 04:43:05 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=LWKy0pXr6jrGWSDxmxOKCqwXfw7C9fIlh6UsMUynR60=;
b=fcLJLWuejPkTfPjOLXq6mZEzZLcDvB8QverAxiXP481ZdSvSefJG1QJTj7hjE7E6QK
g5Z1MNzm3/39WiYhsluVnC0un/gqhGVWHE8mRD9zM7s7WKd+3Znuc9bHbVIZoTWVceGu
GGPS5xgSPjhVd7bFk3umq2e0RujWW+3qFNHYMHn9qfXPkI/2YNTJHRov8Zj0/Kpatj6G
+aaZm75IhtV+J/IysLPaXvzIEGFuoMemIiRYBmprAq35h2BLyXsC+X+Lj+tBp81yxH0G
XFxuiA7HEPGiMhMpc+gdVA4cz8VgJ48HLwVp/upCREw9KtEwFUnvylMeDhc+GpxF7paq
lMnw==
X-Gm-Message-State: APjAAAUTWSXps/dpktDPAHcgJJIXah8Bc/bNQc7XHbLO8zsYC4niSWEp
p/KcqWd5EJKkDSdPHdT7C5FWU72Ejww4XMXdyTbR4W/bwixd+teA09wArQU/HgnVWUX00wcA91+
SayCU5VfSC53PTI6nlFo=
X-Received: by 2002:a9f:372c:: with SMTP id z41mr5066116uad.87.1576759384808;
Thu, 19 Dec 2019 04:43:04 -0800 (PST)
X-Google-Smtp-Source: APXvYqzO7HVAW5iHbgFYSNkPW4yhbQEmAamTIIgOlqeYwJzLalqnutXQkyZv0umNtUBLXO8dsmTELJjMxzhPtjDLcxY=
X-Received: by 2002:a9f:372c:: with SMTP id z41mr5066100uad.87.1576759384439;
Thu, 19 Dec 2019 04:43:04 -0800 (PST)
MIME-Version: 1.0
References: <20191211102642.983579-1-bruce.richardson@intel.com>
<20191212115826.2167871-1-bruce.richardson@intel.com>
In-Reply-To: <20191212115826.2167871-1-bruce.richardson@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 19 Dec 2019 13:42:53 +0100
Message-ID: <CAJFAV8zGAbC1eJOO_NhhHBPk_wEyG5AHV_LA7gPdvwmzOVLwOA@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
"Kinsella, Ray" <ray.kinsella@intel.com>, "Yigit,
Ferruh" <ferruh.yigit@intel.com>, Luca Boccassi <bluca@debian.org>
X-MC-Unique: AZl19aUlM-mcAgOx1S61iQ-1
X-Mimecast-Spam-Score: 0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11
compatiblity
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Dec 12, 2019 at 12:59 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The soname for each stable ABI version should be just the ABI version maj=
or
> number without the minor number. Unfortunately both major and minor were
> used causing version 20.1 to be incompatible with 20.0.
>
> This patch fixes the issue by switching from 2-part to 3-part ABI version
> numbers so that we can keep 20.0 as soname and using the final digits to
> identify the 20.x releases which are ABI compatible. This requires change=
s
> to both make and meson builds to handle the three-digit version and shrin=
k
> it to 2-digit for soname.
>
> The final fix needed in this patch is to adjust the library version numbe=
r
> for the ethtool example library, which needs to be upped to 2-digits, as
> external libraries using the DPDK build system also use the logic in this
> file.
>
> Fixes: cba806e07d6f ("build: change ABI versioning to global")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Tested-by: David Marchand <david.marchand@redhat.com>
--=20
David Marchand