From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84A1FA0524; Wed, 14 Apr 2021 08:26:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14C941616C8; Wed, 14 Apr 2021 08:26:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BBF6F1616B1 for ; Wed, 14 Apr 2021 08:26:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618381590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=idfUCJgX7mwwokr9SL8f3AeP2mwf0C9k2Ovz/lu+148=; b=TufTdTw2HyQqaoiNwSqPDvGbTX8YkHtLs0KzHIg1BIl+9hcuBRPF105tqEMQVCW0c5aZje DdagIO7lbRWPjrmpQoHTBXMQqW11wAMsX6wcCiT7xzOxw6NzzbZGs81ZEEbj2/4owYaQzt 9b3rAiA7UZaWU8cVV8QjiWf/xWX7EmI= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-cCLAdjVCN-Sue9AUD7Vfew-1; Wed, 14 Apr 2021 02:26:28 -0400 X-MC-Unique: cCLAdjVCN-Sue9AUD7Vfew-1 Received: by mail-vk1-f200.google.com with SMTP id q201-20020a1f43d20000b02901d97cbe351dso275051vka.7 for ; Tue, 13 Apr 2021 23:26:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=idfUCJgX7mwwokr9SL8f3AeP2mwf0C9k2Ovz/lu+148=; b=n7c4tLqCEqOUVxtYf1yorWHuFYVErJT6xNvY9eFbtLQ2N9CC+J8EhsmJ+Fr7j6FHf+ vhkc3GczzKgCeqYhGZBRtpsk6Yv56MYs6CWDzfV1XqMAnXfGnniSEGGRVvLJHimorgOg 9sow7ujYtwlmmus6Nd9CiXSJSdIAG/xOEHxXZ2Yc0U/jmIbyVKbEuEFpRNcu3cP/BFHk Y57rh0YfleVscHuSjrug+UhsFSB3kD7Q3cCL32mZEEOd+mXeuHyiPTfhq/m5e+xZowep L1p6Vjyd3jWPWRjnGDj2YXv4Db6/S/MEIfv765gEBvFCy++nCAgJPoX4C/sD8FlHMRUL lr+g== X-Gm-Message-State: AOAM533cD7x3Kb5m2kp9AEJ0Vh/Kdjz6ydKKjHpVTt9ZCIrxR7/cm43F aykloTyGTelxZqo/IR40XYhNg14wb/Gg6PjgP35eMBv5n+5Ryyi9Qwu3crjrgn3lEgnzyBxEV8x 1bi+edgm4TRiqxdXGcM8= X-Received: by 2002:a67:efd4:: with SMTP id s20mr24632104vsp.27.1618381588165; Tue, 13 Apr 2021 23:26:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvB0Msi5WqMfrd5qXs7j8I//9kAur1S/L6lfAcxlWlfQ5Wav7QtGZkvBvICJcXbchhfj2Gc0n+Sah6Fl6ubbc= X-Received: by 2002:a67:efd4:: with SMTP id s20mr24632099vsp.27.1618381587990; Tue, 13 Apr 2021 23:26:27 -0700 (PDT) MIME-Version: 1.0 References: <20210413221613.2062-1-pbhagavatula@marvell.com> In-Reply-To: <20210413221613.2062-1-pbhagavatula@marvell.com> From: David Marchand Date: Wed, 14 Apr 2021 08:26:16 +0200 Message-ID: To: Pavan Nikhilesh , Jerin Jacob Kollanukkaran Cc: Jay Jayatheerthan , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: fix signed comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 14, 2021 at 12:16 AM wrote: > > From: Pavan Nikhilesh > > Since queue identifier is passed as signed integer, a compilation error > is generated: > rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type > in conditional expression [-Werror=sign-compare] > Make queue identifier as unsigned when adding it to vector data. > Bugzilla ID: 672 > Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector") > > Signed-off-by: Pavan Nikhilesh LGTM and fixes compilation for RHEL7. Acked-by: David Marchand Jerin, do you mind if I take it directly in main? -- David Marchand