From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7CE87A0487
	for <public@inbox.dpdk.org>; Mon, 29 Jul 2019 14:55:47 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 12B5D1BF51;
	Mon, 29 Jul 2019 14:55:47 +0200 (CEST)
Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com
 [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id BAAEC1BEEB
 for <dev@dpdk.org>; Mon, 29 Jul 2019 14:55:44 +0200 (CEST)
Received: by mail-vs1-f66.google.com with SMTP id m8so40736623vsj.0
 for <dev@dpdk.org>; Mon, 29 Jul 2019 05:55:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=WbaA/JhnS8YPJJL+ysAYos7HEVwjpdvO1XRbVfwYkUM=;
 b=XPDIYFES5XIh1z/NgEfBO57adDMiDgOhQs6R5/Ks72Rq36f9OYKOVn6wHCsp4Yjxas
 RrwwbDobgJ4RZzkDqwa9Cg6OpHXKaiTmxn+ZpS5D24wS39NH6bnfxF8tfZgfRVoiB7xc
 5BdAa4Jr1cvhY1FaUbI5hAfweErhArt+wywDGLvCough3yLCVNqXeK4mVb0gl36f9LWg
 ORlnQuLlZUzAIeB2RRDBQwBvXeGZ0Z8GaNhTiTQogxzPpuI0rXXKD1oubiQX7zc9vU92
 09/0FiqUMiLAIyxHnzXlZrp2d+U/lbymC4hcW/4XF6IXXLtvdrQJLn8+aZ1Wy/DAHlsG
 ltYg==
X-Gm-Message-State: APjAAAVjbkTLJcPUvO8p4EBj1JmzvHs8VEAuk2wPPeUKyF1E3R7AKf+1
 P1w3LVkAdvmQuKJsDyZIEAiMOIckMntXEh9V5Xt0vkuX
X-Google-Smtp-Source: APXvYqz/FDa4U+DGWtfpf0MhHZb3IuVsiIy3nQd2z4tM2HhwEjORLiak0jLIIeWuy6eewXgVF/id5OqtWdN08SMT1OY=
X-Received: by 2002:a67:e9ca:: with SMTP id q10mr36138838vso.105.1564404944146; 
 Mon, 29 Jul 2019 05:55:44 -0700 (PDT)
MIME-Version: 1.0
References: <20190717112031.10968-1-thomas@monjalon.net>
 <20190717155202.1674-2-thomas@monjalon.net>
 <CAJFAV8xfZHECvE4UeFrX2qZ01rC2VO5p6asEM7GX36+1KfcFLA@mail.gmail.com>
 <1993811.29u6B1lWsr@xps>
In-Reply-To: <1993811.29u6B1lWsr@xps>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 29 Jul 2019 14:55:33 +0200
Message-ID: <CAJFAV8zJAb-LytBASanOTx4ST57BNyun4Z10vcdO+1awDNHS6A@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2 2/2] devtools: allow misc options in null
	test
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jul 29, 2019 at 2:19 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 29/07/2019 12:36, David Marchand:
> > On Wed, Jul 17, 2019 at 5:53 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > In order to ease basic testing with customized options,
> > > EAL and testpmd options can be added as third and fourth arguments
> > > of the "null PMD" script.
> > >
> > > Also, the first argument becomes more flexible by accepting
> > > the testpmd path as an alternative to the build directory.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> >
> > Not sure I would have split this from the first patch.
>
> Patches have different intents, different explanations.

You could have split the discovery of the testpmd binary out of the
first patch (the fix on meson support, as you named it).
Then merged it with this part that accepts both a directory and a direct path.

We are in a dark area there, and well the patches are not that
critical, so go as you like.

> > Out of curiosity, what are the cases where you need to set options?
>
> It allows to test different builds with a specific option,
> and see which one is failing.
> For instance, it was useful when debugging a failure with -w option recently.
>

Ok.


-- 
David Marchand