From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2516141C4D; Thu, 9 Feb 2023 10:13:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A0C4040DF8; Thu, 9 Feb 2023 10:13:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 130664067B for ; Thu, 9 Feb 2023 10:13:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675933985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FiTD5geCYo55Lrn20tUjohnc14ddrfZpLJlflpA6HAc=; b=Yjem/QgMNQgq7+N4xGrTWLnVm3xSc7jo8/8SMvkoYIJSVOD2x07wWK93TT6IGE/RMK+qC9 DIFwqDRppMp3NRRzhxt789MaeXE7AtAcqnNfyvFh6XXBkn8QJXUdfw8qbaz+ttsr4OLNR9 XKWz1y70r7/iRhVoRrHmQb3UeP/lnVE= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-659-MxjHA7_DOMGEJlsS1F9dsA-1; Thu, 09 Feb 2023 04:13:04 -0500 X-MC-Unique: MxjHA7_DOMGEJlsS1F9dsA-1 Received: by mail-pj1-f72.google.com with SMTP id pv1-20020a17090b3c8100b0022c1ab71110so2676963pjb.7 for ; Thu, 09 Feb 2023 01:13:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FiTD5geCYo55Lrn20tUjohnc14ddrfZpLJlflpA6HAc=; b=aJdazCMQzqGbGVp06lGnqj4AxPMxP1Wu5MXZNZ/KKrdiq7PVL/OBKIbVf73OS7/Hzh iDDtGgDsSJ0rQlgtR2j1CdUUqQSnEQYra9Pfkl0tuQ6iz1bMdaKXBZOtNVz6CIGulgcd HVv1ttbyE0kHJ16j65jYRHbOeTiMj/II8KNL40zYkE2HWNIWvZP85XdL2QSij8717uUY +SR59xv0d6HtZuqPSoN62EL5nD6PeryjqWA3fH+hbxGjFQXSsQLUS5gYm7lvojO6VwAx HQT01urtuLO7lqI//0GirPagAFM/OzyZYhhSAEd9IKDrpKmhUjnLY1SfJo83rNIvwLKY WkcQ== X-Gm-Message-State: AO0yUKUMwv50jU0xXlhsScdPP8c5smlTrrzN3x1siOtGggmsbbuftqjv sObHogeeGusJZ84JtTHsDbbKV4owfAgtkmdFYPb0K0eoZIC3GWRz1us75FA3pOgdRukG1GLsZ4F btXZgNoFvtlGQvEh5lt4= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2035881pgn.58.1675933983063; Thu, 09 Feb 2023 01:13:03 -0800 (PST) X-Google-Smtp-Source: AK7set9n6zJtgpy1R04KOiGvPWeKvhOoIPX4jUzp/Mv5R1t1BmMyqg+PuCzvcReGIDW2LDCoPL8EL/p1Ap4o9M4nv+Q= X-Received: by 2002:a63:954c:0:b0:4f2:8007:5e1f with SMTP id t12-20020a63954c000000b004f280075e1fmr2035877pgn.58.1675933982785; Thu, 09 Feb 2023 01:13:02 -0800 (PST) MIME-Version: 1.0 References: <20230124112139.1426279-1-amitprakashs@marvell.com> <20230203081925.2201007-1-amitprakashs@marvell.com> <20230203081925.2201007-2-amitprakashs@marvell.com> In-Reply-To: <20230203081925.2201007-2-amitprakashs@marvell.com> From: David Marchand Date: Thu, 9 Feb 2023 10:12:51 +0100 Message-ID: Subject: Re: [PATCH v5 2/3] graph: pcap capture for graph nodes To: Amit Prakash Shukla Cc: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Anatoly Burakov , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 3, 2023 at 9:19 AM Amit Prakash Shukla wrote: > diff --git a/lib/graph/rte_graph.h b/lib/graph/rte_graph.h > index b32c4bc217..c9a77297fc 100644 > --- a/lib/graph/rte_graph.h > +++ b/lib/graph/rte_graph.h > @@ -35,6 +35,7 @@ extern "C" { > > #define RTE_GRAPH_NAMESIZE 64 /**< Max length of graph name. */ > #define RTE_NODE_NAMESIZE 64 /**< Max length of node name. */ > +#define RTE_GRAPH_PCAP_FILE_SZ 64 /**< Max length of pcap file name. */ > #define RTE_GRAPH_OFF_INVALID UINT32_MAX /**< Invalid graph offset. */ > #define RTE_NODE_ID_INVALID UINT32_MAX /**< Invalid node id. */ > #define RTE_EDGE_ID_INVALID UINT16_MAX /**< Invalid edge id. */ > @@ -164,6 +165,10 @@ struct rte_graph_param { > uint16_t nb_node_patterns; /**< Number of node patterns. */ > const char **node_patterns; > /**< Array of node patterns based on shell pattern. */ > + > + bool pcap_enable; /**< Pcap enable. */ > + uint64_t num_pkt_to_capture; /**< Number of packets to capture. */ > + char *pcap_filename; /**< Filename in which packets to be captured.*/ > }; Repeating in this thread what I commented on a patch fixing compilation for the unit test. Extending this structure requires updating the graph unit test. Please squash this fix in this series. Thanks. -- David Marchand