From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 567924545B; Fri, 14 Jun 2024 15:48:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28C3D402D3; Fri, 14 Jun 2024 15:48:01 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B8DFC402D0 for ; Fri, 14 Jun 2024 15:47:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718372879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pgmw/FPhGuotL+UWW0k8NRMKlalzr8oMSKJ8sdLiCGs=; b=NeTc5CRwosAwHln8FJn9lsn7DQ0pn+VRk2anr4kJFPeMNxUmqiG71FQaOsUyussMhi3Eip BnwG8HP7TKf7YR9JMdPwAsJRp/aVUbTJA3qHxOLS5Pw5ERlVuEjyT/73FFe/l5LC4Cg1NG SyD4HOHN9Cggqw6Y6yXkPX/+YoWxtoE= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-FLx9ODRIMDCupn1Xx4_08A-1; Fri, 14 Jun 2024 09:47:58 -0400 X-MC-Unique: FLx9ODRIMDCupn1Xx4_08A-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ec01fa1a72so16315851fa.2 for ; Fri, 14 Jun 2024 06:47:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718372873; x=1718977673; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pgmw/FPhGuotL+UWW0k8NRMKlalzr8oMSKJ8sdLiCGs=; b=lXzd7anLoFhpRRtx/6icfqOISCtqNOWxp/VOeboGMaDeOwg+w8llX8lWiBgtOnv2I2 I6gztM5JRHUQ7gUw2zbV8avDEqbbBuxHlbmFJ6897HdNb9rK2m++qj0DYsznePwUYqug hvchbsH2L2iT8plxXlpGfJ4xKjkScOXuxS0nVk3GkvVXnXOfpO6prY5+ZhuP1oKyPaTm bBUZ5QoUH5X4gGagkrgaM9Sh7PRuqHjhFcO4kng/+YQQNE5XpAdCDXrw7+dK9pWD9xzT +GWQpFCLiXBUYX2yFVr8eUJcr3S6+5+IJfTgHLgw9EJ6l79rfawDAuuFnRWXGUl1k2l1 IfxQ== X-Gm-Message-State: AOJu0Yxz940OEwZuasWKW/7NVzhp/RcJrXmZXo9mMNfvyGd9tDqzYRO+ BsN4VO9OlImcp0/VI/fM+HDisHowZtsppRZLIuQu8Lx33ZMYmAgS1IlSfznwDYOdPpoIHpL4qym 2ib5wJ+/WJQ/rkBPz264iWMH8KE+xWfuQ00pJJiVUjm91zqZEf/hx0JYMrzCniza4DMlKJlyco8 Lzd9pd0XziWgw8CDk= X-Received: by 2002:a05:651c:1a1e:b0:2ec:eee:f19e with SMTP id 38308e7fff4ca-2ec0eeef77fmr20282821fa.37.1718372873358; Fri, 14 Jun 2024 06:47:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHayFUFzDCvJmGybxvU7GChVWQeB96pzbTJevAynVspIjzHXUskVNOxZNfwCPG6FSAG0zweuFCIGlt89+1KMTM= X-Received: by 2002:a05:651c:1a1e:b0:2ec:eee:f19e with SMTP id 38308e7fff4ca-2ec0eeef77fmr20282721fa.37.1718372873070; Fri, 14 Jun 2024 06:47:53 -0700 (PDT) MIME-Version: 1.0 References: <20230706152626.476775-1-conor.fogarty@intel.com> In-Reply-To: <20230706152626.476775-1-conor.fogarty@intel.com> From: David Marchand Date: Fri, 14 Jun 2024 15:47:40 +0200 Message-ID: Subject: Re: [PATCH] hash: fix segfault by adding param name NULL check To: Conor Fogarty Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 6, 2023 at 5:26=E2=80=AFPM Conor Fogarty wrote: > > Add NULL pointer check to params->name, which is later > copied into the hash datastructure. Without this check > the code segfaults on the strlcpy() of a NULL pointer. > > Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation") Cc: stable@dpdk.org > > Signed-off-by: Conor Fogarty Acked-by: Vladimir Medvedkin Applied, thanks. --=20 David Marchand