From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64364A0487 for ; Thu, 4 Jul 2019 13:42:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F98A1BE08; Thu, 4 Jul 2019 13:41:59 +0200 (CEST) Received: from mail-vk1-f195.google.com (mail-vk1-f195.google.com [209.85.221.195]) by dpdk.org (Postfix) with ESMTP id 507371BDEB for ; Thu, 4 Jul 2019 13:41:57 +0200 (CEST) Received: by mail-vk1-f195.google.com with SMTP id o19so564240vkb.6 for ; Thu, 04 Jul 2019 04:41:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VVoXDNWYesjbzjjFfq1rFWiIDafHaOgKnHA5sqLqZ2E=; b=BH2k73ZwEX95i69+6rqVQWME/yytRrcz2dXMLx7zlMynHCtj16ZA869uvfyQexl+1Z D2Y81X1PDMOpKPquoKaQJvGcHeOOxBcYGkU526DEz+evg8gul7o7tm951o492z8sEbVd i+RxG32Opxq2DZKE2Q8LM7qDs0pwaqCPutBffTMh0vYZ1TNpm5G7dkJG6g1+q/16xZ6P 2ZwrEASNwAjxgi7NBA4EoEWvyribLm9mB939jmI7TrRhwHi/yj9V4d2g6+fx3hjh53tJ PPdVCiT1WKQOhkCP3tV6MTQb7NRsicB/BAVZXKU+eusvTnWGoZnXCKzEiPP4YIauW9g2 BSAQ== X-Gm-Message-State: APjAAAVY0hSiwAMaVcReV/v9PSyWkdwc16NAQSO8UF93Kw1pTpYHmbze YiabBREUbya/bIBECwjsEAfxDqfVrjs16flenfm3Sg== X-Google-Smtp-Source: APXvYqyYh0yjKu+m8UYO3ZguI62bfDaBta03f97x0rbZP8CrDhBmiAizRLcKUTQ1OGUFntlRa5FTHvcGUlWBMPTPfTc= X-Received: by 2002:a1f:1185:: with SMTP id 127mr1957572vkr.85.1562240516592; Thu, 04 Jul 2019 04:41:56 -0700 (PDT) MIME-Version: 1.0 References: <1562234612-631-1-git-send-email-arybchenko@solarflare.com> <1562234612-631-4-git-send-email-arybchenko@solarflare.com> In-Reply-To: <1562234612-631-4-git-send-email-arybchenko@solarflare.com> From: David Marchand Date: Thu, 4 Jul 2019 13:41:45 +0200 Message-ID: To: Andrew Rybchenko Cc: Jerin Jacob , Liang Ma , Peter Mccarthy , dev , Dilshod Urazov , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 3/3] event/opdl: fix to set positive rte_errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 4, 2019 at 12:04 PM Andrew Rybchenko wrote: > From: Dilshod Urazov > > Fixes: 0bf298e39286 ("event/opdl: add event port config get/set") > Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function") > Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") > Cc: stable@dpdk.org > > Signed-off-by: Dilshod Urazov > Signed-off-by: Andrew Rybchenko > --- > drivers/event/opdl/opdl_evdev.c | 10 +++++----- > drivers/event/opdl/opdl_evdev_init.c | 12 ++++++------ > drivers/event/opdl/opdl_ring.c | 2 +- > 3 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/event/opdl/opdl_evdev.c > b/drivers/event/opdl/opdl_evdev.c > index d2d2be4..3beca89 100644 > --- a/drivers/event/opdl/opdl_evdev.c > +++ b/drivers/event/opdl/opdl_evdev.c > @@ -102,7 +102,7 @@ > dev->data->dev_id, > queues[0], > p->id); > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > > @@ -113,7 +113,7 @@ > dev->data->dev_id, > num, > p->id); > - rte_errno = -EDQUOT; > + rte_errno = EDQUOT; > return 0; > } > > @@ -123,7 +123,7 @@ > dev->data->dev_id, > p->id, > queues[0]); > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > > @@ -134,7 +134,7 @@ > p->id, > p->external_qid, > queues[0]); > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > > @@ -160,7 +160,7 @@ > dev->data->dev_id, > queues[0], > p->id); > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > RTE_SET_USED(nb_unlinks); > diff --git a/drivers/event/opdl/opdl_evdev_init.c > b/drivers/event/opdl/opdl_evdev_init.c > index 582ad69..15aae47 100644 > --- a/drivers/event/opdl/opdl_evdev_init.c > +++ b/drivers/event/opdl/opdl_evdev_init.c > @@ -35,7 +35,7 @@ > p->id, > ev[i].queue_id, > p->next_external_qid); > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > } > @@ -63,7 +63,7 @@ > } else { > if (num > 0 && > ev[0].queue_id != p->next_external_qid) { > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > } > @@ -116,7 +116,7 @@ > RTE_SET_USED(ev); > RTE_SET_USED(num); > > - rte_errno = -ENOSPC; > + rte_errno = ENOSPC; > > return 0; > } > @@ -145,7 +145,7 @@ > > > if (enqueued < num) > - rte_errno = -ENOSPC; > + rte_errno = ENOSPC; > > return enqueued; > } > @@ -164,7 +164,7 @@ > RTE_SET_USED(ev); > RTE_SET_USED(num); > > - rte_errno = -ENOSPC; > + rte_errno = ENOSPC; > > return 0; > } > @@ -240,7 +240,7 @@ > "Attempt to dequeue num of events larger than > port (%d) max", > opdl_pmd_dev_id(p->opdl), > p->id); > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > > diff --git a/drivers/event/opdl/opdl_ring.c > b/drivers/event/opdl/opdl_ring.c > index e988f1c..e8b29e2 100644 > --- a/drivers/event/opdl/opdl_ring.c > +++ b/drivers/event/opdl/opdl_ring.c > @@ -756,7 +756,7 @@ struct opdl_ring { > opdl_stage_disclaim(struct opdl_stage *s, uint32_t num_entries, bool > block) > { > if (num_entries != s->num_event) { > - rte_errno = -EINVAL; > + rte_errno = EINVAL; > return 0; > } > if (s->threadsafe == false) { > -- > 1.8.3.1 > Reviewed-by: David Marchand -- David Marchand