From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BB6A5A09D3;
	Thu, 12 Nov 2020 12:14:46 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 03EDE5937;
	Thu, 12 Nov 2020 12:14:45 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by dpdk.org (Postfix) with ESMTP id 879F85937
 for <dev@dpdk.org>; Thu, 12 Nov 2020 12:14:42 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1605179680;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=qi2x2zQjNVbh+6IYSqmUJWPahGRL44Go3rclfioctc4=;
 b=a+a5+Nn3MsCpW4HkK6zaMpMLe5pXeGzm5fBjWeP+aZvSuSf1AuKH7qgri1zXZKeyOmrAP2
 cK8dZnniIaxI686fs27bbd1FHKHQUebx2epPsfDPQbhzXK1yLKR/l90K9tH+SiTk0UsaiL
 4lp6lwdT8zNkHvD6M96wvbYx3dryg1I=
Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com
 [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-192-ox2EGZ_sPF-NMvD_T7oceQ-1; Thu, 12 Nov 2020 06:14:39 -0500
X-MC-Unique: ox2EGZ_sPF-NMvD_T7oceQ-1
Received: by mail-vk1-f197.google.com with SMTP id t127so1413799vkf.20
 for <dev@dpdk.org>; Thu, 12 Nov 2020 03:14:38 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=qi2x2zQjNVbh+6IYSqmUJWPahGRL44Go3rclfioctc4=;
 b=HvYmPsh2LEH56VUnE6X/xFgRx4sTpNyZmcCukC1qWNW1HANKVRGLKyimJ3hWlXsQeM
 XDzGndrKp80FKSR7Ek+6uLJEhdYpgv/IsgrGeAE4X9UTajMVoxBK0EdH9GRidhI/DNju
 oLywIGQBFJCx4PRfYI6Y0rzOcIcLso5Eqqy2eVfcYqxCr5hFdzCLwlOaamS/jY70nTYy
 fUJMJISqiz7GljRXemnI6BbLOEmQyRRpoP6Xer0NC/9v+ntG0AYx/8o5/bCvY/Yvdp+A
 EYDJmqpV/36ojXRDknkDmhkPUSE/hOc0B9pL3D8QUSCbeT6xeOfiF4lfntmNErMoawFT
 EAeg==
X-Gm-Message-State: AOAM530VoJHgaXkdTqtQd7ohWK6GaJ1Mh8qrQSsUcLxG3kkZf560znWj
 36zaFOdlnHsMgjwHRncHRTtl2Dv6X9PFLPijF6z8rmKquNZPFbswtyKynJnW+xMRETiERzXnJ18
 2mnnww+xqI63wGNz0tmI=
X-Received: by 2002:a1f:23d6:: with SMTP id j205mr15632960vkj.20.1605179678620; 
 Thu, 12 Nov 2020 03:14:38 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzUDZU0GbFwdvSWgLZ5LjKVdpOvqI0TRd80rkbtVlfF055UO7or8cWBJt01y7kAO00kI6lBfoX2EKHV4NUUA30=
X-Received: by 2002:a1f:23d6:: with SMTP id j205mr15632955vkj.20.1605179678414; 
 Thu, 12 Nov 2020 03:14:38 -0800 (PST)
MIME-Version: 1.0
References: <20201110170809.1309043-1-bruce.richardson@intel.com>
 <20201112094142.1781861-1-bruce.richardson@intel.com>
In-Reply-To: <20201112094142.1781861-1-bruce.richardson@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 12 Nov 2020 12:14:27 +0100
Message-ID: <CAJFAV8zKhQ+9-htHcGTqibeoJhMsemZypfEwH=xwymXCwhW8VA@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v4 0/4] improve examples installation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Nov 12, 2020 at 10:42 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> This patch improves the installation of the examples when "ninja install" is
> run. It removes issues with the directory structure being flattened out, and
> removes from the install list any examples that are not buildable with built
> DPDK code.
>
> V4: resubmit v3 to retest in CI hopefully with proper patch tracking
>
> V3: fix issues with building on Windows
>
> V2: add support for filtering examples that won't build
>
> Bruce Richardson (4):
>   examples: fix flattening directory layout on install
>   examples/l2fwd-keepalive: skip build when no librt
>   examples: stop processing build file if build is impossible
>   examples: skip installing unbuildable examples

Thanks Bruce.
This series looks good to me.

My only comment is about vm_power_manager which won't build without
the internal librte_power header.
It builds fine with meson, because I guess meson pulls this library
directory into the include flags of the example, but it won't build
outside.

We can skip it in devtools/test-meson-builds.sh but, on the other
hand, I would exclude it from installing until it is fixed (in a
future release).


-- 
David Marchand