From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 50B255B2A for ; Wed, 3 Apr 2019 10:41:59 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id f15so9452704vsk.9 for ; Wed, 03 Apr 2019 01:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a8EU3+pRPfG29TwFlgIQjn/yVBeBlUnBn9VpqZpdr6A=; b=jLwlzMgPaenKwzmU+wmTyjUyCPongLEE5pRPg5xrfFIzi/1wArSy0xeEOcVA1A+t5s 0ftCSIcwDvdF7cQtn6LRL06j0yh58CqL7WY4YjGP3SYgnR01cgbPqheagvIxy0czAd1L t3uX8XhE9EYFwlkIQYVH2uz+UhRl64sPLhsU1QplSIySBoSC31psjNWSOaQdS7DT3sMa YmE+2XrVhNx8fnq3W67GtPeR2ux194mLyDp6Pz3oUZZ4Daoh2rJnpwlbbqQD7e4h75FW B0a2OFco6RszseCIp2kLY/aCsyLGDoMtjGB7Ub/WTpctJTLkh5Eh6bEstsm8I9N6Q840 vzRw== X-Gm-Message-State: APjAAAWNnCriHKo0vYMGD2rSdnDkZPchvU/mDiRS9Np7nm3YnwbKN6rn 9SfROVzekglHw3zSJ6KijPI+QPz+YfvNmtBgNCcFfg== X-Google-Smtp-Source: APXvYqxo4ZCnUiRU9J/Qg7RcLHBaDiSudluGbZ2Pj2GDIplfKDCbuDoG7fklqTC9rZ6rxrIsKSc9EzM1Lxv7FUbwHZQ= X-Received: by 2002:a67:f588:: with SMTP id i8mr5447854vso.91.1554280918626; Wed, 03 Apr 2019 01:41:58 -0700 (PDT) MIME-Version: 1.0 References: <20190401230712.31864-1-thomas@monjalon.net> <20190402193048.27410-1-thomas@monjalon.net> <5780010.E6WaIR6Pig@xps> In-Reply-To: <5780010.E6WaIR6Pig@xps> From: David Marchand Date: Wed, 3 Apr 2019 10:41:47 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Anand Rawat Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 08:41:59 -0000 On Tue, Apr 2, 2019 at 9:51 PM Thomas Monjalon wrote: > 02/04/2019 21:46, David Marchand: > > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon > wrote: > > > > > Only one header file (rte_kni_common.h) was in the sub-directory > > > include/exec-env/ > > > This file was installed in a sub-directory of the same name > > > in the makefile-based build. > > > Source and install directories are moved as below: > > > > > > lib/librte_eal/linux/eal/include/exec-env/ > > > -> lib/librte_eal/linux/eal/include/ > > > > > > build/include/exec-env/ > > > -> build/include/ > > > > > > The consequence is to have a file hierarchy a bit more flat. > > > > > > Signed-off-by: Thomas Monjalon > > > > > > > Looks good to me. > > Reviewed-by: David Marchand > > Tested-by: David Marchand > > Applied > As a followup, I noticed this: [dmarchan@dmarchan dpdk]$ for file in $(find lib/librte_eal/*/eal -name *.h); do echo $(basename $file); git grep -l $(basename $file); echo; done eal_alarm_private.h lib/librte_eal/freebsd/eal/eal_alarm.c lib/librte_eal/freebsd/eal/eal_interrupts.c eal_vfio.h lib/librte_eal/linux/eal/eal.c lib/librte_eal/linux/eal/eal_interrupts.c lib/librte_eal/linux/eal/eal_vfio.c lib/librte_eal/linux/eal/eal_vfio_mp_sync.c rte_kni_common.h kernel/linux/kni/kni_dev.h kernel/linux/kni/kni_fifo.h kernel/linux/kni/kni_misc.c kernel/linux/kni/kni_net.c lib/librte_eal/linux/eal/Makefile lib/librte_kni/rte_kni.c lib/librte_kni/rte_kni.h At the moment, kni is the only special case where users need to set a CFLAGS -I...eal/include for. But we have some drivers directly referencing linux/eal, linux/eal/include and a funny $(SYSTEM)app/eal: [dmarchan@dmarchan dpdk]$ git grep CFLAGS.*/eal drivers/bus/dpaa/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/bus/pci/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal drivers/bus/vmbus/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal drivers/crypto/caam_jr/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/crypto/dpaa2_sec/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/crypto/dpaa_sec/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/event/dpaa/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal/include drivers/event/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/mempool/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/net/dpaa/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal/include drivers/net/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/raw/dpaa2_qdma/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal Preparing a patch. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 22595A0679 for ; Wed, 3 Apr 2019 10:42:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0BA555B3C; Wed, 3 Apr 2019 10:42:01 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 50B255B2A for ; Wed, 3 Apr 2019 10:41:59 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id f15so9452704vsk.9 for ; Wed, 03 Apr 2019 01:41:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a8EU3+pRPfG29TwFlgIQjn/yVBeBlUnBn9VpqZpdr6A=; b=jLwlzMgPaenKwzmU+wmTyjUyCPongLEE5pRPg5xrfFIzi/1wArSy0xeEOcVA1A+t5s 0ftCSIcwDvdF7cQtn6LRL06j0yh58CqL7WY4YjGP3SYgnR01cgbPqheagvIxy0czAd1L t3uX8XhE9EYFwlkIQYVH2uz+UhRl64sPLhsU1QplSIySBoSC31psjNWSOaQdS7DT3sMa YmE+2XrVhNx8fnq3W67GtPeR2ux194mLyDp6Pz3oUZZ4Daoh2rJnpwlbbqQD7e4h75FW B0a2OFco6RszseCIp2kLY/aCsyLGDoMtjGB7Ub/WTpctJTLkh5Eh6bEstsm8I9N6Q840 vzRw== X-Gm-Message-State: APjAAAWNnCriHKo0vYMGD2rSdnDkZPchvU/mDiRS9Np7nm3YnwbKN6rn 9SfROVzekglHw3zSJ6KijPI+QPz+YfvNmtBgNCcFfg== X-Google-Smtp-Source: APXvYqxo4ZCnUiRU9J/Qg7RcLHBaDiSudluGbZ2Pj2GDIplfKDCbuDoG7fklqTC9rZ6rxrIsKSc9EzM1Lxv7FUbwHZQ= X-Received: by 2002:a67:f588:: with SMTP id i8mr5447854vso.91.1554280918626; Wed, 03 Apr 2019 01:41:58 -0700 (PDT) MIME-Version: 1.0 References: <20190401230712.31864-1-thomas@monjalon.net> <20190402193048.27410-1-thomas@monjalon.net> <5780010.E6WaIR6Pig@xps> In-Reply-To: <5780010.E6WaIR6Pig@xps> From: David Marchand Date: Wed, 3 Apr 2019 10:41:47 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Anand Rawat Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] eal: remove exec-env directory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190403084147.frpHW-O9Y9RwRlsszD14LGIPVt1bHmIvpMTOb7LRvEg@z> On Tue, Apr 2, 2019 at 9:51 PM Thomas Monjalon wrote: > 02/04/2019 21:46, David Marchand: > > On Tue, Apr 2, 2019 at 9:30 PM Thomas Monjalon > wrote: > > > > > Only one header file (rte_kni_common.h) was in the sub-directory > > > include/exec-env/ > > > This file was installed in a sub-directory of the same name > > > in the makefile-based build. > > > Source and install directories are moved as below: > > > > > > lib/librte_eal/linux/eal/include/exec-env/ > > > -> lib/librte_eal/linux/eal/include/ > > > > > > build/include/exec-env/ > > > -> build/include/ > > > > > > The consequence is to have a file hierarchy a bit more flat. > > > > > > Signed-off-by: Thomas Monjalon > > > > > > > Looks good to me. > > Reviewed-by: David Marchand > > Tested-by: David Marchand > > Applied > As a followup, I noticed this: [dmarchan@dmarchan dpdk]$ for file in $(find lib/librte_eal/*/eal -name *.h); do echo $(basename $file); git grep -l $(basename $file); echo; done eal_alarm_private.h lib/librte_eal/freebsd/eal/eal_alarm.c lib/librte_eal/freebsd/eal/eal_interrupts.c eal_vfio.h lib/librte_eal/linux/eal/eal.c lib/librte_eal/linux/eal/eal_interrupts.c lib/librte_eal/linux/eal/eal_vfio.c lib/librte_eal/linux/eal/eal_vfio_mp_sync.c rte_kni_common.h kernel/linux/kni/kni_dev.h kernel/linux/kni/kni_fifo.h kernel/linux/kni/kni_misc.c kernel/linux/kni/kni_net.c lib/librte_eal/linux/eal/Makefile lib/librte_kni/rte_kni.c lib/librte_kni/rte_kni.h At the moment, kni is the only special case where users need to set a CFLAGS -I...eal/include for. But we have some drivers directly referencing linux/eal, linux/eal/include and a funny $(SYSTEM)app/eal: [dmarchan@dmarchan dpdk]$ git grep CFLAGS.*/eal drivers/bus/dpaa/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/bus/pci/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal drivers/bus/vmbus/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/$(SYSTEM)app/eal drivers/crypto/caam_jr/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/crypto/dpaa2_sec/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/crypto/dpaa_sec/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/event/dpaa/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal/include drivers/event/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/mempool/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/net/dpaa/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal/include drivers/net/dpaa2/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal drivers/raw/dpaa2_qdma/Makefile:CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linux/eal Preparing a patch. -- David Marchand