* [PATCH] mldev: remove variable self assignment in dev init
@ 2023-03-11 14:57 Srikanth Yalavarthi
2023-03-13 11:02 ` David Marchand
2023-03-13 19:19 ` Tyler Retzlaff
0 siblings, 2 replies; 4+ messages in thread
From: Srikanth Yalavarthi @ 2023-03-11 14:57 UTC (permalink / raw)
To: Srikanth Yalavarthi, Jerin Jacob; +Cc: dev, sshankarnara
Fix variable self assignment in rte_ml_devinit.
Issue reported by coverity scan.
Coverity issue: 383652
Fixes: ea80eafbd4d8 ("mldev: add PMD functions")
Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
lib/mldev/rte_mldev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c
index eeddb8e874..50ebeb1bfe 100644
--- a/lib/mldev/rte_mldev.c
+++ b/lib/mldev/rte_mldev.c
@@ -186,7 +186,6 @@ rte_ml_dev_init(size_t dev_max)
}
ml_dev_globals.max_devs = dev_max;
- ml_dev_globals.devs = ml_dev_globals.devs;
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mldev: remove variable self assignment in dev init
2023-03-11 14:57 [PATCH] mldev: remove variable self assignment in dev init Srikanth Yalavarthi
@ 2023-03-13 11:02 ` David Marchand
2023-03-13 19:19 ` Tyler Retzlaff
1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-03-13 11:02 UTC (permalink / raw)
To: Srikanth Yalavarthi; +Cc: Jerin Jacob, dev, sshankarnara
On Sat, Mar 11, 2023 at 3:57 PM Srikanth Yalavarthi
<syalavarthi@marvell.com> wrote:
>
> Fix variable self assignment in rte_ml_devinit.
> Issue reported by coverity scan.
>
> Coverity issue: 383652
> Fixes: ea80eafbd4d8 ("mldev: add PMD functions")
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mldev: remove variable self assignment in dev init
2023-03-11 14:57 [PATCH] mldev: remove variable self assignment in dev init Srikanth Yalavarthi
2023-03-13 11:02 ` David Marchand
@ 2023-03-13 19:19 ` Tyler Retzlaff
2023-03-15 9:49 ` David Marchand
1 sibling, 1 reply; 4+ messages in thread
From: Tyler Retzlaff @ 2023-03-13 19:19 UTC (permalink / raw)
To: Srikanth Yalavarthi; +Cc: Jerin Jacob, dev, sshankarnara
On Sat, Mar 11, 2023 at 06:57:04AM -0800, Srikanth Yalavarthi wrote:
> Fix variable self assignment in rte_ml_devinit.
> Issue reported by coverity scan.
>
> Coverity issue: 383652
> Fixes: ea80eafbd4d8 ("mldev: add PMD functions")
>
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> lib/mldev/rte_mldev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/mldev/rte_mldev.c b/lib/mldev/rte_mldev.c
> index eeddb8e874..50ebeb1bfe 100644
> --- a/lib/mldev/rte_mldev.c
> +++ b/lib/mldev/rte_mldev.c
> @@ -186,7 +186,6 @@ rte_ml_dev_init(size_t dev_max)
> }
>
> ml_dev_globals.max_devs = dev_max;
> - ml_dev_globals.devs = ml_dev_globals.devs;
>
> return 0;
> }
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mldev: remove variable self assignment in dev init
2023-03-13 19:19 ` Tyler Retzlaff
@ 2023-03-15 9:49 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2023-03-15 9:49 UTC (permalink / raw)
To: Srikanth Yalavarthi; +Cc: Jerin Jacob, dev, sshankarnara, Tyler Retzlaff
On Mon, Mar 13, 2023 at 8:19 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> On Sat, Mar 11, 2023 at 06:57:04AM -0800, Srikanth Yalavarthi wrote:
> > Fix variable self assignment in rte_ml_devinit.
> > Issue reported by coverity scan.
> >
> > Coverity issue: 383652
> > Fixes: ea80eafbd4d8 ("mldev: add PMD functions")
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > ---
>
> Reviewed-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-15 9:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11 14:57 [PATCH] mldev: remove variable self assignment in dev init Srikanth Yalavarthi
2023-03-13 11:02 ` David Marchand
2023-03-13 19:19 ` Tyler Retzlaff
2023-03-15 9:49 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).