From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
"Kinsella, Ray" <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode
Date: Thu, 13 May 2021 09:06:03 +0200 [thread overview]
Message-ID: <CAJFAV8zL_GEC3OL8mjOpNdfZcGiuwm9XhquxP9YyWcu9d85MvQ@mail.gmail.com> (raw)
In-Reply-To: <1641165.axTpplifrG@thomas>
On Wed, May 12, 2021 at 10:38 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 12/05/2021 22:24, Thomas Monjalon:
> > > > Hook check-symbol-maps.sh in the symbol check when in developer mode to
> > > > help developers catch issues before submitting their changes.
> > > >
> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > +1
> > >
> > > Reviewed-by: Ray Kinsella <mdr@ashroe.eu>
> >
> > Series applied, thanks
>
> Oops, sorry no it cannot be merged as-is because of an incompatibility
> with Busybox grep: unrecognized option: exclude=version.map
>
> I think it is because of the old function find_orphan_symbols()
> using the option --exclude.
This could be fixed with:
- if ! grep -q -r --exclude=$(basename $map) \
- -w $symsrc $(dirname $map) ; then
+ if [ -z "$(grep -rlw $symsrc $(dirname $map) |grep -v
$map)" ] ; then
Do you want a v3 with this change?
--
David Marchand
next prev parent reply other threads:[~2021-05-13 7:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:14 [dpdk-dev] [PATCH] devtools: catch symbol duplicates in version map David Marchand
2021-02-25 11:41 ` Thomas Monjalon
2021-02-25 11:57 ` Bruce Richardson
2021-02-25 12:01 ` Thomas Monjalon
2021-02-25 12:05 ` Bruce Richardson
2021-02-25 13:14 ` Thomas Monjalon
2021-05-05 14:30 ` [dpdk-dev] [PATCH v2 1/2] " David Marchand
2021-05-05 14:30 ` [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode David Marchand
2021-05-06 9:31 ` Kinsella, Ray
2021-05-12 20:24 ` Thomas Monjalon
2021-05-12 20:38 ` Thomas Monjalon
2021-05-13 7:06 ` David Marchand [this message]
2021-05-13 8:34 ` [dpdk-dev] [PATCH v3 1/3] devtools: fix orphan symbols check with busybox David Marchand
2021-05-13 8:34 ` [dpdk-dev] [PATCH v3 2/3] devtools: catch symbol duplicates in version map David Marchand
2021-05-13 8:34 ` [dpdk-dev] [PATCH v3 3/3] build: check symbol maps in developer mode David Marchand
2021-05-19 10:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zL_GEC3OL8mjOpNdfZcGiuwm9XhquxP9YyWcu9d85MvQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).