From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C748A034F; Thu, 13 May 2021 09:06:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BB11406A2; Thu, 13 May 2021 09:06:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6F9AC4067E for ; Thu, 13 May 2021 09:06:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620889578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6NmFNK1FKJza2SfeG07t8c29VUvhR80qN1avGIqenNc=; b=Al7xJmFuYDveRMcFq3QCAJ/GH8sJ4Z/nwFPC1tJmfFM95m+vQukmRHwRDc7dK20AfWshwk c/T3R/xVI0tszZWzzZcpDFd/fBzJN6PiifH325ql8yhW8JOVn32kYNXYYshWSEO0bEgwL9 iRJDw5oo7IoXzgcofy7i8BgCCd/U05o= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-JupptUs-PGKW8TfNSs8SPQ-1; Thu, 13 May 2021 03:06:14 -0400 X-MC-Unique: JupptUs-PGKW8TfNSs8SPQ-1 Received: by mail-vk1-f198.google.com with SMTP id b188-20020a1f34c50000b02901fb4237dbbaso1607993vka.17 for ; Thu, 13 May 2021 00:06:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6NmFNK1FKJza2SfeG07t8c29VUvhR80qN1avGIqenNc=; b=B/dkhrWubhMwEdzSaTKlSxR4sjM4avve8aH6G9MIsu0eqLRZ78eoBeJAHSGspOqgnA hCn9MSzdwKg2ixYM49LUD2SigOWNqd5+WFx7nT4mQdIuUd8PPRjeseAvgAAW5I9xfjWX d/HQB97DbdX4lcCz8YgasSwTYCScrcxi3rigsD8zl+91bBw1Y7gVdLEt+2rYzL3CmyvR HLDDKpE3L5oLePGzpalLx2Dr3IpRWUjdFh8Y668A9MBbq+hUEszAJNgYQkYR6K4uumM0 bW2ZLzhihT9q4V2xQWmF3Weny2AnB3wxFeId8sy+aZm+TKI3rFdXIjQfcrvQri/h9CMp PiGg== X-Gm-Message-State: AOAM532axl4KjU95maroMbduwloLMBuX7Q4cf60HZa2CrNz3nSAx5q84 QdrPr5db3yPcSZ7v+6f/oSeLpuyG6KVUxgXMgGCtP/vVH6haTguv+21PTLjGDJUM8wvp7IAyuxx U6Fp2tRmZAUPnT+YmwD0= X-Received: by 2002:a1f:d283:: with SMTP id j125mr32963830vkg.9.1620889574484; Thu, 13 May 2021 00:06:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVI6+R0jf4u5xhhMLNr/Q9CKUr2qOql7JoP9mJSIaGFy+JK4TIyWQLR5TKAav3ZqTZrLvniAyiTOoXRLpl9OI= X-Received: by 2002:a1f:d283:: with SMTP id j125mr32963809vkg.9.1620889574252; Thu, 13 May 2021 00:06:14 -0700 (PDT) MIME-Version: 1.0 References: <20210225111457.32540-1-david.marchand@redhat.com> <6027754.usKPUfTrSP@thomas> <1641165.axTpplifrG@thomas> In-Reply-To: <1641165.axTpplifrG@thomas> From: David Marchand Date: Thu, 13 May 2021 09:06:03 +0200 Message-ID: To: Thomas Monjalon Cc: dev , "Yigit, Ferruh" , Bruce Richardson , Neil Horman , "Kinsella, Ray" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 12, 2021 at 10:38 PM Thomas Monjalon wrote: > > 12/05/2021 22:24, Thomas Monjalon: > > > > Hook check-symbol-maps.sh in the symbol check when in developer mode to > > > > help developers catch issues before submitting their changes. > > > > > > > > Signed-off-by: David Marchand > > > +1 > > > > > > Reviewed-by: Ray Kinsella > > > > Series applied, thanks > > Oops, sorry no it cannot be merged as-is because of an incompatibility > with Busybox grep: unrecognized option: exclude=version.map > > I think it is because of the old function find_orphan_symbols() > using the option --exclude. This could be fixed with: - if ! grep -q -r --exclude=$(basename $map) \ - -w $symsrc $(dirname $map) ; then + if [ -z "$(grep -rlw $symsrc $(dirname $map) |grep -v $map)" ] ; then Do you want a v3 with this change? -- David Marchand