From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1EE9BA0C43;
	Tue, 19 Oct 2021 10:52:38 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A718640142;
	Tue, 19 Oct 2021 10:52:37 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mails.dpdk.org (Postfix) with ESMTP id F28B34003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 10:52:35 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1634633555;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=YfMFIP+zg9G82JZPz+cojkwVNrJzgKy6+ILm1TbKHGM=;
 b=RL5ramjZzdMXbJ2Xh5mtzeusTujI/xkm+kasWJej1ti1TQxYnltmtnJcYhCDvQSyNCaV/m
 ppR2OayQhSz9gun9naXD/GrsFeHyqjJWQMZI/FEHqY2WMONGrVzoAQKmYl1D9HfVjfiX6I
 u4GK8/sC0QpCberri4U9lTDzbtSPoig=
Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com
 [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-200-Cp3iex8AON6jrqFOlKqJYw-1; Tue, 19 Oct 2021 04:52:34 -0400
X-MC-Unique: Cp3iex8AON6jrqFOlKqJYw-1
Received: by mail-lj1-f197.google.com with SMTP id
 f6-20020a2e9e86000000b00211349f9ce3so448428ljk.3
 for <dev@dpdk.org>; Tue, 19 Oct 2021 01:52:33 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=YfMFIP+zg9G82JZPz+cojkwVNrJzgKy6+ILm1TbKHGM=;
 b=2EgzXoa234aE1iG+aCDu3wlMW8grFTEv3eN46jaHcceCSKh3Bw9e+KuF3FYB6lxM8Y
 pr9R2LsQn6caDYRgAahutxI3QZd2HuU6xeAw1v39CIxTAj0SbrWHlCsiHKQ+c4AUTsw8
 K9UXjL5juAglpMHh1M60LGsuBmydjnyTFKgbGGLAl3kw3RB/SkaoHnmlRAeqmDMBrmQW
 w4kVTf+tuejROhFuOpmdSfMqCMdmDQoXH/joRyq0j5mVvFwvtH5dStZFYdWs+YvKNHts
 PrENos0viMYf1RUZjb+2lHehcWowzHbzetajq3ilStWCpc/21Bx7IxOGVY5m3ZX6Yv84
 QKPQ==
X-Gm-Message-State: AOAM530Oc3Z3MfnTgDlXHLs+YpifBfXqQ919L5AxPeditLQ+ZXJ1TZjS
 JmSgge/++r2J+8N/d4b3QTvVIS68YIAD0obWSwXSxVBk2ZNB+rFd9SmdgZ3JBLxNo7zdF0J/rd1
 +TrUvNXGMyd15y5Kb89w=
X-Received: by 2002:a2e:b6cc:: with SMTP id m12mr5196348ljo.297.1634633552548; 
 Tue, 19 Oct 2021 01:52:32 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw3cGlUhLnVMW7RprZ0tTHnuolAyu1Cg1G914+4TUDRfbvUjhxihk521dI9cmbz7/qAaguuBvJBPH33cznSeiQ=
X-Received: by 2002:a2e:b6cc:: with SMTP id m12mr5196313ljo.297.1634633552269; 
 Tue, 19 Oct 2021 01:52:32 -0700 (PDT)
MIME-Version: 1.0
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211018144907.1145028-3-andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20211018144907.1145028-3-andrew.rybchenko@oktetlabs.ru>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 19 Oct 2021 10:52:21 +0200
Message-ID: <CAJFAV8zLmqjX_66qzg5TwnAoGpEHuDTEcWW8X5fKnM2UPaV7Lg@mail.gmail.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Thomas Monjalon <thomas@monjalon.net>
Cc: Olivier Matz <olivier.matz@6wind.com>,
 Maryam Tahhan <maryam.tahhan@intel.com>, 
 Reshma Pattan <reshma.pattan@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>, 
 Ray Kinsella <mdr@ashroe.eu>, Pavan Nikhilesh <pbhagavatula@marvell.com>, 
 Shijith Thotton <sthotton@marvell.com>, Jerin Jacob <jerinj@marvell.com>, 
 "Artem V. Andreev" <artem.andreev@oktetlabs.ru>,
 Nithin Dabilpuram <ndabilpuram@marvell.com>, 
 Kiran Kumar K <kirankumark@marvell.com>, Maciej Czekaj <mczekaj@marvell.com>, 
 Radha Mohan Chintakuntla <radhac@marvell.com>,
 Veerasenareddy Burru <vburru@marvell.com>, 
 Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>,
 dev <dev@dpdk.org>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 2/6] mempool: add namespace prefix to flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Oct 18, 2021 at 4:49 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> Fix the mempool flgas namespace by adding an RTE_ prefix to the name.
> The old flags remain usable, but a deprecation warning is issued at
> compilation.

We have a build failure in CI for SPDK.
This is most probably (I can't find the full compilation error in
logs..) because of the deprecation of MEMPOOL_F_NO_IOVA_CONTIG.


$ git grep-all -E
'\<(MEMPOOL_F_NO_IOVA_CONTIG|MEMPOOL_F_POOL_CREATED|MEMPOOL_F_SC_GET|MEMPOOL_F_SP_PUT|MEMPOOL_F_NO_CACHE_ALIGN|MEMPOOL_F_NO_SPREAD)\>'
BESS/core/packet_pool.cc:  pool_->flags |= MEMPOOL_F_NO_IOVA_CONTIG;
gatekeeper/cps/main.c:        socket_id, MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET);
gatekeeper/cps/main.c:        socket_id, MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET);
mTcp/mtcp/src/dpdk_module.c:                rte_socket_id(), MEMPOOL_F_SP_PUT |
mTcp/mtcp/src/dpdk_module.c:                MEMPOOL_F_SC_GET);
mTcp/mtcp/src/memory_mgt.c:                MEMPOOL_F_NO_SPREAD);
OpenDataplane/platform/linux-generic/pktio/dpdk.c:#define
MEMPOOL_FLAGS MEMPOOL_F_NO_IOVA_CONTIG
SPDK/lib/env_dpdk/env.c:                socket_id, MEMPOOL_F_NO_IOVA_CONTIG);
Trex/src/pal/linux_dpdk/mbuf.cpp:    unsigned flags = is_hugepages ? 0
: MEMPOOL_F_NO_IOVA_CONTIG;
Trex/src/pal/linux_dpdk/mbuf.cpp:        flags = (MEMPOOL_F_SP_PUT |
MEMPOOL_F_SC_GET);
Trex/src/pal/linux_dpdk/mbuf.cpp:        flags |= MEMPOOL_F_NO_IOVA_CONTIG;
Warp17/inc/tpg_memory.h:#define MEM_MBUF_POOL_FLAGS (MEMPOOL_F_SP_PUT
| MEMPOOL_F_SC_GET)
Warp17/inc/tpg_memory.h:#define MEM_TCB_POOL_FLAGS (MEMPOOL_F_SP_PUT |
MEMPOOL_F_SC_GET)
Warp17/inc/tpg_memory.h:#define MEM_UCB_POOL_FLAGS (MEMPOOL_F_SP_PUT |
MEMPOOL_F_SC_GET)
Warp17/src/ring_if/tpg_ring_if.c:static_assert(!(MEM_MBUF_POOL_FLAGS &
MEMPOOL_F_SP_PUT),
Warp17/src/ring_if/tpg_ring_if.c:              "MEM_MBUF_POOL_FLAGS
contains MEMPOOL_F_SP_PUT! This will corrupt memory when using Ring
Interfaces!");


If we had announced such a deprecation, I would not question the change.
I think we should postpone the deprecation part to 22.02.

Thomas, what do you think?


-- 
David Marchand