From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF747A32A2 for ; Fri, 25 Oct 2019 10:18:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EBDAF1E545; Fri, 25 Oct 2019 10:18:28 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 9057F1E544 for ; Fri, 25 Oct 2019 10:18:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571991507; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=95F6/JVWL0tvBMePqUu8Ryc8UZEg/+Py/It8JMWRz9A=; b=eBQn0IvcZL+YKK2hYxuV869LgM/YEaKBzTFbz6L4JwmxEyJxMaWCy/Q4rGzfRXBk9hWn+m NtDz7IbcKrOa8H6jOGIj4wImbB1DNDwI+cNXm7W+sCmOVvKzLBDDcBrDVLwVCj+wx7opju fhTrSv5Egijmov0AzP9kGoNiN0MqsHg= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-I7QtfMZ_O3KlORRNkvy96w-1; Fri, 25 Oct 2019 04:18:24 -0400 Received: by mail-vk1-f200.google.com with SMTP id k127so472686vka.10 for ; Fri, 25 Oct 2019 01:18:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B/LQp5NWpU6/LBolmTrXs78T9f12yKJY8VhfKq7FKg0=; b=lf/PcXEEdHpcl3r9QdCTDCP30P9qw25Ym7qZSgSCi1iKdFpn7QG03aqPev0xWuD7AY nxxl2aPpPwDAE/XL4Nj6CBHpMlVk1FPEPCpNd6xhHMdjeiJAggiEHOaP7JrC1rjHjcR5 isNGf1K78TXn3YC8lcC+FZ+BZirX9aUg9NCSxa4RlmXhvgOob+k0I8V1g+3KRX4Kp7sK v3ywBCRcSeskJLPMNHVwqGWwGhniwtVxhShO3acn/B64u8TaED2OkmB7yNAslUhmU1gw uLvOEHpq98hles0MrnMtc8fdmcCs8QlEvtCSyxy3jtRM/I+DP6LLI6LJBKeBJE9Y/MKt rXsA== X-Gm-Message-State: APjAAAV8zyCNObwr5fTivyF2sAsg6WmT688sYHc9THGBFI/SDG2ejZ0g kC3acuz+73tUZOsiwu4oGZlImDegWoXK7IjxuXw/52Z4J/3u99J4mjO7Y0VtYYNZ/5t4ABE1BKm qxi17HDmvneOA39cmJPs= X-Received: by 2002:ab0:628f:: with SMTP id z15mr953207uao.126.1571991504116; Fri, 25 Oct 2019 01:18:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqypgV8QaMNGyBVjab2NDZkQAj9G3jhESkjUgw4GE7Ddicdqaoyhl2izxgZxD3uu91sC3aa0C751xgJ8kI8Xwsg= X-Received: by 2002:ab0:628f:: with SMTP id z15mr953192uao.126.1571991503754; Fri, 25 Oct 2019 01:18:23 -0700 (PDT) MIME-Version: 1.0 References: <20191008095524.1585-1-ruifeng.wang@arm.com> <20191015092826.13002-1-ruifeng.wang@arm.com> <1b48d0a1-a4c0-f5f8-0246-2e050893f2c3@intel.com> In-Reply-To: <1b48d0a1-a4c0-f5f8-0246-2e050893f2c3@intel.com> From: David Marchand Date: Fri, 25 Oct 2019 10:18:12 +0200 Message-ID: To: "Hunt, David" Cc: dev , Harman Kalra , Gavin Hu , Honnappa Nagarahalli , nd , Ruifeng Wang X-MC-Unique: I7QtfMZ_O3KlORRNkvy96w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 0/2] fix distributor unit test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 25, 2019 at 10:11 AM Hunt, David wrote: > > > On 24/10/2019 20:31, David Marchand wrote: > > On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang wr= ote: > >> Bug 342 reported distributor_autotest execution suspension > >> on aarch64 platform. > >> Issue was due to lack of synchronization among threads. Distributor > >> thread and worker thread may get deadlocked. > >> Fixed synchronization issue by adding barriers. > >> > >> Another issue identified was in test case. Non-atomic operation on > >> stat value could cause value reset not been observed by worker thread > >> and mess counters. The issue was fixed by using atomic operations. > >> > >> --- > >> v3: > >> Added comments for using of C11 acquire/release semantics. (Honnappa) The comments are also something to maintain, so checking the v3 made sense to me. > >> > >> v2: > >> Fixed intermittent packet count incorrect failure. (Aaron, David) > >> Fixed Clang build on 32bit systems. > >> Additional patch to fix non-atomic operation in unit test. > > David, > > > > Can you review this series? > > Thanks. > > > > Hi David, > > I had tested this previously, including performance comparisons > against original version on x86, and saw no performance degradation, so > I Acked it. I can re-ack on the latest version now. If you think this is fine as is, I will go and apply with your ack. --=20 David Marchand