From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0B3EEA0C43;
	Tue, 19 Oct 2021 10:49:03 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EBB5A40142;
	Tue, 19 Oct 2021 10:49:02 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mails.dpdk.org (Postfix) with ESMTP id 87D4A4003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 10:49:01 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1634633341;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=mQh1lB7nmvhCwTaRHI7vznuYetOZxGYNiJSkNpf5tQ0=;
 b=S7DA/gcEZYI4YttrWtZ63rIevjA1wSnKy8PUztfzJTn2iv6H3R5stEIUQ4wHAp2TEpmnAj
 NMbt1gW3Rvf30Khq0ljhVhMxOh/jv1BBkkKho21BZHARPvfRljP1BylNm7hOvKYeJ3sES8
 cr+ncDQxTzgV6LDqG+qP5kp9HWPR2KE=
Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com
 [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-447-ewdsGimgMEK3E_IGN1vMLw-1; Tue, 19 Oct 2021 04:48:59 -0400
X-MC-Unique: ewdsGimgMEK3E_IGN1vMLw-1
Received: by mail-lf1-f71.google.com with SMTP id
 b29-20020a0565120b9d00b003fdc9b2546dso1143766lfv.14
 for <dev@dpdk.org>; Tue, 19 Oct 2021 01:48:59 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=mQh1lB7nmvhCwTaRHI7vznuYetOZxGYNiJSkNpf5tQ0=;
 b=Wjfx4SUMa395Hwlka/h0Bx6Uj3mPF0DKlfWT2Wds8mAClk4HOznFt6Yf5H/PxU48IQ
 NsSm2iyknD5Kw1lOVY3ThmbMpjBJruC2qBCNAX5UbMC/jmtzCc14iXlo8suo9vPcpdo6
 q1ududGVvko3ZkHyp6UoIvmxN3WBR9kIyzsJjviENN9xfJqu4/QhuOY7vdurdvxlo38L
 /z0Xjc7HE+xtcBSdhCZhdwYHW46nNI6eV7B84z8b3y+9yrw5KBEgW07lq7fiuiiliz5U
 0VJ6IX/Dc+P/rHRaqJBRHXDaMxavlOXF6bd0O6gueav4fSZ8VTp4hjlCtLl4BSJoCetK
 b6xQ==
X-Gm-Message-State: AOAM5336xx+mBK4fA1eWYfms19Byoa4kqFhF46uHdXUIOjQwrcoBg1Or
 VvACqNqSKr9BKoiw6auoxz/O0A5I7NpbclrNpg3aKCEGSuM+P6yYnc8+HpAL7o2N9iJfgr1Ow80
 lu2oJjjpm9rbal0GgPMg=
X-Received: by 2002:a2e:b6cc:: with SMTP id m12mr5180902ljo.297.1634633338194; 
 Tue, 19 Oct 2021 01:48:58 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxXyqSP3yIVx6G+kRIQrZ0PcAXtphmbq8UCOpPlu5bZ7FglUxqHjPtYMmVfJ38a/izJ1RGmad12Itt+RFJS5OQ=
X-Received: by 2002:a2e:b6cc:: with SMTP id m12mr5180888ljo.297.1634633338000; 
 Tue, 19 Oct 2021 01:48:58 -0700 (PDT)
MIME-Version: 1.0
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211018144907.1145028-5-andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20211018144907.1145028-5-andrew.rybchenko@oktetlabs.ru>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 19 Oct 2021 10:48:46 +0200
Message-ID: <CAJFAV8zMGfGOOv_XYLojgB7eP0DgK0auNXsqY=f0RPPwn96EnQ@mail.gmail.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Olivier Matz <olivier.matz@6wind.com>, Ray Kinsella <mdr@ashroe.eu>,
 dev <dev@dpdk.org>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 4/6] mempool: make header size calculation
 internal
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Oct 18, 2021 at 4:49 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> Add RTE_ prefix to helper macro to calculate mempool header size and
> make it internal. Old macro is still available, but deprecated.
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

No reference to this macro out there:
$ git grep-all -w MEMPOOL_HEADER_SIZE


The change looks fine to me.
I just wonder if we really need to expose this helper, is it
performance sensitive?

-- 
David marchand