From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C54C04375B; Fri, 22 Dec 2023 09:21:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E3C14025D; Fri, 22 Dec 2023 09:21:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 003544003C for ; Fri, 22 Dec 2023 09:21:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703233311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fi20+wD/SdS6J6Z4FqAI9wMgg87XuafzjAQaQVhmx9g=; b=Ry4oM/x1KcyG4D83yLRLyUsrF1bljffhKSP5wOqnawAjQzTLd0c9rOJOmU081L8MW+mvpM Jh/vTt6b60MnQwYwUKblSw551kiRHejeE/6+gKCJrZax7Apzgn6TQeS4epdDfs3qCy4Uz9 JCndtkJbTQm5Kbe4cxCiGAMcWGxoq/A= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-479-Tj6UGxarPL2Bmjgtbk7FaA-1; Fri, 22 Dec 2023 03:21:48 -0500 X-MC-Unique: Tj6UGxarPL2Bmjgtbk7FaA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2cc7944cf8eso13381341fa.3 for ; Fri, 22 Dec 2023 00:21:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703233306; x=1703838106; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fi20+wD/SdS6J6Z4FqAI9wMgg87XuafzjAQaQVhmx9g=; b=uw3luaQjfFUuTBP7CalON1txsaLFI0pCOM6BR24Q5YpQeh1eUuh/we9htGoK0Ujyvj m5uBLj3677pNKJgnWV1xK7on01qwR8ekA7yXUTFx6O3o1WsWO5Q8jNyu5Co2G2PpQ3CT ijKvTsIfYWr6ZXQgLDwm8HupfR++CFOFjcMako2Ef2rwPQV8OJ7VgoHSC9IfsR6QvCh9 Hobrwc1CDehkMUMUgrkloJwvqbG6TLd8JkCQEiIcb0F6iPSCMxUD5mMwvJPacp6zvOBZ FEyCC+85VNfVLL/P6v6BKryhMchXovk9GZdEf16DXgizaFR8mqMLaRJh7erdmTbk5CT7 xNog== X-Gm-Message-State: AOJu0YxkQYdSxotft2T5svQ6yddgTxuqULHDGd+Z45Olx0CXCjmJ/DKh vYWxKpSytKzXg8I8zpXv64nF0w/zhaJgmiMnrR/EREbY+E7dRK1SNKoDXFdaCsCxKz/BvKNMGhm VfEr9gxwDrpKxmR5C6tTXHNxPF2Q= X-Received: by 2002:a2e:8688:0:b0:2cc:6ff3:cd3d with SMTP id l8-20020a2e8688000000b002cc6ff3cd3dmr219547lji.1.1703233306797; Fri, 22 Dec 2023 00:21:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IFQuU/FNICGuCu/ZmWOjaStuj8QDzKANyQSSR0MVDQ5v0hxMhd3VTXvO3NwLghh/Xton3eSFnWsZggzFdEdZiI= X-Received: by 2002:a2e:8688:0:b0:2cc:6ff3:cd3d with SMTP id l8-20020a2e8688000000b002cc6ff3cd3dmr219510lji.1.1703233306459; Fri, 22 Dec 2023 00:21:46 -0800 (PST) MIME-Version: 1.0 References: <20231212143722.1803259-1-venkatx.sivaramakrishnan@intel.com> <20231221184001.928922-1-venkatx.sivaramakrishnan@intel.com> In-Reply-To: <20231221184001.928922-1-venkatx.sivaramakrishnan@intel.com> From: David Marchand Date: Fri, 22 Dec 2023 09:21:34 +0100 Message-ID: Subject: Re: [PATCH v3] ethdev: fix getting supported ptypes list To: Sivaramakrishnan Venkat Cc: Igor Russkikh , Selwin Sebastian , Ajit Khaparde , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Yuying Zhang , Beilei Xing , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Simei Su , Wenjun Wu , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Qi Zhang , Xiao Wang , Jie Hai , Yisen Zhuang , Jingjing Wu , Qiming Yang , Junfeng Guo , Andrew Boyer , Matan Azrad , Viacheslav Ovsiienko , Dariusz Sosnowski , Ori Kam , Suanming Mou , Long Li , Chaoyong He , Jiawen Wu , Harman Kalra , Devendra Singh Rawat , Alok Prasad , Andrew Rybchenko , Jerin Jacob , Maciej Czekaj , Jian Wang , Jochen Behrens , Thomas Monjalon , Ferruh Yigit , dev@dpdk.org, ciara.power@intel.com, ferruh.yigit@intel.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 21, 2023 at 7:40=E2=80=AFPM Sivaramakrishnan Venkat wrote: > > Incorrect ptypes list causes buffer overflow for Address Sanitizer > run.Previously, the last element in the ptypes lists to be Which driver(s) is(are) affected? We need separated fixes for backporting. > "RTE_PTYPE_UNKNOWN" for rte_eth_dev_get_supported_ptypes(), but this was > not clearly documented and many PMDs did not follow this implementation. > Instead, the dev_supported_ptypes_get() function pointer now returns the > number of elements to eliminate the need for "RTE_PTYPE_UNKNOWN" > as the last item. > > Fixes: 4790935 ("ethdev: make device operations struct private") I doubt it is a correct Fixes: tag. > Cc: ferruh.yigit@intel.com > CC: stable@dpdk.org Once the fixes are separated, then the driver API update proposed in this patch can be done in a second step (and it won't be backported). The CI caught unconverted drivers, please fix. --=20 David Marchand