From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16EF8A04B5; Tue, 29 Sep 2020 19:34:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 723BB1DA70; Tue, 29 Sep 2020 19:34:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id D503E1DA97 for ; Tue, 29 Sep 2020 19:34:24 +0200 (CEST) Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601400863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bweUqvYk2TaM5aShcHEohnnfyKsUKNUWMJmxFnrJsh8=; b=W1veZxfS28ByQ0a39c3OeA4FNWPB3QKaer+9tZ2GI5POAEgsd6zjpxJmJXX7pjeFv0oZUl nktfCa01m4ErkEz139pZDuzreVBcgh5hiGvxP5M71Gi090KHwH/+URY+ItFTEl3Eh0WpaU tjQvBXjSL2IuAJ/iPu5itD+qO2mr+js= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-113-auPRFKZ7PzKwrdZueosGHA-1; Tue, 29 Sep 2020 13:34:19 -0400 X-MC-Unique: auPRFKZ7PzKwrdZueosGHA-1 Received: by mail-vs1-f71.google.com with SMTP id u12so1586938vsh.18 for ; Tue, 29 Sep 2020 10:34:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bweUqvYk2TaM5aShcHEohnnfyKsUKNUWMJmxFnrJsh8=; b=cXSQuBneA6b2l/WkJ6D7bKP8k3ot9D+p/YlmO/AZQ9j2O4WLBB18AtW7cplq2TVq18 WXzJTinHfgRFgu93sqzsQb5qL1Yqlqpw5X1gqLiJVu73ZwOk9Cz8kxkiI0ms5X/5OLWL 3U34zHRkilUEnHZOuaFlZ5nKyGKgIenRHj9tjRCPzpjUlW4rd6MC/0OBnRl+q3juvvAU K5BGuWgV53/dJyqaB5dwJi4/Xvw9slG+Vp27eWljBCE/le9sGTfv/96sRdwNn2EXWMYF Ti8MttMejxSYiw0aOFI2E4qDAtrOi+M9qOxWVfoKa+1vIZ0VL4gdV9MHYbvURmhuW7Ht 3nqQ== X-Gm-Message-State: AOAM530d0lGppfR3/nCkV0an5IdH4JmlUg7Qj6ZJzl7Y5idIbEz5Dfg2 M0K3Sk7zEKrkxVTf3VeZQunQNX3vmsf/07wYTn8ul80CDHNO9yZuwMkjb/SdW10Iqr/FE2/hEv4 tN0/FpqJrxktBebsDotc= X-Received: by 2002:a05:6102:10c2:: with SMTP id t2mr3972099vsr.10.1601400859275; Tue, 29 Sep 2020 10:34:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpVf3HvbHNdVtPoI9OurOp7svy7rdN3z8PG3MLbmAe9COZ8eknmLMNYTQflgqDyXyeFf4TX/eh3nnaBOHhTCU= X-Received: by 2002:a05:6102:10c2:: with SMTP id t2mr3972086vsr.10.1601400859076; Tue, 29 Sep 2020 10:34:19 -0700 (PDT) MIME-Version: 1.0 References: <20200929153413.280581-1-bruce.richardson@intel.com> <20200929165502.336919-1-bruce.richardson@intel.com> <20200929165502.336919-6-bruce.richardson@intel.com> In-Reply-To: <20200929165502.336919-6-bruce.richardson@intel.com> From: David Marchand Date: Tue, 29 Sep 2020 19:34:08 +0200 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon , Ivan Dyukov Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 5/6] ethdev: fix mis-named parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 29, 2020 at 6:57 PM Bruce Richardson wrote: > > The parameter to rte_eth_link_speed_to_str was called "speed_link" in the > function prototype in the header file, but "link_speed" everywhere else. > This showed up as warnings when building the API docs, due to missing and > undocumented parameters from doxygen's viewpoint. > > Rename the prototype value to the correct name to fix these issues. > > Fixes: fbf931c9c392 ("ethdev: format link status text") > Cc: i.dyukov@samsung.com > > Signed-off-by: Bruce Richardson Already fixed with: https://git.dpdk.org/next/dpdk-next-net/commit/?id=10c835f2f57a62e50c83c764926d2481afbb60d5 -- David Marchand