From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F4F543C92; Tue, 12 Mar 2024 14:54:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4731640689; Tue, 12 Mar 2024 14:54:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5D00A402E0 for ; Tue, 12 Mar 2024 14:54:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710251673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F3rskDyuLEgNJlMhQxJ1RIKUTDKgprMEqjZ2UebU5tw=; b=gFND88Fdu/2GHg46HGl00y1vWG6N42I6w/+ISC7fzI6gtIZVTTE9V44ySbX2tRm1AOhFUO pDsqqCkkeV7FuHppEZtLAhUM510acrI2a06VKI/DCsUnQq1ESCWXuLErrwEjJOMFiDdXNc sn+ldODbHmOrMLkyAiSwzTCuRJ/XGuA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-186-6VcQ1iITMA-FZonuvwglHw-1; Tue, 12 Mar 2024 09:54:32 -0400 X-MC-Unique: 6VcQ1iITMA-FZonuvwglHw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d359de20dcso38884531fa.1 for ; Tue, 12 Mar 2024 06:54:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710251671; x=1710856471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F3rskDyuLEgNJlMhQxJ1RIKUTDKgprMEqjZ2UebU5tw=; b=QENNp70ENrd+vUoXN9BTzdkt5+I33xq9OEdCOIYv/65PLmaeUsz6GRQ4N2aASCDyFE mQFGVYtmcrj0beyEwcaNgWciBz+8Nog2+9TbW5SimwjdzsQJW1AxzxyWAA5B1Qfh7bYo TmAKfSf5T/ntOqQSyJJTbbEz5VsOn4y+R/DzjaJrcsnEA5f73KAkI8rJLMGcKZwLwZN6 Kx3wGh3tBLd6VEFu80C9xUkp5bL/wFz+lgtwi7YvqCD24C6Bg3RbWmHMajx8WKtZyek1 3nnZCYKr/gatvEo9ZShd4rGtE0HAMAVwJCN4xIHRwqbRAkjxVQApg5QlPEA4xmfJSpig pRNg== X-Forwarded-Encrypted: i=1; AJvYcCX0rFfobpLa/SfpDxQo71/PUv0qi062BOCGhJ/Pzn2m8B1HQwZ4r9yMrY/PptyYOwYwIbTUC8VVAWtR66U= X-Gm-Message-State: AOJu0YyvyMX52lGCfyuQgjwBWd9pAjZffX7F+1NPDpWl5CqBoZXJDTHw aUbM+bsy1hIVk9Nj9PoWNsOoNapF0h0ySN70PJQmwxB8OpN4AC2pPHng0uPyVKzlhw/bsKAoqg/ PN5bS7OteOphk8w0WhROMxsuwPozFwWtqWQO/xvBetpNexCMG84XfMM2Sjrx1AXdnNFCpbewy5z slBeMeY+/LDfam5Q8= X-Received: by 2002:a2e:9bd4:0:b0:2d3:e77:7801 with SMTP id w20-20020a2e9bd4000000b002d30e777801mr6188651ljj.3.1710251671141; Tue, 12 Mar 2024 06:54:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEifxd6eJtcU9Y/2AeZrMAsQ3nCa6a0wmwQ+duTl4YmViuaH8JRqe6In3WyFsZlP01S4sR22xxf2+4Ordu50Hg= X-Received: by 2002:a2e:9bd4:0:b0:2d3:e77:7801 with SMTP id w20-20020a2e9bd4000000b002d30e777801mr6188638ljj.3.1710251670834; Tue, 12 Mar 2024 06:54:30 -0700 (PDT) MIME-Version: 1.0 References: <20231212153640.1561504-1-brian.dooley@intel.com> <20240312135020.2969533-1-brian.dooley@intel.com> In-Reply-To: <20240312135020.2969533-1-brian.dooley@intel.com> From: David Marchand Date: Tue, 12 Mar 2024 14:54:18 +0100 Message-ID: Subject: Re: [PATCH v6 1/5] ci: replace IPsec-mb package install To: Brian Dooley Cc: Aaron Conole , Michael Santana , dev@dpdk.org, gakhil@marvell.com, pablo.de.lara.guarch@intel.com, probb@iol.unh.edu, wathsala.vithanage@arm.com, Ciara Power X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Tue, Mar 12, 2024 at 2:50=E2=80=AFPM Brian Dooley wrote: > > From: Ciara Power > > The IPsec-mb version that is available through current package > managers is 1.2. > This release moves the minimum required IPsec-mb version for IPsec-mb > based SW PMDs to 1.4. > To compile these PMDs, a manual step is added to install IPsec-mb v1.4 > using dpkg. > > Signed-off-by: Ciara Power > --- > .github/workflows/build.yml | 25 ++++++++++++++++++++++--- > 1 file changed, 22 insertions(+), 3 deletions(-) > > diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml > index 776fbf6f30..ed44b1f730 100644 > --- a/.github/workflows/build.yml > +++ b/.github/workflows/build.yml > @@ -106,9 +106,15 @@ jobs: > run: sudo apt update || true > - name: Install packages > run: sudo apt install -y ccache libarchive-dev libbsd-dev libbpf-d= ev > - libfdt-dev libibverbs-dev libipsec-mb-dev libisal-dev libjansson= -dev > + libfdt-dev libibverbs-dev libisal-dev libjansson-dev > libnuma-dev libpcap-dev libssl-dev ninja-build pkg-config python= 3-pip > python3-pyelftools python3-setuptools python3-wheel zlib1g-dev > + - name: Install ipsec-mb library > + run: | > + wget "https://launchpad.net/ubuntu/+archive/primary/+files/libip= sec-mb-dev_1.4-3_amd64.deb" > + wget "https://launchpad.net/ubuntu/+archive/primary/+files/libip= sec-mb1_1.4-3_amd64.deb" > + sudo dpkg -i libipsec-mb1_1.4-3_amd64.deb > + sudo dpkg -i libipsec-mb-dev_1.4-3_amd64.deb I am not enthousiastic at advertising a kind of out of tree approach. That's a bit like if NVIDIA asked us to stop testing distribution rdma-core packages and instead rely on MOFED. Why are we removing support for versions that are packaged by the main distributions? --=20 David Marchand