From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43D33A058B; Wed, 25 Mar 2020 13:54:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1ADF62C6D; Wed, 25 Mar 2020 13:54:13 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by dpdk.org (Postfix) with ESMTP id 136AB3B5 for ; Wed, 25 Mar 2020 13:54:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585140851; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UULlDTenVVkBZKp9Kcu1wP2d1cujaJ6lfbc3Ad7d/mA=; b=TghelNmtvaJdpKlk8vpEiz/pHRNFrRQtUg23X9t2nosNd8R2JroEp4e0tV35kMYLyqUMRr kO+k5qvs9506j1fFQ8TE//NzOJUDNHLhr4vGQ3Q5UQVR1H4RfQhZvYRJU1gt5F3vh80Wjp zNEoyyMMdhqe7oOYIDeoUN2Hx0oeEy8= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-Em40Sb92OqSyoZBrAk1mTg-1; Wed, 25 Mar 2020 08:54:09 -0400 X-MC-Unique: Em40Sb92OqSyoZBrAk1mTg-1 Received: by mail-vk1-f200.google.com with SMTP id e186so712258vkh.23 for ; Wed, 25 Mar 2020 05:54:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KnH70DqLbY9zOKDqcZ/7zdhuZ7mFmIavIwFoUjbYw4k=; b=B5Y6YfGd4yeC8Siva+swcfYMeYgaM7Ibj/iDovm7LKtowk1FgbARmFUFLO9aqQi56/ J2gIXhV1T6LFeZNaM1koli2O/1xuK/y6eCxXJ0AmbsYxt6GoaEGrVtVt9MAhh0irg6SG 9yEdvw8Gf/5BsOX3tHUp1h27tFbRcxm3AmhVLoKcjEgqKH4N2rfJTmL9jWSx5g+7Gtw8 X9myzosU8GuIvz7bLGkttM/3fGO/ln22OG/4Nm9HYEjgeHEwhG6d8IHKOXuAEYBRKvmB 7vmnGzDemVroXYgtbjRneoV759GsM7T5o7rHUJCgndBI/ts8Dm9AzE9HU5YfqGqysQwc d3kQ== X-Gm-Message-State: ANhLgQ1AMLdVuGXcdox0Hkm4tCJxsoA+bWjmEPzQt+jXpxmhuQFFr8fx RZeceANXetjHSis9QGQ2vxV6RzO0qj1D6XusmLc+60MutSVuTCXVcr6NXNxaIcVqMawsWI9ZeIb wlHCpXoYmblZD2+kVaKg= X-Received: by 2002:a67:905:: with SMTP id 5mr2349690vsj.105.1585140848955; Wed, 25 Mar 2020 05:54:08 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt2HhQCQgCPZrR4tIe/8WYzdGMFI5hhTtYlupMLvFADgXXULcy0QHsqV0/EMTSj4AbIngeLw5LpOrXCX53jO+s= X-Received: by 2002:a67:905:: with SMTP id 5mr2349660vsj.105.1585140848367; Wed, 25 Mar 2020 05:54:08 -0700 (PDT) MIME-Version: 1.0 References: <20191120201056.63818-1-mit@pt.net> <20200316173552.GA1972@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: From: David Marchand Date: Wed, 25 Mar 2020 13:53:56 +0100 Message-ID: To: Mit Matelske Cc: dev , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal/freebsd: fix queuing duplicate eal_alarm_callbacks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 19, 2020 at 9:48 AM David Marchand wrote: > > On Mon, Mar 16, 2020 at 6:36 PM Bruce Richardson > wrote: > > > > On Wed, Nov 20, 2019 at 02:10:56PM -0600, Mit Matelske wrote: > > > The source callback list grows infinitely when more than alarm > > > is queued. > > > > > > This fix recognizes that an alarm interrupt in FreeBSD should never > > > have more than one callback on its list, so if > > > rte_intr_callback_register() is called with an interrupt handle type > > > of RTE_INTR_HANDLE_ALARM, so if such an interrupt type already has a > > > non-empty list, then a new callback is not created, but the kevent > > > timer is restarted properly. > > > Fixes: 23150bd8d8a8 ("eal/bsd: add interrupt thread") Cc: stable@dpdk.org > > > Signed-off-by: Mit Matelske > > > > > Acked-by: Bruce Richardson > > Applied, thanks. --=20 David Marchand