From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Ma Lihong <lihongx.ma@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants
Date: Fri, 16 Oct 2020 17:47:45 +0200 [thread overview]
Message-ID: <CAJFAV8zP0+Ge5JE+N_8TwVxoPwXBJWcJBtshToqh-=NicAp+yw@mail.gmail.com> (raw)
In-Reply-To: <20200903144942.671870-1-bruce.richardson@intel.com>
Hello Bruce,
On Thu, Sep 3, 2020 at 4:50 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> A number of the more advanced DPDK build settings which are not expected to
> be user modified are stored in config/rte_config.h. In some cases, for a
> custom build a user may want to override those settings via CFLAGS, so we
> need to ensure that the definitions do not override the user-provided
> values.
>
> Bruce Richardson (3):
> config: remove explicit undefinition of unset values
> config: allow overriding some build defaults
> doc: add notes on overriding extra config values
$ CFLAGS="-DRTE_MAX_MEMSEG_LISTS=64" meson setup
--default-library=shared --buildtype=debugoptimized
-Dprefix=/home/dmarchan/git/pub/dpdk.org/build/install build
$ ninja-build -C build -j4 install
librte_eal.so is indeed built with the 64 value:
$ pahole -C rte_mem_config build/install/lib64/librte_eal.so |grep memsegs
die__process_function: tag not supported (INVALID)!
struct rte_memseg_list memsegs[64]; /* 136 8704 */
But no trace of the custom value for external applications:
$ grep -r RTE_MAX_MEMSEG_LISTS build/install
build/install/include/rte_config.h:#ifndef RTE_MAX_MEMSEG_LISTS
build/install/include/rte_config.h:#define RTE_MAX_MEMSEG_LISTS 128
Binary file build/install/lib64/librte_eal.a matches
Binary file build/install/lib64/librte_eal.so.21.0 matches
I can see the same using the meson option -Dc_args.
--
David Marchand
next prev parent reply other threads:[~2020-10-16 15:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 11:44 [dpdk-dev] [PATCH 1/2] config: remove explicit undefinition of unset values Bruce Richardson
2020-08-25 11:44 ` [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults Bruce Richardson
2020-09-01 5:17 ` Ma, LihongX
2020-09-01 6:07 ` Hemant Agrawal
2020-09-01 9:02 ` Bruce Richardson
2020-09-03 14:50 ` Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 1/3] config: remove explicit undefinition of unset values Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 2/3] config: allow overriding some build defaults Bruce Richardson
2020-09-03 14:49 ` [dpdk-dev] [PATCH v2 3/3] doc: add notes on overriding extra config values Bruce Richardson
2020-09-03 15:43 ` Hemant Agrawal
2020-10-14 14:20 ` [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants Bruce Richardson
2020-10-15 8:55 ` Chen, BoX C
2020-10-15 9:20 ` Bruce Richardson
2020-10-16 15:47 ` David Marchand [this message]
2020-10-16 15:55 ` Bruce Richardson
2020-10-16 16:46 ` David Marchand
2020-10-19 10:21 ` Bruce Richardson
2020-10-19 21:04 ` Thomas Monjalon
2020-10-20 8:34 ` Bruce Richardson
2020-10-20 10:04 ` Thomas Monjalon
2020-10-20 10:15 ` Bruce Richardson
2020-10-28 16:32 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zP0+Ge5JE+N_8TwVxoPwXBJWcJBtshToqh-=NicAp+yw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=lihongx.ma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).