From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B306CA00C4;
Tue, 26 Jul 2022 12:01:19 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A59DD40DDD;
Tue, 26 Jul 2022 12:01:19 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 0352940695
for <dev@dpdk.org>; Tue, 26 Jul 2022 12:01:17 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1658829677;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=JBmvm0UW+Ds+MDU3r/82WgbOKMW7QSZVovfxOQhYKdM=;
b=D4zDIlKiKeIHtCxuXM6MRy3swn9TpDK1WBqoP4Xy3gaWuOcsqWZbV88r/H6eVfrpUYo4Bm
6+HYs2dCfQsTz1IAGXkY+YjUf2XkxYakDUDvReyYRt11tiCRXXrL5S+/CWMYvjUfNBMa5A
On3CVXufDAXuuVTTuCQtBDUzGaXM9Yk=
Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com
[209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-79-svfrlqayNWi1spyU3C-Ilg-1; Tue, 26 Jul 2022 06:01:08 -0400
X-MC-Unique: svfrlqayNWi1spyU3C-Ilg-1
Received: by mail-lf1-f69.google.com with SMTP id
w8-20020a197b08000000b00489e72a3025so4130254lfc.4
for <dev@dpdk.org>; Tue, 26 Jul 2022 03:01:08 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=JBmvm0UW+Ds+MDU3r/82WgbOKMW7QSZVovfxOQhYKdM=;
b=kQDlitzO8v0Zt6Tkzm/Ba27oYJ2B/8ncMBdpDKRT8h9BFbTnRXSHsFHZD9k6A7PE/A
KMcZaw46oaHFQGie2iPhRi8m3Q9SszaLtOHnzlft1HC+l6oCvJBYSUFNWAmombTq7GX+
VhrdEz29mvMqSvvtPpjhcB2J3El7mAKevns93f0X+4vhg95LhOQDjNbhSRPBdcJNqo27
ieXOqwMXjNGaeCbu7NiwclyBqwcqrOxRCHF596suBHC0e424e25LNm4TIljt6sFsOch6
ifUwJk1c/5zGCGI/D9H9tZi3dZ9rU4vo0F8i1G2BPMoe8Qs7lDjqcdQi9d4COz2Ou57x
UIuQ==
X-Gm-Message-State: AJIora+gOtWvdHO9doApEl1Oc4et2HEbZyA3+pDIU9A+TgdNmwQ8uh6v
tXSb+T6pf0DHBjraWSEg7/iIuiC+NtuYlCR0fxk3iiuyPGBpPm1poHhJHCEcQXwdvLYpWjdzqEN
3lzyXeFFPxaEt+bPDsyQ=
X-Received: by 2002:a05:6512:280d:b0:489:d766:5e3 with SMTP id
cf13-20020a056512280d00b00489d76605e3mr6123532lfb.499.1658829667314;
Tue, 26 Jul 2022 03:01:07 -0700 (PDT)
X-Google-Smtp-Source: AGRyM1tDAgFqTcgT3BlaH9X+ZPKFFEqlhdzemXVsf3wmRF/PGPrFDn6FyDz36Yme0I8HAAXYjxajMzCTHre4wK6N4UQ=
X-Received: by 2002:a05:6512:280d:b0:489:d766:5e3 with SMTP id
cf13-20020a056512280d00b00489d76605e3mr6123523lfb.499.1658829666975; Tue, 26
Jul 2022 03:01:06 -0700 (PDT)
MIME-Version: 1.0
References: <20220722135320.109269-1-david.marchand@redhat.com>
<20220725203206.427083-1-david.marchand@redhat.com>
<20220725203206.427083-4-david.marchand@redhat.com>
<4cd4f7bf-da0d-5ddd-9783-afd7c1b1a3fc@redhat.com>
In-Reply-To: <4cd4f7bf-da0d-5ddd-9783-afd7c1b1a3fc@redhat.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 26 Jul 2022 12:00:55 +0200
Message-ID: <CAJFAV8zPDyy3dvYz9GZJ0w4js0wObgANmT6hmkq9Zj+KC-q=8w@mail.gmail.com>
Subject: Re: [PATCH v3 3/4] vhost: keep a reference to virtqueue index
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, Chenbo Xia <chenbo.xia@intel.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Tue, Jul 26, 2022 at 10:52 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
> > @@ -2275,12 +2267,11 @@ rte_vhost_clear_queue(int vid, uint16_t queue_id, struct rte_mbuf **pkts,
> > }
> >
> > if ((queue_id & 1) == 0)
> > - n_pkts_cpl = vhost_poll_enqueue_completed(dev, queue_id,
> > - pkts, count, dma_id, vchan_id);
> > - else {
> > + n_pkts_cpl = vhost_poll_enqueue_completed(dev, vq, pkts, count,
> > + dma_id, vchan_id);
> > + else
> > n_pkts_cpl = async_poll_dequeue_completed(dev, vq, pkts, count,
> > - dma_id, vchan_id, dev->flags & VIRTIO_DEV_LEGACY_OL_FLAGS);
> > - }
> > + dma_id, vchan_id, dev->flags & VIRTIO_DEV_LEGACY_OL_FLAGS);
>
> One of the two functions should be renamed for consistency, but that's
> not the point of this series.
The async prefix makes sense, so renaming vhost_poll_enqueue_completed
as async_poll_enqueue_completed seems the way to go.
I don't mind sending a separate patch for this.
--
David Marchand