From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DBBDA0A0F; Wed, 30 Jun 2021 10:34:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86B0A40141; Wed, 30 Jun 2021 10:34:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7129740040 for ; Wed, 30 Jun 2021 10:34:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625042075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bfDTmifogP/Kn29IM2KhW4OGvzU6/IoMYVphIm8x3Yc=; b=ASlXsNw3ewn86bu4LLaAdNH/Fd7uOauBftEHbzQdgE0b2tGKcIJSjdYwM97bQTkkjJnpuB HLbP3EyYORvcHO6A9XBGGzQRc5iRUwB7SANticzMfSwl2bCjfYQ11yaOVDchhWguP46Jrs 0vw5TAnYMBrrWpID+vYBGpykvoPg/NQ= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-U-s3xS-LMNisPX8TT4yKpw-1; Wed, 30 Jun 2021 04:34:34 -0400 X-MC-Unique: U-s3xS-LMNisPX8TT4yKpw-1 Received: by mail-vs1-f70.google.com with SMTP id g3-20020a67fac30000b0290279c2771f64so732416vsq.8 for ; Wed, 30 Jun 2021 01:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bfDTmifogP/Kn29IM2KhW4OGvzU6/IoMYVphIm8x3Yc=; b=UaVYYscLx+qssOfJzJBS0IXQNjRP7TsDcT3AcXud2aqxaqYvTZaIroPLB9I/+Z0uiO T7i2Cu5XM6aGs1LxeYrmlXNxYznBiAeSYf1goDduld0bbvS2tBxOjleLlDWrXaU5gX1Z AIyoV3eM1+FdLERNSipNzwcf+V98rwBiEC3PFZmxLSd8/JaE4lqTIBC5x23YjQG83fOF gsfPz50NzMfQfcPM4fFEnAOTFerKfqWgdYiZ+KyBEoydBZc+Ckacwjv1iFBy/883evvE LY1hZhe3TH6VPjbI0NZS/2esfpEyW3rGDSY2fzpZoT3WMAujZ2/rWx0eN5aHJJROwPY2 3tNA== X-Gm-Message-State: AOAM530Kfj3CfsudCqTM7kMnU+Ge3QtiNhabiZpH8g/23WRusJbhffv9 dJDZsImJG72QdleaA3yd3rvqglU/f/KOsW9XnosMIhQxkPDbIvVwXNhySdlv4Qfy+3+X3GJkKr0 tnIeWTc+WvcT3EdGlq/0= X-Received: by 2002:a67:fe90:: with SMTP id b16mr29424336vsr.5.1625042073888; Wed, 30 Jun 2021 01:34:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTPCOIK4hEn0S62MT7+C7VF+Raxr1m+qV1LRWEy8s+MKumupIj3x5L1LS15EF3H850lItfCSN0AielFXek39Q= X-Received: by 2002:a67:fe90:: with SMTP id b16mr29424328vsr.5.1625042073625; Wed, 30 Jun 2021 01:34:33 -0700 (PDT) MIME-Version: 1.0 References: <20210610051352.48493-1-zhihongx.peng@intel.com> <20210615081205.101071-1-zhihongx.peng@intel.com> <8af553e7-29e1-b46d-dc68-32efaa17c9c0@intel.com> In-Reply-To: <8af553e7-29e1-b46d-dc68-32efaa17c9c0@intel.com> From: David Marchand Date: Wed, 30 Jun 2021 10:34:22 +0200 Message-ID: To: "Burakov, Anatoly" Cc: "Lin, Xueqin" , Jerin Jacob , "Peng, ZhihongX" , "Ananyev, Konstantin" , Stephen Hemminger , dpdk-dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC v2] porting AddressSanitizer feature to DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 28, 2021 at 4:22 PM Burakov, Anatoly wrote: > > On 18-Jun-21 10:04 AM, David Marchand wrote: > > On Fri, Jun 18, 2021 at 9:49 AM Lin, Xueqin wrote: > >>>> Suggest listing demo code and tool capture information for user to try if > >>> tool works, also add this part into doc. > >>>> > >>>>> > >>>>> # Also, Please update the release note for this feature. > >>>> Sure, we can update the release note if code merge. > >>> > >>> Probably you can send v1 version next i.e change the RFC status to get > >>> merged. > >> > >> Sure, we will send v1 patch if no obvious objection for that, hope patch could receive some ACKs and could success to merge, thanks. > > > > How did you test this work? > > > > UNH recently started testing with ASAN and it reveals leaks just in > > the unit test. > > > > Merging these annotations will help catch more issues. > > But users will hit the current issues that we must fix first. > > > > As far as i can tell, the regular build is not affected by this patch, > so no issues will be hit until someone actually runs the test. IMO it's > better to merge it early to catch more issues than to gate the feature > on the condition that we fix all bugs unrelated to this feature first. - This is affecting more than unit tests. $ meson setup build-asan -Db_lundef=false -Db_sanitize=address ... $ ninja-build -C build-asan ninja: Entering directory `build-asan' [2801/2801] Linking target app/test/dpdk-test $ ./devtools/test-null.sh build-asan EAL: Detected 28 lcore(s) EAL: Detected 1 NUMA nodes EAL: Detected static linkage of DPDK EAL: WARNING! Base virtual address hint (0x100005000 != 0x7fb31c632000) not respected! EAL: This may cause issues with mapping memory into secondary processes EAL: Multi-process socket /run/user/1001/dpdk/rte/mp_socket EAL: Selected IOVA mode 'VA' EAL: VFIO support initialized EAL: WARNING! Base virtual address hint (0x10000b000 != 0x7fb31c3b2000) not respected! EAL: This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100011000 != 0x7fb31c375000) not respected! EAL: This may cause issues with mapping memory into secondary processes EAL: WARNING! Base virtual address hint (0x100017000 != 0x7fb319bfe000) not respected! EAL: This may cause issues with mapping memory into secondary processes Interactive-mode selected Auto-start selected [...] Bye... EAL: recvmsg failed, Bad file descriptor EAL: recvmsg failed, Bad file descriptor EAL: recvmsg failed, Bad file descriptor EAL: recvmsg failed, Bad file descriptor EAL: recvmsg failed, Bad file descriptor EAL: recvmsg failed, Bad file descriptor Infinite loop of those messages. In the thread with Owen, we also noticed what looks like a deadlock with multiprocess when ASAN is enabled. - Adding a new feature on top of something that does not work yet seems at best premature to me. This patch does not seem that much tested, since those issues above are fairly easy to catch. Anyway, the memory allocator is your stuff, so your call. Prefix for the title of such a patch should be mem:. -- David Marchand