From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16E2DA056B; Tue, 3 Mar 2020 09:42:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C59A1BFF9; Tue, 3 Mar 2020 09:42:38 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id C1C951BFF0 for ; Tue, 3 Mar 2020 09:42:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583224956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7DxLBQj9ttKsWerWoPykcw0RaauiX1VDcQxE9X4ituk=; b=Myh1/Ra2+kfOWuTavh+nINzrOLpFqmsciaapM2qpKULaUvib+OMlGbm46l5t+pjy3oebo6 pBFJHF76W5Qucz5bFyGNhvMoAdFXbhYe9ieFhYxTogZCoyvfhhMRCxClj1pgHP7K6IcL3T Gt7zAi1Re2xqJ2N6+jsujgVa2St9pTk= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-O35dIGeHOD6gkmt1Hue-Xw-1; Tue, 03 Mar 2020 03:42:33 -0500 X-MC-Unique: O35dIGeHOD6gkmt1Hue-Xw-1 Received: by mail-ua1-f72.google.com with SMTP id a30so825208uae.6 for ; Tue, 03 Mar 2020 00:42:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PXsL1hlX17BdS5b8sUpRs3vc91f78EM4sq2TKiHJKls=; b=eS2qJB0PXxVHceQ++oaQRRLE0vNKf9crNXt+igI+hanwKq0E6GUL1s7582MfbQ4qRv 3O6BYsgaVOflmHN3OCP+6rE6z6/4HunW1W2TjGtACQs+HCrkPYKD6puIqIbiFdImbCqL Qh6X+wM+FxtL590WP8HqsY2dKxWTdlJa9Ci2ALmV6XfRbuqCqf2YNtF+veoypBM9abB1 /urblRbqPLLBWVttlnqc4/9ZzoBLmr9Tx14AnN/KH8s/EkVBBnPjenewFkoCIPOV8Y+x sp7F2SGDnKiFcohP9aDA5xd/zxqMpswLVFJA9L681m695MB4k/3WI9fiNxex7J3vb64S tW0g== X-Gm-Message-State: ANhLgQ0Zgi6gD+OdA1zs3m36QM11KOU9gnvV5+qe4N5x+M0bSP09eF72 hr6vdqtjmhUVWs7ushGTC63lQ9O58bhCSr9V/9q2dmADLqgnuh5r5ua0EqFw4hzK/s4Igt2RQVD 79xPFdfLoAa7ch4QID+Y= X-Received: by 2002:ab0:6796:: with SMTP id v22mr2131919uar.41.1583224952499; Tue, 03 Mar 2020 00:42:32 -0800 (PST) X-Google-Smtp-Source: ADFU+vuIOFF5fr+lXHkhi5zf6TviLfmemUfx0pVUCfMGm4ULriuoIKzYa/wCj8YSTa339mEw36Jf9t9QI7NmjXDGAbM= X-Received: by 2002:ab0:6796:: with SMTP id v22mr2131913uar.41.1583224952223; Tue, 03 Mar 2020 00:42:32 -0800 (PST) MIME-Version: 1.0 References: <20200226075503.GA108150@intel.com> <20200227141840.15835-1-i.dyukov@samsung.com> <20200227141840.15835-2-i.dyukov@samsung.com> In-Reply-To: <20200227141840.15835-2-i.dyukov@samsung.com> From: David Marchand Date: Tue, 3 Mar 2020 09:42:21 +0100 Message-ID: To: Ivan Dyukov Cc: dev , Maxime Coquelin , Tiwei Bie , Adrian Moreno Zapata , Zhihong Wang , Xiaolong Ye X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5 1/4] net/virtio: refactor devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 27, 2020 at 3:20 PM Ivan Dyukov wrote: > > refactor vdpa specific devargs parsing to more generic way > > Signed-off-by: Ivan Dyukov > --- > drivers/net/virtio/virtio_ethdev.c | 34 +++++++++++++++++++++--------- > 1 file changed, 24 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virt= io_ethdev.c > index 044eb10a7..d2c7f8c61 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c [snip] > @@ -1995,8 +2001,16 @@ vdpa_mode_selected(struct rte_devargs *devargs) > static int eth_virtio_pci_probe(struct rte_pci_driver *pci_drv __rte_unu= sed, > struct rte_pci_device *pci_dev) > { > + int vdpa =3D 0; > + int ret =3D 0; > + > + ret =3D virtio_dev_devargs_parse(pci_dev->device.devargs, &vdpa); > + if (ret < 0) { > + PMD_INIG_LOG(ERR, "devargs parsing is failed"); PMD_INIT_LOG https://lab.dpdk.org/results/dashboard/patchsets/9772/ https://travis-ci.com/ovsrobot/dpdk/builds/150851427 --=20 David Marchand