From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 551DFA0A0F; Mon, 5 Jul 2021 15:34:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE9D540040; Mon, 5 Jul 2021 15:34:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 3A31C4003C for ; Mon, 5 Jul 2021 15:34:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625492093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xTvScg7WDxcXIC9gw58FDwMC71kvo8Ci2LVwb2Gop+A=; b=NtaktmchP2O84/9eDjNK6Wa0XNbeNJrYqehaABrg4YTa4UPnXonkC4jmjIbwG4Ukn6BXwc E4sFvqUU1GWtdZEEvPvecn4UJoyxLe49WQ1OgMbGKmPbMsanECXFNVd8dcf/YdXQVXH/yQ TYl9ruVdWDP1DPydzPfGzU6U8BVP6s0= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-W2GgoUg_OWS8DiMqh0e-FA-1; Mon, 05 Jul 2021 09:34:52 -0400 X-MC-Unique: W2GgoUg_OWS8DiMqh0e-FA-1 Received: by mail-ua1-f72.google.com with SMTP id c24-20020ab069580000b0290294f1e254c0so6035102uas.21 for ; Mon, 05 Jul 2021 06:34:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xTvScg7WDxcXIC9gw58FDwMC71kvo8Ci2LVwb2Gop+A=; b=ddOfRw+AWYiXvHbSXcOXkT+b+dijzVc0TqVKO1YC6ouO2MCnUFmEk3UNhGy2Ei7RlL OFfzlD5LgDmWPrmWlVVU9yglEwYC+siOM58GF0ad5fZmIJbmRQiLlXvU5bGMpC+FMeJq erm+l0aEa+MQgk4yo6/++vPMS2HgaYTJpX80i2maYmphBan0DEzWPcMDagcd95BtThlm zROEJYXCexXZ00hoJJApHQIKeEXf3+Vx5xSYiCOJmQELkRjwgOnaR0NNV6Hq2hygjdfX 8EO/Qv2M0oyKN8SQ4WKvuO/JfknOXZ29z2C6zOYA/IADIr437cn91EVovWhCOWmt31Eu mLKQ== X-Gm-Message-State: AOAM53013LJ5SUzNiFPJyzBTaafTwKIM7MzBS1C3XeCimsX/odY0g7pj SJMpPKROtZg37dL7a8NRAOhswGxylFn6inSyVPRjTuDWmr/6AdWlqVwXE5YxWCpy/nrPlIXZqqg 6Q71G0/7GG9Evm2UEXIY= X-Received: by 2002:a05:6102:3196:: with SMTP id c22mr1792581vsh.27.1625492091883; Mon, 05 Jul 2021 06:34:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqNbf1/sNNnblpgWlh7XJfgUUJXfFI8B0jVJjyyyJ8sK8IEN+rqHQUi6VaGPObQSchioOZYwWXATC02prjX64= X-Received: by 2002:a05:6102:3196:: with SMTP id c22mr1792565vsh.27.1625492091747; Mon, 05 Jul 2021 06:34:51 -0700 (PDT) MIME-Version: 1.0 References: <20210602095836.24901-1-david.marchand@redhat.com> <20210629080632.30964-1-david.marchand@redhat.com> <20210629080632.30964-2-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 5 Jul 2021 15:34:40 +0200 Message-ID: To: "Wang, Haiyue" Cc: "dev@dpdk.org" , "Yang, Qiming" , "Zhang, Qi Z" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 5, 2021 at 3:18 PM Wang, Haiyue wrote: > > > -----Original Message----- > > From: dev On Behalf Of David Marchand > > Sent: Tuesday, June 29, 2021 16:07 > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Zhang, Qi Z > > Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading > > > > Both "normal" and "dcf" inits have their copy of some firmware loading > > code. > > > > The DSN query is moved in specific parts for the "normal" and "dcf" init. > > > > A common helper ice_load_pkg is then introduced and takes an adapter > > pointer as its main input. > > > > This helper takes care of finding the right firmware file and loading > > it. > > The adapter active_pkg_type field is set by this helper. > > > > The ice_access macro is removed from the osdep.h header: osdep.h should > > only hosts wrappers for base driver code. > > > > Signed-off-by: David Marchand > > --- > > drivers/net/ice/base/ice_osdep.h | 6 -- > > drivers/net/ice/ice_dcf_parent.c | 97 ++----------------- > > drivers/net/ice/ice_ethdev.c | 161 +++++++++++++++---------------- > > drivers/net/ice/ice_ethdev.h | 3 +- > > 4 files changed, 88 insertions(+), 179 deletions(-) > > > > Squash into a single patch seems great help to understand the compress firmware > context. ;-) > > But it's OK as two patches. > > Acked-by: Haiyue Wang Cool, thanks for the review and test! -- David Marchand