From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0AF83A045E for ; Wed, 29 May 2019 22:11:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2D4C01B944; Wed, 29 May 2019 22:11:55 +0200 (CEST) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id 6D6E04F91 for ; Wed, 29 May 2019 22:11:53 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id m13so77144vsq.12 for ; Wed, 29 May 2019 13:11:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hGYNmKG1JFImdxn0Gl1j08PNQn10V4BXCk1bRUSHk5w=; b=D55hTHiEQkjzY/RKw2cfDHvO6+UpxkDB6F0aydjcCOrhLnr2QX01VP3WEfuqQdDsKT cvbFNvOPcjWH4L78dDsuY0urO8aOpX3T99SCfg1/1XoNTlAvoEGy8o+NfLXmX0y25cyV c2rgLIC10PfWargGMVPYaV1gV2wqFfKMm383sShyLd+PH+wrIb1Cj00od8rNrlb+tZOD GV9WMUtDX+Gh8lWCqhPxasEaj9u/TaVQZFRPxsC9A7sIk7vtr2EH5xqDIfn7Qv+keeMX gfbuM1O06Boa7hTrYjR07Ml1R5aO61+bPtB8aALMHE1dhcXd031T9ButIcz/EGr5DUGL i6Jg== X-Gm-Message-State: APjAAAUolJfJpDJJc4wiRW6aFaZBbu3kH01qf7+OiJ+MVENo0jAUs278 KGD1KSEATT6kWRQLWhBuipqwB1ClmW2FpqE/lAvd3g== X-Google-Smtp-Source: APXvYqxmltjFB6/IWrr3VQTyrGoinG/dTc520NQRvl3QPL9bQfOJkbaGvDz1Hk5Xq79u99JUUkYGjtRrwpjwP16A53I= X-Received: by 2002:a67:fd85:: with SMTP id k5mr73343413vsq.29.1559160712812; Wed, 29 May 2019 13:11:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 29 May 2019 22:11:41 +0200 Message-ID: To: Anatoly Burakov Cc: dev , Stephen Hemminger , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/25] Make shared memory config non-public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 29, 2019 at 6:31 PM Anatoly Burakov wrote: > This patchset removes the shared memory config from public > API, and replaces all usages of said config with new API > calls. > > The patchset is mostly a search-and-replace job and should > be pretty easy to review. However, the changes to ENA > I went and did the same job with some scripts. Not sure you really need to split in all those patches. We are not going to backport this. Some changes are mixed, the kni changes are in the hash: patch. I spotted a missed qlock in : lib/librte_eal/common/eal_common_tailqs.c: rte_rwlock_read_lock(&mcfg->qlock); lib/librte_eal/common/eal_common_tailqs.c: rte_rwlock_read_unlock(&mcfg->qlock); On the names of the functions, could we have something shorter ? The prefix rte_eal_mcfg_ is not necessary from my pov. driver are of particular interest, because they're using > the shared memory config in a way that i find confusing. > I thought the same when I looked at it before. Hopefully the ena maintainers will enlight us :-). I tried to implement the equivalent changes as well as > i could, but since the code doesn't make any sense to me, > i would really like to request help from ENA maintainers. > > Everything else should be pretty straightforward. > We are missing the deprecation notice removal at the end of the series and a note in the release notes. Thanks Anatoly! -- David Marchand