From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A90BA0543; Tue, 6 Dec 2022 11:18:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E87940A7F; Tue, 6 Dec 2022 11:18:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5B2594021D for ; Tue, 6 Dec 2022 11:18:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670321901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0dM9xT7JRn1cpgiQr7rXkkG79cHvHAKLloTztUk7+ak=; b=POnNYp0h9RRkM0iJZHieWWdlaSVPPcvtNLBlv7WXLKqs8d75VuHRvNWX1qHQAkNv2mlUgf KHdrqu80hsMnPbRKZA+37yBV6rVrxGEy5tLfLWU2f5UAcbEZ+wSBJ2RXhl6sH87UPJWNpb nmoI9xIeIN1nZ/wF2D6u+n0I5tOq/0g= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-507-FFyMo5QzMSKtVoJsT969tQ-1; Tue, 06 Dec 2022 05:18:20 -0500 X-MC-Unique: FFyMo5QzMSKtVoJsT969tQ-1 Received: by mail-pf1-f197.google.com with SMTP id z19-20020a056a001d9300b0056df4b6f421so12794321pfw.4 for ; Tue, 06 Dec 2022 02:18:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0dM9xT7JRn1cpgiQr7rXkkG79cHvHAKLloTztUk7+ak=; b=kxhfb+Sdrl3WI2NX3paQeRld+9jOflnrQeE9u2EJdTxrqvYgY/H7mKn1S4WgEzUs2H oZyhGT41+zt4zW8I3SeVwT0EH2+GAQUb7zAbYVjnf2mBN78hqV7Gfq5oz6fD0B/j2ieE UT4XQ6MigmhRTOefIHxD5squ+zLviJiiRQOruyQRdx+phEt0lS5DKfn34dHEkQHpBgdF h7K5PxhGD9BMNvNnkTnKo75ejCgO752aIEGxPIkJHh3ErnSdmbkzI98wQBZjiV3lJqvJ XiNA0BMgBVCN2DbOD77bO1TrL40yZ5PO9QgNnZ5FgeEFY1JqHkf6hsOyb14mT5zK4GCk GxGw== X-Gm-Message-State: ANoB5pncv3LdfTVaTCHBK8+IXPXFyQCZxmVYl2N+yT8dr2GWQDaHYHhB CMB/Hajbc0cpdAagJ1nbWTTKoBrwS+vA1G1ng3m713hsfRPyF0Qn4Iku4Ct0ElVzn5Es3ldHWr4 4TtUgGVud6KF1zsj/A+8= X-Received: by 2002:a17:90a:ab08:b0:219:aea9:4487 with SMTP id m8-20020a17090aab0800b00219aea94487mr15466723pjq.161.1670321899617; Tue, 06 Dec 2022 02:18:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf4uiObTzqufQgPK7Xtx9odjH+CxoR08yaBaWbCihHQzI/j3YcG+lDMvZsB3jTe3gVgcdNecmowwXfUL1iNIE28= X-Received: by 2002:a17:90a:ab08:b0:219:aea9:4487 with SMTP id m8-20020a17090aab0800b00219aea94487mr15466698pjq.161.1670321899380; Tue, 06 Dec 2022 02:18:19 -0800 (PST) MIME-Version: 1.0 References: <20221129140032.35940-1-david.marchand@redhat.com> <1923653.yKVeVyVuyW@thomas> <734b4cca-331a-9a6e-8300-3bf024e326d9@amd.com> In-Reply-To: <734b4cca-331a-9a6e-8300-3bf024e326d9@amd.com> From: David Marchand Date: Tue, 6 Dec 2022 11:18:07 +0100 Message-ID: Subject: Re: [EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted To: Ferruh Yigit Cc: Thomas Monjalon , Akhil Goyal , "ci@dpdk.org" , Andrew Rybchenko , Ajit Khaparde , Qi Zhang , Jerin Jacob Kollanukkaran , Raslan Darawsheh , Maxime Coquelin , "Xia, Chenbo" , Luca Boccassi , Kevin Traynor , Christian Ehrhardt , "Xueming(Steven) Li" , "dev@dpdk.org" , "stable@dpdk.org" , Bruce Richardson , Michael Santana , =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= , Aaron Conole X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 6, 2022 at 11:13 AM Ferruh Yigit wrote: > On 12/5/2022 3:37 PM, Thomas Monjalon wrote: > > 05/12/2022 14:47, Akhil Goyal: > >> But adding a tag on same repo is more convenient from developer point of view. > >> However, it is my personal view, others may differ. > > > > From developer point of view, you should use devtools/test-meson-builds.sh > > which does the "git clone" for you. > > > > This is what I have in ~/.config/dpdk/devel.config > > export DPDK_ABI_REF_DIR=$root/dpdk-build/abiref > > export DPDK_ABI_REF_VERSION=v22.11.1 > > > > Does it help to update 'test-meson-builds.sh' to use an environment > variable to select which repo to clone? > If so, I can send a patch for it. I was wondering too... I would expect most maintainers have the stable repo in their config but it would not hurt to handle the case when they don't for others. +1 -- David Marchand