From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B94D41C4B; Thu, 9 Feb 2023 09:52:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0EFA240DF8; Thu, 9 Feb 2023 09:52:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6C4594067B for ; Thu, 9 Feb 2023 09:52:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675932733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0liZDK2aVoB8x3+ob26vqOiiWrafD0XOdnIrtpdirI0=; b=afrM4bx4PoTLBmLEBUADSbDue7JqVpdhgo0l3TZyDfuJw/NxQ0fTjX4HiAgUkQb5gNx9+R AyVIs61rMF8fOYe7l9y5ed2+/puQ5tMI43Cw7VScw23x83cMZss6YTlCi5MQvNV0qZFOQV 6Ch1J6jOz22Plif4lQvquH7oJdjWeh4= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-169-H1bTUPBXOKqWVU-_yKHsBg-1; Thu, 09 Feb 2023 03:52:11 -0500 X-MC-Unique: H1bTUPBXOKqWVU-_yKHsBg-1 Received: by mail-pj1-f72.google.com with SMTP id oo13-20020a17090b1c8d00b0022936a63a22so2644580pjb.8 for ; Thu, 09 Feb 2023 00:52:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0liZDK2aVoB8x3+ob26vqOiiWrafD0XOdnIrtpdirI0=; b=IqWlA9f2tmBXv6S3908hI4oj/okuoXTD8YCRLK00JKX7i+2DoUiVkMkpHc1PoMMZif hsExhGNuK/10YmWwTI1FtC/igpn2T0G16JS0s99kQSwwLD6ZOzUk59fEst6J6teeBDRL YFI4UpW+WdbzPKlWvhfqIeb30OCJLKx4qfdSMn+XWwsJ+FUYCk6MVCvtqT5qKtgRh4JQ H9t4cvlSh2Us7HepKQ/6pzpZAHVy+fwts1hwR1gFDkt0uro8wzCU8nuuzah8YJgCqyOq aCZJ8dq4E7o8oJE+6UJc1NDBmpRjEnbogEPA9ijifbfOwKOTsiOJn1aSE4ByOTPgJ5IX rVbw== X-Gm-Message-State: AO0yUKVo7sZWQMoW8qCW3L92F40Ae3ycIQX2Q3b2xhrII/2s/Av/DKWX o+95Q/7/B2glPYCectBuLqL484SKvqxbFh2Mz0CY2gg/n6SfkTTqB2wyWnpFq2BoCJRA48sQhDf XeCnB/OgXSjlBKJa2KmU= X-Received: by 2002:a17:902:968c:b0:19a:5a4b:2d27 with SMTP id n12-20020a170902968c00b0019a5a4b2d27mr351413plp.32.1675932730225; Thu, 09 Feb 2023 00:52:10 -0800 (PST) X-Google-Smtp-Source: AK7set+fu/zt1L3e6JkKSlvbKLTgsG9oQhu47fmSrPbp0OvC97LPSQMFb9ur8KU3Fkz1Muq4RU57M5oSqJnr+1jl+v0= X-Received: by 2002:a17:902:968c:b0:19a:5a4b:2d27 with SMTP id n12-20020a170902968c00b0019a5a4b2d27mr351406plp.32.1675932729963; Thu, 09 Feb 2023 00:52:09 -0800 (PST) MIME-Version: 1.0 References: <1670271868-11364-1-git-send-email-roretzla@linux.microsoft.com> <1675891595-28366-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1675891595-28366-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 9 Feb 2023 09:51:58 +0100 Message-ID: Subject: Re: [PATCH v6 0/3] eal: deprecate last use of pthread_t in public API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, olivier.matz@6wind.com, stephen@networkplumber.org, mb@smartsharesystems.com, hofors@lysator.liu.se X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 8, 2023 at 10:26 PM Tyler Retzlaff wrote: > > Announce deprecation of rte_ctrl_thread_create API which is the final > remaining stable API exposing pthread_t. > > Provide an equivalent replacement API rte_thread_create_control that > uses the new rte_thread_t type. > > Provide a unit test for the new rte_thread_create_control API > (test code provided by David Marchand.) > > Add missing doxygen index for thread / rte_thread.h. > > Notice! > > To limit compatibility regression risk and ease removal of the > existing rte_ctrl_thread_create in the future duplicate most of the > existing implementation rather than try to have it accommodate both > public API contracts. > > The duplication, the union introduced to support it along with remaining > internal pthread_xxx calls will be removed when rte_ctrl_thread_create is > finally removed. > > The old unit test for rte_ctrl_thread_create is kept in place to guarante= e > correct behavior while deprecated and will be removed when > rte_ctrl_thread_create is finally removed. > > Series-acked-by: Morten Br=C3=B8rup > Reviewed-by: Mattias R=C3=B6nnblom > > v6: > * fix missing comma in doxygen index > * combine deprecation notice for rte_ctrl_thread_create into notice > of removal of rte_thread_setname. > * remove test_lcore.c test and add test provided by David Marchand > to test_threads.c. > * rename the function to start with rte_thread to be consistent > with the rest of functions in the rte_thread.h APIs. Thank you Tyler. The series lgtm. The deprecation notice is missing one ack, I'll still wait a bit. If we don't get it soon, I'll apply the first two patches for rc1. --=20 David Marchand