From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A43D8A034F;
	Mon,  7 Jun 2021 11:29:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2BFDD4067E;
	Mon,  7 Jun 2021 11:29:00 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mails.dpdk.org (Postfix) with ESMTP id 6D97F40147
 for <dev@dpdk.org>; Mon,  7 Jun 2021 11:28:58 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1623058138;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=8/mMCsGEQBZAiWFXP5e5RprHv+BsfS9crAoGx0bVGug=;
 b=dJLLz4IwfA+uK1W0rPzvdQT8Is6jXlcaR/bOmHtHd5IfTQ0qgknul6rJvG7INw3XB6iNzC
 pAT+Z/ZSdrq6X603phqOyyhm2965rTLOmWVcAoNvNLZh6ydF3c8zZYUhpL0dkyC0jAKDZM
 lpWyV1q5ukPmmQP2UIfEPO25u0sJywQ=
Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com
 [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-236-xqR2y_VbNzSIcnIDCyNPSg-1; Mon, 07 Jun 2021 05:28:56 -0400
X-MC-Unique: xqR2y_VbNzSIcnIDCyNPSg-1
Received: by mail-ua1-f71.google.com with SMTP id
 78-20020a9f26540000b02902426fc5ddd3so5559827uag.16
 for <dev@dpdk.org>; Mon, 07 Jun 2021 02:28:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=8/mMCsGEQBZAiWFXP5e5RprHv+BsfS9crAoGx0bVGug=;
 b=QW6yhqrgVOzktaJH+cscAC4HkTZBY5bT5l1uBS1NiXX+GdLsxZPxW6jkGO8nEXZe6P
 pvIqPYQ6no/cNMvDySBmC3sdc9IBFuPs+dg5ofjZihC5qEd62z2F557vTyUlSzGjjaZe
 viu8wk0zCOvt4HXlumozclfvddaO3LYwZhFtk2TOmTjCxMSjDOdVY2PEllD1cqqKRkKI
 U1InGQgCNkE4ELLLdF3btQiXRJabZf9Cn6mxlmWrJCWelx2WATu0BSL0is5YKa1sz5GD
 Zdxcl8efFBLLvVtH3ZJQrc/8q66r7uluIlF1C7UPWaiLS+oJxERin0NL4LITcR7zvAcp
 0rhQ==
X-Gm-Message-State: AOAM530dWose4/YDetu6ZDqeiwOVKUCBoyTftger40mNRA3BEzAdMXao
 iSUhYJUYEJbGdaKauZ14n5Ur97Wr5VLwkhlmpwDG1eWNr0e/Aj1A6ptWmGq5JWgMHH4Y+6FCHxz
 PfEkKv2NRJ3x/qjCiLXI=
X-Received: by 2002:a05:6122:553:: with SMTP id
 y19mr1796643vko.20.1623058136254; 
 Mon, 07 Jun 2021 02:28:56 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxPH2xQjL7jrlYnEDjLVxfIZ2V/11WaWHTJLd1nyDWJaMjkVReUZ26cP4YbKBDM0xvg9F4RtnAaN/KX6fM6/h4=
X-Received: by 2002:a05:6122:553:: with SMTP id
 y19mr1796633vko.20.1623058135982; 
 Mon, 07 Jun 2021 02:28:55 -0700 (PDT)
MIME-Version: 1.0
References: <20210602095836.24901-1-david.marchand@redhat.com>
 <20210603165512.7357-1-david.marchand@redhat.com>
 <20210603165512.7357-3-david.marchand@redhat.com>
 <20210604012922.63574cff@sovereign>
 <CAJFAV8yYFOXM6aeYpdFpvP0+JRRsK2VjAWAxfkFWG5t=nEqA0Q@mail.gmail.com>
 <20210605004024.660267a1@sovereign>
In-Reply-To: <20210605004024.660267a1@sovereign>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 7 Jun 2021 11:28:44 +0200
Message-ID: <CAJFAV8zS-kS3x6QmWXOd1fr1voMMi95OjRL71_UKT93aEOmi_w@mail.gmail.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev <dev@dpdk.org>, Igor Russkikh <irusskikh@marvell.com>, 
 Aaron Conole <aconole@redhat.com>, Michael Santana <maicolgabriel@hotmail.com>,
 Bruce Richardson <bruce.richardson@intel.com>, Rasesh Mody <rmody@marvell.com>,
 Shahed Shaikh <shshaikh@marvell.com>, Qiming Yang <qiming.yang@intel.com>, 
 Qi Zhang <qi.z.zhang@intel.com>, Heinrich Kuhn <heinrich.kuhn@netronome.com>, 
 Devendra Singh Rawat <dsinghrawat@marvell.com>, Ray Kinsella <mdr@ashroe.eu>, 
 Neil Horman <nhorman@tuxdriver.com>, 
 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
 Dmitry Malloy <dmitrym@microsoft.com>, 
 Pallavi Kadam <pallavi.kadam@intel.com>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: handle compressed firmwares
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 4, 2021 at 11:40 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> > I had tried something close when preparing v2 (only keeping
> > RTE_HAS_LIBARCHIVE in config/meson.build and putting extra_ldflags and
> > ext_deps in lib/eal/unix/meson.build) but both my try and your
> > suggestion break static compilation for the helloworld example.
> >
> >
> > $ ./devtools/test-meson-builds.sh -vv
> > ...
> > ## Building helloworld
> [snip]
>
> Thanks for details.
> Indeed, libarchive.pc lists all libraries present at libarchive build time
> in Libs.private, despite that libarchive static linkage doesn't require them.
> We'll have to go your way, sorry for misdirection.
> Maybe it's worth a comment.
>
> From libarchive README:
>
>         I've attempted to minimize static link pollution. If you don't
>         explicitly invoke a particular feature (such as support for a
>         particular compression or format), it won't get pulled in to
>         statically-linked programs. In particular, if you don't explicitly
>         enable a particular compression or decompression support, you won't
>         need to link against the corresponding compression or decompression
>         libraries. This also reduces the size of statically-linked binaries
>         in environments where that matters.

Yes, I can explain this in v3, but I'll wait a bit to see if issues
with this series are discovered.
Thanks Dmitry.


-- 
David Marchand