From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] doc/devbind: remove references to igb_uio
Date: Thu, 26 Nov 2020 17:00:55 +0100 [thread overview]
Message-ID: <CAJFAV8zSw7qoaByTPc=THo4-KM1gmHP5sTYKdytp8W4eK_2yyQ@mail.gmail.com> (raw)
In-Reply-To: <20201126114838.GC1340@bricha3-MOBL.ger.corp.intel.com>
On Thu, Nov 26, 2020 at 12:49 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Wed, Oct 14, 2020 at 05:43:29PM +0100, Ferruh Yigit wrote:
> > On 9/24/2020 6:53 PM, Stephen Hemminger wrote:
> > > We should be encouraging the use of vfio_pci for developers, not telling
> > > them to use igb_uio.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > Module name is 'vfio_pci' but driver name is 'vfio-pci', for this document I
> > guess all instances should be 'vfio-pci'.
> >
>
> Yes, I believe all instances of vfio_pci should be replaced with the "-"ed
> version. With that change:
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Indeed, passing vfio_pci fails:
$ sudo ./usertools/dpdk-devbind.py --bind=vfio_pci 0000:01:00.0
Error: bind failed for 0000:01:00.0 - Cannot open
/sys/bus/pci/drivers/vfio_pci/bind
Error: unbind failed for 0000:01:00.0 - Cannot open /sys/bus/pci/drivers//unbind
$ ./usertools/dpdk-devbind.py --status |grep 0000:01:00.0
0000:01:00.0 '82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb'
drv=vfio-pci unused=ixgbe
Fixed and applied.
--
David Marchand
prev parent reply other threads:[~2020-11-26 16:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 3:38 [dpdk-dev] [PATCH] " Stephen Hemminger
2020-09-07 9:08 ` Bruce Richardson
2020-09-07 17:22 ` Stephen Hemminger
2020-09-24 17:53 ` [dpdk-dev] [PATCH v2] " Stephen Hemminger
2020-10-14 16:43 ` Ferruh Yigit
2020-11-26 11:48 ` Bruce Richardson
2020-11-26 16:00 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zSw7qoaByTPc=THo4-KM1gmHP5sTYKdytp8W4eK_2yyQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).