From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DE5DA0569; Wed, 11 Mar 2020 17:16:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7E571BFA5; Wed, 11 Mar 2020 17:16:09 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id B02E5FEB for ; Wed, 11 Mar 2020 17:16:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583943367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBeGh4ZG18zII2bpjYTaLQuDv736Gw2CwWE4xrM4/SY=; b=RO66bT7DBbv+WZnDkIZonwNLxRHTOpcBoQ5j82r+ZQb6ENtMHBfSuFCnYnpPQbA967VPi6 YszTZnj1Zg1MZYHqXPIaX05tBrz3GuWlv5/z4AOb0A27PMHoIEGpLjFmZReYpxtjdu4DOu h6/YtnjBTbSg5BYND+bEcMW9Z2fcIDw= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-kFXilz-gOnO3bzIbJ-TiXg-1; Wed, 11 Mar 2020 12:16:01 -0400 X-MC-Unique: kFXilz-gOnO3bzIbJ-TiXg-1 Received: by mail-vs1-f69.google.com with SMTP id i12so241265vsb.18 for ; Wed, 11 Mar 2020 09:16:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ws+pWvyqzorNhgB2J93W60j+4fOB1/z0nDIgjrm6uTs=; b=NjFDtn6yf/55t7DbL/XGLgPcB9j+IhM+CSDc56DYfq4tZRgcudoz030hIDGVUq3BlJ eUjKPP01N9EXsK2JGFJmf76JpTiKx6SLUvxoLQsWWJl7B9XQgHS+4my3Jx3u7u6b5hvY kLd9UXsdmSAkFKD1C7bM7AxhMnaf9X4DfnKnpCo55k9AxE6h9rUu2bXumq274adL0uBM npeBTp0j40ddMQmgK1wdcfBugOWW1VHxHK+BfHpxoLt8EpiTF0UCO05zbNN/Ek3W3VgF g5FrWyr0LYQ+Y8ePfrtq5dEAVRs+h/AWEi5meSbyqA6OsimYG85I7gpse92H3orrC5pZ NMyA== X-Gm-Message-State: ANhLgQ3ZinQxWixJHu0Ao1jsf2HGR7+GV3w/RiXRhNFRznB3S2RKcJQu FGnmkBLz3aAjTHMNx/SpPwgEfUiH8Ov2cFiWmILovdN5rC973+/xuwu3qP9H95RiV9Gwgrtcl8S 8eZaGJ3Q344Igq2JBQJE= X-Received: by 2002:a9f:2204:: with SMTP id 4mr2112325uad.87.1583943360695; Wed, 11 Mar 2020 09:16:00 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs3++2JJFankBZlq6Dlya29XHzDPC3zwaVg/2+jFnxxFeUz5izPV0V/AfpHXwfBAp8p/LBQu4MDsxXXIo57myc= X-Received: by 2002:a9f:2204:: with SMTP id 4mr2112295uad.87.1583943360134; Wed, 11 Mar 2020 09:16:00 -0700 (PDT) MIME-Version: 1.0 References: <20200310133304.39951-1-harry.van.haaren@intel.com> <20200311143927.76021-1-harry.van.haaren@intel.com> In-Reply-To: <20200311143927.76021-1-harry.van.haaren@intel.com> From: David Marchand Date: Wed, 11 Mar 2020 17:15:49 +0100 Message-ID: To: Harry van Haaren Cc: dev , Aaron Conole , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] eal/service: fix exit by resetting service lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 11, 2020 at 3:39 PM Harry van Haaren wrote: > > This commit releases all service cores from their role, > returning them to ROLE_RTE on rte_service_finalize(). > > This may fix an issue relating to the service cores causing You don't seem convinced. > a race-condition on eal_cleanup(), where the service core > could still be executing while the main thread has already > free-d the service memory, leading to a segfault. > > Fixes: 21698354c832 ("service: introduce service cores concept") > Cc: stable@dpdk.org > > Reported-by: David Marchand > Reported-by: Aaron Conole > Signed-off-by: David Marchand > Signed-off-by: Harry van Haaren > Acked-by: Aaron Conole I am okay with merging this so that we stop getting random failures of the = ut. I will let this patch on the ml and apply on Friday at worse. Please take the time to reply to my question. Thanks. --=20 David Marchand