From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8ABDA0A0C; Thu, 22 Jul 2021 22:15:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E98C4014D; Thu, 22 Jul 2021 22:15:39 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9B91C40040 for ; Thu, 22 Jul 2021 22:15:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626984936; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D0qjmB6iaIrwlLIJQIPtWCJpJ34LETrErrVeITeciJo=; b=er4J5Ryh/synSQhS0gz1lAfkCWqPl69ZlQoQdXCyjffa1nmlmtaz4U1gMBIrux4oYYo3k+ YCe0I9ckiehZENoZlCQqSRs/+8/sTltCbjy9wV4vKQuF2Xecf3CytJaVn371S/s0h91qnl N/F4ZGu4ekpusFY4kO72Yo+yz9g7Yz0= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-tG9oNYMeNe6ni0kV5eqAvA-1; Thu, 22 Jul 2021 16:15:34 -0400 X-MC-Unique: tG9oNYMeNe6ni0kV5eqAvA-1 Received: by mail-vs1-f72.google.com with SMTP id p22-20020a67e1d60000b02902a3840e990bso1766654vsl.19 for ; Thu, 22 Jul 2021 13:15:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D0qjmB6iaIrwlLIJQIPtWCJpJ34LETrErrVeITeciJo=; b=oJAjgfc5FHkav+Mm5tUdbB5yNB8jq6bv1blyTcjY+ZWzWpnlQTtgb7LnvtRW7SQauB u7XYxwUZPyufSonqtPZvNNdKo3Ywazq8wMH6ujVQZveTmJXEZbDZewz8Ls4pF0PNaARC UwLZZvbI32iRT+ih1mS0Mju7K0i+RxyVdwGr4oQJUxhmuIlri9wUA0cuM/DjAWAu13zy MQ7zuP1yOT8wrgLPWG36gznoj/At4gjUeJrMT96cYITd3rY/6noYuBxSkTF9iHIetmJ/ l+q/IGnT3o0pLX5fZs2OVSLP3Xeg2H05g3Litntu+yO79QmFfTbPiYouTaV7SeD30TdZ UPbA== X-Gm-Message-State: AOAM533nIXDomelVCfR3XFohPN9IzD9JS+sDFkF6BQ1Mn0Mqa7U08gXA GeP1cKGgelXBfX/ZoCFeyQC7g4S/+xe26vwvO6IxV03NToW/PlOj4vx4WH5EnKQtPtT+HtfJlHk w9PXSiW7gSfUVrNN28Ts= X-Received: by 2002:a67:f90c:: with SMTP id t12mr2435258vsq.27.1626984934290; Thu, 22 Jul 2021 13:15:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYG0nXzgl2qNDxRV+JV5/PqxoE+l8ISSRD2ceTTDAP86KIW6DlkKKKTKaTi3OHqhrsV5zqJVb7R02KlIUiXSU= X-Received: by 2002:a67:f90c:: with SMTP id t12mr2435243vsq.27.1626984934043; Thu, 22 Jul 2021 13:15:34 -0700 (PDT) MIME-Version: 1.0 References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20210722095433.1898589-1-andrew.rybchenko@oktetlabs.ru> <20210722095433.1898589-12-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210722095433.1898589-12-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Thu, 22 Jul 2021 22:15:22 +0200 Message-ID: To: Andrew Rybchenko Cc: dev , Xiaoyun Li , Ivan Ilchenko Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 11/11] app/testpmd: add option to display extended statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 22, 2021 at 11:55 AM Andrew Rybchenko wrote: > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 8468018cf3..baffef1642 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -3609,6 +3609,62 @@ cmdline_parse_inst_t cmd_stop = { > > /* *** SET CORELIST and PORTLIST CONFIGURATION *** */ > > +int > +parse_xstats_list(char *in_str, struct rte_eth_xstat_name **xstats, > + unsigned int *xstats_num) I had saved this comment as it seemed harmless, but in_str can be constified. And well, mingw build seems picky about it: [5/20] Compiling C object app/dpdk-testpmd.exe.p/test-pmd_parameters.c.obj FAILED: app/dpdk-testpmd.exe.p/test-pmd_parameters.c.obj x86_64-w64-mingw32-gcc -Iapp/dpdk-testpmd.exe.p -Iapp -I../../dpdk/app -Ilib/ethdev -I../../dpdk/lib/ethdev -I. -I../../dpdk -Iconfig -I../../dpdk/config -Ilib/eal/include -I../../dpdk/lib/eal/include -Ilib/eal/windows/include -I../../dpdk/lib/eal/windows/include -Ilib/eal/x86/include -I../../dpdk/lib/eal/x86/include -Ilib/eal/common -I../../dpdk/lib/eal/common -Ilib/eal -I../../dpdk/lib/eal -Ilib/kvargs -I../../dpdk/lib/kvargs -Ilib/net -I../../dpdk/lib/net -Ilib/mbuf -I../../dpdk/lib/mbuf -Ilib/mempool -I../../dpdk/lib/mempool -Ilib/ring -I../../dpdk/lib/ring -Ilib/meter -I../../dpdk/lib/meter -Ilib/metrics -I../../dpdk/lib/metrics -Ilib/telemetry -I../../dpdk/lib/telemetry -Ilib/gro -I../../dpdk/lib/gro -Ilib/gso -I../../dpdk/lib/gso -Ilib/cmdline -I../../dpdk/lib/cmdline -Idrivers/bus/pci -I../../dpdk/drivers/bus/pci -I../../dpdk/drivers/bus/pci/windows -Ilib/pci -I../../dpdk/lib/pci -Ilib/bitratestats -I../../dpdk/lib/bitratestats -Ilib/pdump -I../../dpdk/lib/pdump -Ilib/latencystats -I../../dpdk/lib/latencystats -Idrivers/net/i40e -I../../dpdk/drivers/net/i40e -Idrivers/net/i40e/base -I../../dpdk/drivers/net/i40e/base -Idrivers/bus/vdev -I../../dpdk/drivers/bus/vdev -Ilib/hash -I../../dpdk/lib/hash -Ilib/rcu -I../../dpdk/lib/rcu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -D_WIN32_WINNT=0x0A00 -D__USE_MINGW_ANSI_STDIO -mno-avx512f -march=native -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ app/dpdk-testpmd.exe.p/test-pmd_parameters.c.obj -MF app/dpdk-testpmd.exe.p/test-pmd_parameters.c.obj.d -o app/dpdk-testpmd.exe.p/test-pmd_parameters.c.obj -c ../../dpdk/app/test-pmd/parameters.c In file included from ../../dpdk/app/test-pmd/parameters.c:6: ../../dpdk/app/test-pmd/parameters.c: In function 'launch_args_parse': ../../dpdk/lib/eal/windows/include/getopt.h:38:16: error: passing argument 1 of 'parse_xstats_list' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] 38 | #define optarg usual_optarg | ^~~~~~~~~~~~ ../../dpdk/app/test-pmd/parameters.c:699:28: note: in expansion of macro 'optarg' 699 | rc = parse_xstats_list(optarg, &xstats_display, | ^~~~~~ In file included from ../../dpdk/app/test-pmd/parameters.c:46: ../../dpdk/app/test-pmd/testpmd.h:787:29: note: expected 'char *' but argument is of type 'const char *' 787 | int parse_xstats_list(char *in_str, struct rte_eth_xstat_name **xstats, | ~~~~~~^~~~~~ cc1: all warnings being treated as errors [19/20] Compiling C object app/dpdk-testpmd.exe.p/test-pmd_cmdline.c.obj -- David Marchand