From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f51.google.com (mail-vs1-f51.google.com [209.85.217.51]) by dpdk.org (Postfix) with ESMTP id A4A2E1B63D for ; Tue, 18 Dec 2018 13:27:41 +0100 (CET) Received: by mail-vs1-f51.google.com with SMTP id n10so9820720vso.13 for ; Tue, 18 Dec 2018 04:27:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gLgO08ggWjDHUg3UyNvE0fVgZSdYfh7/XlA+SflltVg=; b=AT8ImLsbcI5yHBBEMhpsHmp/S7LnKW1VCGKtfq6bVVUJnc2mhwH5o1Isae0Z9PKPng NXXxUuABxH99rCocNkwkREyWGfYk1QuLXyP/KpQeHQYihjdXly1N3rqx5BI430DkpQuc XMXgjKHanib7GbHtkGzfy2Kc/xnmDS+XSr+wZaL4iEFApLi6KS+nak4DNpXihGmXBt/L 2HglMS+qZdN7L73D6hgNgI0F5304mHfe5fVRyYl8Nvb0Q5mKkvWIfBkz0SlswYtppKPq MwqFwOz+qOaFk0UkADUgafQBjdPpuiMbmZNLwC0WtlFx7RoRIXfGsFspObxHd3J6nuY7 6J8A== X-Gm-Message-State: AA+aEWa2FFIJHvCnisuuH3cn+5IxljAri6xXqvKzbA24bFs2zscgdm6a ZyNuYA/WNJ9QmQX1rzBOny+5dKaS26J1ju7zBZNgDw== X-Google-Smtp-Source: AFSGD/UUaVCqD9my4jUeqggMpJSm3W81Kjx3zg3+qThYb/Nm7ILPDSlBFbED7I5j1j20cQHhCz9lu+G1pj+O6CXQtE8= X-Received: by 2002:a67:c48a:: with SMTP id d10mr1734670vsk.105.1545136061114; Tue, 18 Dec 2018 04:27:41 -0800 (PST) MIME-Version: 1.0 References: <20181203164724.GA12316@hmswarspite.think-freely.org> <20181204151457.GA31778@hmswarspite.think-freely.org> <20181205122124.GA6752@hmswarspite.think-freely.org> <20181218122500.GB2078@hmswarspite.think-freely.org> In-Reply-To: <20181218122500.GB2078@hmswarspite.think-freely.org> From: David Marchand Date: Tue, 18 Dec 2018 13:27:29 +0100 Message-ID: To: Neil Horman Cc: thomas@monjalon.net, "Yigit, Ferruh" , dev@dpdk.org, Timothy Redaelli , adrien.mazarguil@6wind.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Marking symbols as experimental in the headers only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 12:27:42 -0000 On Tue, Dec 18, 2018 at 1:25 PM Neil Horman wrote: > On Tue, Dec 18, 2018 at 11:41:34AM +0100, David Marchand wrote: > > > The real issue in the end is that the __rte_experimental in headers is > the > > most important thing and can be missed during reviews. > > But I found no easy way to detect this. > > > > Do you have any idea ? > > > The most direct way is to add a regular expression search to the script > that > checks the object files. That would be some tricky grep/awk magic, but it > should be possible > This is what I feared :-). Ok, I will have a try. -- David Marchand