From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id 500A5343C for ; Mon, 1 Apr 2019 08:46:53 +0200 (CEST) Received: by mail-ua1-f68.google.com with SMTP id e15so2692463uam.3 for ; Sun, 31 Mar 2019 23:46:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0gg97cZ+pwVDiJdoc8F6VKbvHRyPypLiJ3XH0btTKSY=; b=M7Vt0N2UtZ/jZVE4PEJJHTvVdWcxfljHwoKosPvQs0CnYpXrYGmt8Yz3gOKPqxe40z UjexhJ9hpoia9GsA1ziYddxd4OX9S/TI0mf9kpfGdcSDmKfqnjmYUUB+iYNsTglWgPFE geMSiJ5+DIb+mUKgGrsHEAa2WIJxqXEz458GFa1RDXmkdw9gqdI41z5ZE/+JfJJZtGte W9UZp2wef6uy0UFoSxUowSaxEyYXf5KIob2ghFJRvsH4AhawqiLcy2tsz65cQS+OzBIj wnZQRdUP3v6A10fqm0P/aRF9QdwxsKmSC/8V9CAfOG9rpuVsJLQqI0u+W8UEku0QM/QQ SFFQ== X-Gm-Message-State: APjAAAV+f9iG3CV+3kVY0QCud5EQHFas0QDrw0ze0aGeGcOQ2faC6pVs 52e/0IRGWk68u4frubuW9OgLl5Sjij18VVINebBmng== X-Google-Smtp-Source: APXvYqwgYaj/G8vbs5X0WV0BhFuSGfhnUStIBqUUN0jymgUOIdBdizvjrSNYfXrbrHzoqIqmiDMhk2KLIwrcb/8UU5k= X-Received: by 2002:ab0:6419:: with SMTP id x25mr30988619uao.86.1554101212666; Sun, 31 Mar 2019 23:46:52 -0700 (PDT) MIME-Version: 1.0 References: <20181130002716.27325-1-thomas@monjalon.net> <59747746.vl7xl9E5pD@xps> <50312a9a-884b-cc7d-24cd-c01a34cc22e7@intel.com> <4063619.5t9VujUhGY@xps> In-Reply-To: <4063619.5t9VujUhGY@xps> From: David Marchand Date: Mon, 1 Apr 2019 08:46:41 +0200 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , dev , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 06:46:53 -0000 On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: > 19/03/2019 19:04, Ferruh Yigit: > > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > > >>> +uint16_t __rte_experimental > > >> > > >> Do we need _rte_experimental on function definitions? I guess only in > .h file, > > >> function declaration is enough. > > > > > > Yes we need them both in .h and .c files. > > > > Why we need them in .c file? > > I think the compiler is interested in ones in .h file, because of the > > experimental checks. > > We need the tag in .c file because a check is done in the ELF object > by buildtools/check-experimental-syms.sh > ? The attribute should be inherited from the declaration in the header. If you have a case where it does not work, I'd like to look at it. > David tried a replacement of this script to run on header files, > but it looks a bit slow: > https://patches.dpdk.org/patch/49118/ Never got any review/comment, will do a quick update in this thread. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9A28AA068F for ; Mon, 1 Apr 2019 08:46:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C9A034F3; Mon, 1 Apr 2019 08:46:54 +0200 (CEST) Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id 500A5343C for ; Mon, 1 Apr 2019 08:46:53 +0200 (CEST) Received: by mail-ua1-f68.google.com with SMTP id e15so2692463uam.3 for ; Sun, 31 Mar 2019 23:46:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0gg97cZ+pwVDiJdoc8F6VKbvHRyPypLiJ3XH0btTKSY=; b=M7Vt0N2UtZ/jZVE4PEJJHTvVdWcxfljHwoKosPvQs0CnYpXrYGmt8Yz3gOKPqxe40z UjexhJ9hpoia9GsA1ziYddxd4OX9S/TI0mf9kpfGdcSDmKfqnjmYUUB+iYNsTglWgPFE geMSiJ5+DIb+mUKgGrsHEAa2WIJxqXEz458GFa1RDXmkdw9gqdI41z5ZE/+JfJJZtGte W9UZp2wef6uy0UFoSxUowSaxEyYXf5KIob2ghFJRvsH4AhawqiLcy2tsz65cQS+OzBIj wnZQRdUP3v6A10fqm0P/aRF9QdwxsKmSC/8V9CAfOG9rpuVsJLQqI0u+W8UEku0QM/QQ SFFQ== X-Gm-Message-State: APjAAAV+f9iG3CV+3kVY0QCud5EQHFas0QDrw0ze0aGeGcOQ2faC6pVs 52e/0IRGWk68u4frubuW9OgLl5Sjij18VVINebBmng== X-Google-Smtp-Source: APXvYqwgYaj/G8vbs5X0WV0BhFuSGfhnUStIBqUUN0jymgUOIdBdizvjrSNYfXrbrHzoqIqmiDMhk2KLIwrcb/8UU5k= X-Received: by 2002:ab0:6419:: with SMTP id x25mr30988619uao.86.1554101212666; Sun, 31 Mar 2019 23:46:52 -0700 (PDT) MIME-Version: 1.0 References: <20181130002716.27325-1-thomas@monjalon.net> <59747746.vl7xl9E5pD@xps> <50312a9a-884b-cc7d-24cd-c01a34cc22e7@intel.com> <4063619.5t9VujUhGY@xps> In-Reply-To: <4063619.5t9VujUhGY@xps> From: David Marchand Date: Mon, 1 Apr 2019 08:46:41 +0200 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , dev , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/4] ethdev: add siblings iterators X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190401064641.36JGr5unfWcCTegrvjYtLvOhzpUGVK9A4DgmtfVEfhU@z> On Mon, Apr 1, 2019 at 4:16 AM Thomas Monjalon wrote: > 19/03/2019 19:04, Ferruh Yigit: > > On 3/19/2019 5:34 PM, Thomas Monjalon wrote: > > >>> +uint16_t __rte_experimental > > >> > > >> Do we need _rte_experimental on function definitions? I guess only in > .h file, > > >> function declaration is enough. > > > > > > Yes we need them both in .h and .c files. > > > > Why we need them in .c file? > > I think the compiler is interested in ones in .h file, because of the > > experimental checks. > > We need the tag in .c file because a check is done in the ELF object > by buildtools/check-experimental-syms.sh > ? The attribute should be inherited from the declaration in the header. If you have a case where it does not work, I'd like to look at it. > David tried a replacement of this script to run on header files, > but it looks a bit slow: > https://patches.dpdk.org/patch/49118/ Never got any review/comment, will do a quick update in this thread. -- David Marchand