DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: reduce build test verbosity
Date: Thu, 12 Nov 2020 14:04:52 +0100
Message-ID: <CAJFAV8zUGRqEJvbstk33eMc45xBUG9taK2ttNq4Wnyd8H6uN=w@mail.gmail.com> (raw)
In-Reply-To: <20201106172854.237384-1-thomas@monjalon.net>

On Fri, Nov 6, 2020 at 6:29 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The default verbosity of test-meson-builds.sh is to be quiet.
> In order to better apply the verbosity policy, some file descriptors
> are open to redirect to stdout or /dev/null accordingly.
>
> The target variable and meson/ninja commands are printed in verbose modes.
> The installation commands are printed only in very verbose mode.
> The examples build commands are printed only in very verbose mode.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/test-meson-builds.sh | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index 0c95d1cc98..469251b6ef 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -65,7 +65,7 @@ load_env () # <target compiler>
>         else # toolchain not yet in PATH: its name should be enough
>                 DPDK_TARGET=$targetcc
>         fi
> -       echo "Using DPDK_TARGET $DPDK_TARGET"
> +       echo "Using DPDK_TARGET $DPDK_TARGET" >&$verbose
>         # config input: $DPDK_TARGET
>         . $srcdir/devtools/load-devel-config
>         # config output: $DPDK_MESON_OPTIONS, $PATH, $PKG_CONFIG_PATH, etc
> @@ -99,7 +99,7 @@ config () # <dir> <builddir> <meson options>
>                 options="$options -D$option"
>         done
>         options="$options $*"
> -       echo "$MESON $options $dir $builddir"
> +       echo "$MESON $options $dir $builddir" >&$verbose
>         $MESON $options $dir $builddir
>  }
>
> @@ -115,7 +115,6 @@ compile () # <builddir>
>                 echo "$ninja_cmd -C $builddir | cat"
>                 $ninja_cmd -C $builddir | cat
>         else
> -               echo "$ninja_cmd -C $builddir"
>                 $ninja_cmd -C $builddir
>         fi
>  }
> @@ -123,13 +122,8 @@ compile () # <builddir>
>  install_target () # <builddir> <installdir>
>  {
>         rm -rf $2
> -       if [ -n "$TEST_MESON_BUILD_VERY_VERBOSE$TEST_MESON_BUILD_VERBOSE" ]; then
> -               echo "DESTDIR=$2 $ninja_cmd -C $1 install"
> -               DESTDIR=$2 $ninja_cmd -C $1 install
> -       else
> -               echo "DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null"
> -               DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null
> -       fi
> +       echo "DESTDIR=$2 $ninja_cmd -C $1 install" >&$verbose
> +       DESTDIR=$2 $ninja_cmd -C $1 install >&$veryverbose
>  }
>
>  build () # <directory> <target compiler | cross file> <meson options>
> @@ -186,6 +180,7 @@ build () # <directory> <target compiler | cross file> <meson options>
>
>  if [ "$1" = "-vv" ] ; then
>         TEST_MESON_BUILD_VERY_VERBOSE=1
> +       TEST_MESON_BUILD_VERBOSE=1
>  elif [ "$1" = "-v" ] ; then
>         TEST_MESON_BUILD_VERBOSE=1
>  fi
> @@ -194,6 +189,10 @@ if [ -z "$PIPEFAIL" -a -n "$TEST_MESON_BUILD_VERBOSE" ] ; then
>         echo "# Missing pipefail shell option, changing VERBOSE to VERY_VERBOSE"
>         TEST_MESON_BUILD_VERY_VERBOSE=1
>  fi
> +[ -n "$TEST_MESON_BUILD_VERBOSE" ] && exec 8>&1 || exec 8>/dev/null
> +verbose=8
> +[ -n "$TEST_MESON_BUILD_VERY_VERBOSE" ] && exec 9>&1 || exec 9>/dev/null
> +veryverbose=9
>
>  # shared and static linked builds with gcc and clang
>  for c in gcc clang ; do
> @@ -270,6 +269,7 @@ if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then
>         export PKGCONF="pkg-config --define-prefix"
>         for example in cmdline helloworld l2fwd l3fwd skeleton timer; do
>                 echo "## Building $example"
> -               $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example clean shared static
> +               $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example \
> +                       clean shared static >&$veryverbose
>         done
>  fi
> --
> 2.28.0
>

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand


  reply	other threads:[~2020-11-12 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 17:28 Thomas Monjalon
2020-11-12 13:04 ` David Marchand [this message]
2020-11-12 13:08 ` Bruce Richardson
2020-11-12 14:31   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zUGRqEJvbstk33eMc45xBUG9taK2ttNq4Wnyd8H6uN=w@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git