From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 871A9455DF; Tue, 9 Jul 2024 10:26:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70A4D427B9; Tue, 9 Jul 2024 10:26:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B2B7440E0F for ; Tue, 9 Jul 2024 10:26:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720513601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FeBVj8wgzuv1TtDRRxPUDT/9iRx+iyuH9CYazfG9aZ8=; b=BTy1lKeuwVWiMQ+ov4SSX6oZlu6QVetbBd+HlffBR3R2zdWOXvMCVAHaulvVvvVOJbHeEN 6GBsf6DNPQHZvyIQaidjZpvtctpBjIsE2x2lzNUb+s0DwIj4jw/rfAbGp9zjLI5j5J89SF zoSLP6rDztmdOrtAwINpjmX+RAKDUIc= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-4fNu9mvNNkeyMRtrYN13_A-1; Tue, 09 Jul 2024 04:26:39 -0400 X-MC-Unique: 4fNu9mvNNkeyMRtrYN13_A-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ee864483c2so45024521fa.2 for ; Tue, 09 Jul 2024 01:26:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720513598; x=1721118398; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FeBVj8wgzuv1TtDRRxPUDT/9iRx+iyuH9CYazfG9aZ8=; b=ma8eMENqZIYe6uWgGolsoAUmBubUnJpUzga5g3+yQ4F+BfOB3TBqzNagiBFYWvn5o0 MgORbJqUD7Fy/RdmOhDXhzippjgAEW7YejcPyUl0ltYRbW5Kkt4W9xN+SPuV6kTfTnv+ xH2NU0thpqAyiKqsWMto3NYztKG0mhXxuxiny3YCht7awuv3etaRuxbzN1/E5IM6Krxm EP0R0rn0SVDBEpfwMJDTbXCtc2cQSIOQFfp8BLJOp8xQLSO/2jvmAueJmGBmrbJg/J/D zDzBe9BnnHLYLjRSJ59802UBXXc9z2V1NTkLiUJovAC8SqTTFJ8aBawcLlZwtYFQ7l2l GAjQ== X-Gm-Message-State: AOJu0YzN0Q8ZvMRC2YGYgufxr4iAd/V3rZYk30s5XkDRxTpJlqWDo9VY Iw4fU2ItcgYY4RypQ97I2JI+WTRMwdayuzneAYvFCRn8gK79v8SQFW974sqXss95WrKorC31YPk xT9/FL4Au1cjZa1qj3QXTGFJTC1iKGJlETFRPTcBOMIy4f5UPJ0znV73xA19LfnVA5tgJS+xuUr k8xokw0lkTPdJ7er0= X-Received: by 2002:a2e:a585:0:b0:2ee:4f93:ae25 with SMTP id 38308e7fff4ca-2eeb30fcfb8mr14766911fa.29.1720513597749; Tue, 09 Jul 2024 01:26:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHg5nSEk/HD4PYO4KAQxOFxIUGSRQ5b6a8IaECxTKkchNULv8H23NKTmWO+NT2lL6dSbD65PMeRaqX+q3tt+aY= X-Received: by 2002:a2e:a585:0:b0:2ee:4f93:ae25 with SMTP id 38308e7fff4ca-2eeb30fcfb8mr14766491fa.29.1720513597316; Tue, 09 Jul 2024 01:26:37 -0700 (PDT) MIME-Version: 1.0 References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1715019531-22796-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1715019531-22796-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 9 Jul 2024 10:26:25 +0200 Message-ID: Subject: Re: [PATCH v3 00/19] remove use of VLAs for Windows To: Tyler Retzlaff , Ferruh Yigit , Konstantin Ananyev Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Akhil Goyal , Aman Singh , Anatoly Burakov , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Dariusz Sosnowski , Dmitry Kozlyuk , Fan Zhang , Harman Kalra , Harry van Haaren , Honnappa Nagarahalli , Jiayu Hu , Jingjing Wu , Kevin Laatz , Matan Azrad , Ori Kam , Pallavi Kadam , Reshma Pattan , Sameh Gobriel , Suanming Mou , Thomas Monjalon , Viacheslav Ovsiienko , Vladimir Medvedkin , Volodymyr Fialko , Yipeng Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello guys, On Mon, May 6, 2024 at 8:19=E2=80=AFPM Tyler Retzlaff wrote: > > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please provide the details for incorporation > into the series. > > MSVC does not support VLAs, replace VLAs with standard C arrays > or alloca(). alloca() is available for all toolchain/platform > combinations officially supported by DPDK. > > v3: > * address checkpatch/check git log warnings (minor typos) > > v2: > * replace patches for ethdev, hash, rcu and include new > patches for eal from Konstantin Ananyev > from https://patchwork.dpdk.org/project/dpdk/list/?series=3D31781 > > Konstantin Ananyev (6): > eal/linux: remove use of VLAs > eal/common: remove use of VLAs > ethdev: remove use of VLAs for Windows built code > hash: remove use of VLAs for Windows built code > hash/thash: remove use of VLAs for Windows built code > rcu: remove use of VLAs for Windows built code > > Tyler Retzlaff (13): > eal: include header required for alloca > gro: remove use of VLAs for Windows built code > latencystats: remove use of VLAs for Windows built code > lpm: remove use of VLAs for Windows built code > app/testpmd: remove use of VLAs for Windows built code > test: remove use of VLAs for Windows built code > common/idpf: remove use of VLAs for Windows built code > net/i40e: remove use of VLAs for Windows built code > net/ice: remove use of VLAs for Windows built code > net/ixgbe: remove use of VLAs for Windows built code > common/mlx5: remove use of VLAs for Windows built code > net/mlx5: remove use of VLAs for Windows built code > build: enable vla warnings on Windows built code > > app/test-pmd/cmdline.c | 2 +- > app/test-pmd/cmdline_flow.c | 9 +- > app/test-pmd/config.c | 16 ++- > app/test-pmd/shared_rxq_fwd.c | 2 +- > app/test/test.c | 2 +- > app/test/test_cmdline_string.c | 2 +- > app/test/test_cryptodev.c | 32 ++--- > app/test/test_cryptodev_blockcipher.c | 4 +- > app/test/test_cryptodev_crosscheck.c | 2 +- > app/test/test_dmadev.c | 9 +- > app/test/test_hash.c | 8 +- > app/test/test_mempool.c | 25 ++-- > app/test/test_reassembly_perf.c | 4 +- > app/test/test_reorder.c | 48 +++---- > app/test/test_service_cores.c | 9 +- > app/test/test_thash.c | 7 +- > config/meson.build | 4 + > drivers/common/idpf/idpf_common_rxtx.c | 2 +- > drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 +- > drivers/common/mlx5/mlx5_common.h | 4 +- > drivers/common/mlx5/mlx5_devx_cmds.c | 7 +- > drivers/net/i40e/i40e_testpmd.c | 5 +- > drivers/net/ice/ice_rxtx.c | 2 +- > drivers/net/ixgbe/ixgbe_ethdev.c | 5 +- > drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 2 +- > drivers/net/mlx5/mlx5.c | 5 +- > drivers/net/mlx5/mlx5_flow.c | 6 +- > lib/eal/common/eal_common_proc.c | 5 +- > lib/eal/linux/eal_interrupts.c | 59 ++++++++- > lib/eal/linux/include/rte_os.h | 1 + > lib/eal/windows/include/rte_os.h | 1 + > lib/ethdev/rte_ethdev.c | 183 ++++++++++++++++----= ------ > lib/gro/rte_gro.c | 4 +- > lib/hash/rte_cuckoo_hash.c | 4 +- > lib/hash/rte_thash.c | 2 +- > lib/hash/rte_thash.h | 8 ++ > lib/latencystats/rte_latencystats.c | 2 +- > lib/lpm/rte_lpm.h | 2 +- > lib/rcu/rte_rcu_qsbr.c | 7 +- > lib/rcu/rte_rcu_qsbr.h | 5 + > 40 files changed, 314 insertions(+), 198 deletions(-) I see discussions on patches for some net drivers and the gro library. Can you please sync and summarize which patches goes though next-net, though main etc..? In any case, I think this cleanup can wait 24.11. For now, I merged Stephen alternatives for lpm and latencystats as the patches looked clean and were acked. Thanks. --=20 David Marchand