From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35B9DA00C2; Tue, 8 Mar 2022 16:07:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C13384068B; Tue, 8 Mar 2022 16:07:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3358040141 for ; Tue, 8 Mar 2022 16:07:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646752033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kM6zEvPXhsTE2b/KiPEeKVsElzX1lvas3HLC4h1P3C0=; b=al/+AprJkLSnKT2T7tygO5kYjM9/93hszvxLg9xL2X0S8y1NlRMInhK3Lh24SecKFb9n3G +8wUbgbJPO7yC3BqjPkH73ru2wz0GRe72ROWGgvGuNFrJnklM5lLMOzI6ezu7WAV/SyvtB uuA6DSVwS7d+47QXb+MA5uSb8xQHcMw= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-223-0taokVb2MAagliCiiVda1A-1; Tue, 08 Mar 2022 10:07:09 -0500 X-MC-Unique: 0taokVb2MAagliCiiVda1A-1 Received: by mail-lj1-f200.google.com with SMTP id r16-20020a2e5750000000b00247cf98271dso4995628ljd.6 for ; Tue, 08 Mar 2022 07:07:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=kM6zEvPXhsTE2b/KiPEeKVsElzX1lvas3HLC4h1P3C0=; b=ElrKs0zG6JU1U8mJxz5DD9Vq+os4jo53Fd0LFaoVp/zsOcmptrPyo/04Ifch/B3/dp uFTB85GeBML4qbh5CN+fA6GBLws4poiyDy9+Co5ON24L5iDjRa28tJBMNH260bko/ITD uumH0Y/YsSTv3VaMOJsNc444Au/AQTTA8C4UVsjs40bdFQ2fTp6fPLUH6DBirCx8ippv /ca87f88WKUdBfKA0sKSUYdQBkZ4UvAmXWu8WNeRGNulJB187Zm4j1uVyuU/tSXpZ5h1 PqQdedVIWnjVKKzEPUZxMXgUsGOO1eSNHxTjIb0l1l/OFx+3xbMDANnyOurs0x2s1l2J pxlA== X-Gm-Message-State: AOAM530Tf280MQsTbgbingfGQ5jWpyN0VUA96IchDdy1a80yb4r2E6WL dT2+/XLT82CeOUltH5FuHb0D99VJdaqw2aw0UAkZLWANz7qygSxla6iw2KTSDwZmLI4+8FuQa5t uMy7AhCS8pmciiPZylko= X-Received: by 2002:a05:6512:39ce:b0:448:36de:d2ea with SMTP id k14-20020a05651239ce00b0044836ded2eamr4568497lfu.499.1646752028272; Tue, 08 Mar 2022 07:07:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJwgtVSkZYtueY2mOEJ/8ESpz7A9JUHZtalopna/OTQTwrqp+0GY7BWqHxxBqwi7zD2aVZ5Ur/Wt1N7RMxd5yF4= X-Received: by 2002:a05:6512:39ce:b0:448:36de:d2ea with SMTP id k14-20020a05651239ce00b0044836ded2eamr4568489lfu.499.1646752028062; Tue, 08 Mar 2022 07:07:08 -0800 (PST) MIME-Version: 1.0 References: <20220307181101.10394-1-david.marchand@redhat.com> <20220308094422.25685-1-david.marchand@redhat.com> In-Reply-To: <20220308094422.25685-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 8 Mar 2022 16:06:56 +0100 Message-ID: Subject: Re: [PATCH v2] vhost: fix external message handlers To: dev , Fan Zhang , Maxime Coquelin , Chenbo Xia , Christophe Fontaine Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 8, 2022 at 10:45 AM David Marchand wrote: > > Following a rework, external message handlers were receiving a pointer > to a vhost_user message (as stated in the API), but lost the ability to > interact with fds attached to the message. > Restore the original layout and put a build check and reminders. > > Bugzilla ID: 953 > Fixes: 5e0099dc709e ("vhost: remove payload size limitation") > > Reported-by: Fan Zhang > Signed-off-by: David Marchand Reviewed-by: Maxime Coquelin Tested-by: Jakub Poczatek Acked-by: Jakub Poczatek Reviewed-by: Christophe Fontaine Applied, thanks. -- David Marchand