From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7930F432BA; Mon, 6 Nov 2023 17:03:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62DA3402B1; Mon, 6 Nov 2023 17:03:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9F53C4025D for ; Mon, 6 Nov 2023 17:03:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699286620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NsHZjD+bhA5RbnzM1xghkBgeyHRmxtvuRZ7LOJt/HnY=; b=RwORnsgmOZIIvOsPenK4B0HSJGQF/JdvPCf+AgNjPUxlJbL1w84dwvl21K7dYS+8kEJO4C SQ0DbfAlxqD1cGzEMx9zMTizf+s+MIEM9hs0fK0rXGV63sVfAGXZ8JOkjWdVgf03zjL1zl rUVR4qhMubIGjp4JQsfV+E9y7f97l/0= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-646-0Rk8x9ZzPU-xE6O84YShTw-1; Mon, 06 Nov 2023 11:03:26 -0500 X-MC-Unique: 0Rk8x9ZzPU-xE6O84YShTw-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c53c85e482so48459191fa.1 for ; Mon, 06 Nov 2023 08:03:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699286602; x=1699891402; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NsHZjD+bhA5RbnzM1xghkBgeyHRmxtvuRZ7LOJt/HnY=; b=fiAVRez01n9iToZzjo6yGqW9J7vYI7dNFu4cQHwEc2zDCBqTPgy1zAJx81i+nLElPV 9XkDEKaQitradZpxk6iTDZU04NpaOJXiO0hTMkFeNjXPmAyqISzqjEu5jgv9Pq+1dvL3 imMOMXF0a1mmRmwQZFOiyN4kEAyNkhxagyJgqp6nvCdFnm6s+ASzzC5pGp/FwC9KrJBc vplqJ1Gwax45QdRTq41iTep3NXlIVoE6d0tssXYNiSJpF7jRk4l1Ivali1n7qx1GlIzu 8r3nxIe+PNJTDfztBqaEQLeObFKXIwvJ9XGG+nJrfdee/UcRj5aF5iFbFNW88WCaufOX qHfg== X-Gm-Message-State: AOJu0YyfUEQgZYgF8I5nTmcy2kWtQ9C2USv7qYHVDon9WVGczSoWhmZ5 g63fbd32gf6oaM2ZUhRawBHBLTbux1vVstJUOXFiUsnskUvNiJ+L5kTBZRkixxcPNR9gvQP+6Ro fqGj+xFoOVCJbPlZ3Rc8= X-Received: by 2002:a05:651c:1a0e:b0:2c0:d21:39de with SMTP id by14-20020a05651c1a0e00b002c00d2139demr30902188ljb.42.1699286602118; Mon, 06 Nov 2023 08:03:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWrSs1Yjkc0gwWtLiM4WR+u3HNRPQvJ59b4lvN+A86vXEdSHwkx9O2H+Aj6siWUQIbNyFu4NwboUHM++jV/g8= X-Received: by 2002:a05:651c:1a0e:b0:2c0:d21:39de with SMTP id by14-20020a05651c1a0e00b002c00d2139demr30902146ljb.42.1699286601806; Mon, 06 Nov 2023 08:03:21 -0800 (PST) MIME-Version: 1.0 References: <20231020170135.18319-1-syalavarthi@marvell.com> <20231106041243.13621-1-syalavarthi@marvell.com> In-Reply-To: <20231106041243.13621-1-syalavarthi@marvell.com> From: David Marchand Date: Mon, 6 Nov 2023 17:03:10 +0100 Message-ID: Subject: Re: [PATCH v5 1/1] build: add libarchive to external deps To: Srikanth Yalavarthi , Bruce Richardson Cc: Aaron Conole , Igor Russkikh , dev@dpdk.org, sshankarnara@marvell.com, aprabhu@marvell.com, ptakkar@marvell.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 6, 2023 at 5:12=E2=80=AFAM Srikanth Yalavarthi wrote: > > In order to avoid linking with Libs.private, libarchive > is not added to ext_deps during the meson setup stage. > > Since libarchive is not added to ext_deps, cross-compilation > or native compilation with libarchive installed in non-standard > location fails with errors related to "cannot find -larchive" > or "archive.h: No such file or directory". In order to fix the > build failures, user is required to define the 'c_args' and > 'c_link_args' with '-I' and '-L'. > > This patch adds libarchive to ext_deps and further would not > require setting c_args and c_link_args externally. > > Fixes: 40edb9c0d36b ("eal: handle compressed firmware") > Cc: stable@dpdk.org > > Signed-off-by: Srikanth Yalavarthi This breaks static compilation of applications. This can be reproduced with test-meson-builds.sh and in GHA (which was not linking examples statically, I added a patch in my github repo): https://github.com/david-marchand/dpdk/actions/runs/6772879600/job/18406442= 129#step:19:19572 --=20 David Marchand