From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A94DA00C2; Wed, 17 Mar 2021 10:48:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 690FB140EEB; Wed, 17 Mar 2021 10:48:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 50A7E140EE3 for ; Wed, 17 Mar 2021 10:48:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615974523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rxx5LlubbyNIjH8CN2mBbrGIFbEPd9P7XM32WynOuyY=; b=SgKe035TWp4UYQm5uX5OepITHEUQ3iTapxM+3FbqAzeFFUep4ouBrEqAx0NizDKOJk8dBh iS5cvgLHBuD/5FH0PGNKuKcPiFWHFRb0P98wpgQY3/vncKqhH7nUwT1t5AUM1mvVYH4QXH 5MhL90MxcTtQqx7VnoLlXaE2Z5Ch8WM= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-13-s9FqcIo1P5CLWg6m-HV_Gw-1; Wed, 17 Mar 2021 05:48:41 -0400 X-MC-Unique: s9FqcIo1P5CLWg6m-HV_Gw-1 Received: by mail-vs1-f70.google.com with SMTP id s17so4411896vsk.15 for ; Wed, 17 Mar 2021 02:48:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rxx5LlubbyNIjH8CN2mBbrGIFbEPd9P7XM32WynOuyY=; b=bL9sDnWtIQLiuDifnKyUn3oFwy2eztF4SPZu9CyCsJ8VH2bSTcFJdAsTHjKI6qrp+g REj7a9v1mmc0omeyN1SJH//TdBtz8O3TgoLMkV1TaRWgeKSVlMDAcEIpNbtuiRvLB+0/ ylgIzfaxLgWrKtC8szlspLVy7XEYJBIYRu6su2aQia34rf/C3icSA670qPA2mYL1b3Nv mRLKnT7csFusmHfOXWRlendlv8WxX7jrZCW123m7WLQcydDiy4mFP2qqPNdeo6RV71cj n9kzEBgzHR98WI7mYFJmhK7MZ6tpEI0rTsYdgy+JD7IPva1gdFE2mMVxTKRp5Mf/4RPU 0DNw== X-Gm-Message-State: AOAM5333NgtbW3oo5xW8sNXixNZ6FCQA0451NVnx+eI2LfqA0c0wmBmU mO+To/1SZ818mxH4L0/Pa52xet1nojTuSfIOrZhwcbC4Ggkn7TBmo+Dodx9sDAbJF1ohpcAQC3n TuEz6ZvSpSj68zfi1nRQ= X-Received: by 2002:a1f:9ac7:: with SMTP id c190mr2051116vke.17.1615974520587; Wed, 17 Mar 2021 02:48:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVau612PPwRBHE3x0BBRilvYYlKq9Dtl5wGv7w9dYNtSDsBPSHz4hl2oToMO7YFlrKyVycSq+wLJcICkr3+hs= X-Received: by 2002:a1f:9ac7:: with SMTP id c190mr2051109vke.17.1615974520363; Wed, 17 Mar 2021 02:48:40 -0700 (PDT) MIME-Version: 1.0 References: <20210317093124.965624-1-thomas@monjalon.net> In-Reply-To: <20210317093124.965624-1-thomas@monjalon.net> From: David Marchand Date: Wed, 17 Mar 2021 10:48:29 +0100 Message-ID: To: Thomas Monjalon Cc: dev , dpdk stable , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: fix version macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Mar 17, 2021 at 10:31 AM Thomas Monjalon wrote: > > The macro RTE_VERSION is broken since updated with function calls. > It is a build-time version number, and must be built with macros. > For a run-time version number, there is the function rte_version(). > > Fixes: 5b637a848195 ("eal: fix querying DPDK version at runtime") > Cc: stable@dpdk.org > > Reported-by: David Marchand > Signed-off-by: Thomas Monjalon > --- > lib/librte_eal/include/rte_version.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/include/rte_version.h b/lib/librte_eal/include/rte_version.h > index 2f3f727b46..736c5703be 100644 > --- a/lib/librte_eal/include/rte_version.h > +++ b/lib/librte_eal/include/rte_version.h > @@ -28,10 +28,10 @@ extern "C" { > * All version numbers in one to compare with RTE_VERSION_NUM() > */ > #define RTE_VERSION RTE_VERSION_NUM( \ > - rte_version_year(), \ > - rte_version_month(), \ > - rte_version_minor(), \ > - rte_version_release()) > + RTE_VER_YEAR, \ > + RTE_VER_MONTH, \ > + RTE_VER_MINOR, \ > + RTE_VER_RELEASE) > > /** > * Function to return DPDK version prefix string The original patch wanted to fix rte_version() at runtime. I don't see the need to keep the rte_version_XXX exports now that RTE_VERSION is reverted. -- David Marchand