From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3FD9A034F; Fri, 8 Oct 2021 13:09:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C6CB41102; Fri, 8 Oct 2021 13:09:43 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 56C3941102 for ; Fri, 8 Oct 2021 13:09:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633691380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uVqEQtaruN3cNTnKyb45Hd+lHOQMdWbpY6qNc0VTXEw=; b=T6oKgFBxsaGTEjiiEMqOY0ysVzSK1KbU3+aCh01zBCXsJIWUODAAZxHUpjwlpeTCIoa7nu 7nkOPhHG6Ec8btQUIlEsshmLRsCW9tIXSqLzVwPhi5ZI0NdYp14g4a8A6AaMPWx5lnqTnf NqVfzk4LSClQ0qUX3RftmOCLU7yCqdQ= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-2ouv-33wPhOaQT1-7WHmgQ-1; Fri, 08 Oct 2021 07:09:07 -0400 X-MC-Unique: 2ouv-33wPhOaQT1-7WHmgQ-1 Received: by mail-lf1-f71.google.com with SMTP id z29-20020a195e5d000000b003fd437f0e07so3970299lfi.20 for ; Fri, 08 Oct 2021 04:09:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uVqEQtaruN3cNTnKyb45Hd+lHOQMdWbpY6qNc0VTXEw=; b=oEvDcgdjZ1/GqtAsyZkeyrLjZBtlsfG3aCAG0l7ij4304qXAvoBjDlRCJ+OurUykqt 8li/bK1rU8xd94L3Xam1cXi55M2XxLTqjuqou7hm07UUGEirzIJelsjQRqfxrYkjUzhU On45sIqmkWYtzyPxuYir18reYKHLTB7LDvVjUy3KMRzebgf0Xpnc4AoTB2EDGbXZaFQ4 i03IU3fNHpQy7UBTjYlAf4+sVBQjcu9WKvbk36YU5/Xk618qRRHQU8BNZK1fbhoCOeHM sGj3W+hs7JEMvcjqPKAYpQqeFa/AqweYqnJchGLaocf3zFQnEAmXXsA51TMGKKtpxRIi ly9Q== X-Gm-Message-State: AOAM531svHCqEmE+SWvKwByGIuPVwm9pjZ4JxepUOaTTkYwzliuysr55 cXnYRxv9tGdOik0a42F5aAzQDtEs6bZxW3wcw5gCJz8LneOu7dwF7dKWPyVddJciMte/bFG0V6t tUjom75Q1R8vMQNkGR5o= X-Received: by 2002:a2e:8584:: with SMTP id b4mr2961678lji.477.1633691345634; Fri, 08 Oct 2021 04:09:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCzwWXfmun9HqUVo7210vNpOo1yqi6nk+9rPDt9NjerKzjFpimpUKEJYXd8zDJw+c75Mq/W/PPQd5cR6RrS4E= X-Received: by 2002:a2e:8584:: with SMTP id b4mr2961657lji.477.1633691345417; Fri, 08 Oct 2021 04:09:05 -0700 (PDT) MIME-Version: 1.0 References: <20211006192008.23369-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 8 Oct 2021 13:08:54 +0200 Message-ID: To: Bruce Richardson Cc: dev , dpdk stable , Konstantin Ananyev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/x86: fix some CPU extended features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 8, 2021 at 12:15 PM Bruce Richardson wrote: > > On Wed, Oct 06, 2021 at 09:20:08PM +0200, David Marchand wrote: > > Caught while checking CPUID related stuff in OVS. > > > > According to [1], for Structured Extended Feature Flags Enumeration Leaf > > (EAX = 0x07H, ECX = 0): > > > > - BMI1 is associated to EBX, bit 3 (was incorrectly 2), > > - SMEP is associated to EBX, bit 7 (was incorrectly 6), > > - BMI2 is associated to EBX, bit 8 (was incorrectly 7), > > - ERMS is associated to EBX, bit 9 (was incorrectly 8), > > > > This patch then sorts the rest of the extended features (leaf 0) for > > readability. > > > > 1: https://software.intel.com/sites/default/files/managed/c5/15/architecture-instruction-set-extensions-programming-reference.pdf > > > > Fixes: af75078fece3 ("first public release") > > Wow, I'm surprised at it being incorrect this long, but checking the > original commit of code, it does indeed seem true that this is the correct > fixes line! > > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Acked-by: Bruce Richardson > > Ideally, I think the fixes should go in a separate patch from the > reordering, but I don't feel strongly about it so this is ok as either one > or two patches IMHO. I was reading the datasheet and comparing the defines one by one, so easier with sorted defines. Now that I identified the wrong entries, I am fine with splitting since it eases backport on 19.11. I'll send v2 with your ack on both. -- David Marchand