From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B6A9A0C40; Tue, 23 Mar 2021 19:18:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 514F340683; Tue, 23 Mar 2021 19:18:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 8EBCD40143 for ; Tue, 23 Mar 2021 19:18:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616523518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l4kIw5iJ4ZvPzNz+SDgbCIjsV7TJwQbjf7zD/jXAIFc=; b=NthguxMwk3mViGzxf/zIU3gjeASwVmwszRUCWrxAEQZnCo7z454WMbu2lunKeP020rK2HD yL/5phOD94U1qwwMgY/yZDzRdqrWowwhxSmZA1IOPGj5k4j7jmH/YObCdi338nLPOy6GKU 0y8KJcZm9Wy9KHaWVfCHHTeQQqvRlbA= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-m3JTMb-MObu-hUWQCxQXdg-1; Tue, 23 Mar 2021 14:18:37 -0400 X-MC-Unique: m3JTMb-MObu-hUWQCxQXdg-1 Received: by mail-ua1-f72.google.com with SMTP id x6so534453uao.18 for ; Tue, 23 Mar 2021 11:18:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l4kIw5iJ4ZvPzNz+SDgbCIjsV7TJwQbjf7zD/jXAIFc=; b=Eum8tqfIEB2PiQf6wrASc4lPnQ1CPMMTufLwh7Z3otXC2A2HbOBTEuEvBy1u62Avf5 dW3rouu7xF5RW3Dvfg3GLMphzkW9DGEeeho0XrhoF2KXhmlUO/8vJy1JK3XCei68kwj5 2QXmhIDpH0bQhlGK5lv20TMwGZYwtE66r3BfwjevQ1P5yvtcPo7T9ewtI+wj5/bR3QoG P5EV1ALVL2BWK5K8asffH1dkv3z7zArGLxfIAbDdAZUWhWKnadOymdFqdS27HQVOH8tz +xTlizFJtsnVvvCmec2DzJrLFbmTACtSJYbG4GQyzogIpyr7ABIC7oWgAzbMP8/v/C7Q Z8FQ== X-Gm-Message-State: AOAM5323YZkVlyVbGjGa5A3+Y7M7CXXjGSKpOIQd75CIAkJgdLTtFeFA nykJNfypdjiWVQGPJ0ASUtomi3R8JKV1Vf7KiNB4QudpjRyUyGNfWlp9/xANqgGmo86vPi3SVjD xh1ehB1Rso0nAMivowi4= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr4295185vst.27.1616523516564; Tue, 23 Mar 2021 11:18:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTVqvvqHRmJVOhZETPoGZqhofzepQ9goEKXLgsY3d+TM3YB5vAacoLB+TXPSVIy8gsnNSed1vV7ODmmpSGHyM= X-Received: by 2002:a05:6102:ed4:: with SMTP id m20mr4295172vst.27.1616523516307; Tue, 23 Mar 2021 11:18:36 -0700 (PDT) MIME-Version: 1.0 References: <20210309233116.1934666-1-thomas@monjalon.net> <20210321223116.1340974-8-thomas@monjalon.net> <7775971.yr5XXRrMVS@thomas> In-Reply-To: <7775971.yr5XXRrMVS@thomas> From: David Marchand Date: Tue, 23 Mar 2021 19:18:24 +0100 Message-ID: To: Thomas Monjalon Cc: dev , Bruce Richardson , Andrew Rybchenko , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: add log level help X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Mar 23, 2021 at 4:10 PM Thomas Monjalon wrote: > > 23/03/2021 14:37, David Marchand: > > On Sun, Mar 21, 2021 at 11:32 PM Thomas Monjalon wrote: > > > > > > The option --log-level was not completely described in the usage text, > > > and it was difficult to guess the names of the log types and levels. > > > > > > A new value "help" is accepted after --log-level to give more details > > > about the syntax and listing the log types and levels. > > > > > > The array "levels" used for level name parsing is replaced with > > > a (modified) existing function which was used in rte_log_dump(). > > > > If we forget about the slightly different formatting, why not simply > > reuse rte_log_dump? > > It has the advantage of listing the default level for each logtype > > that a user cannot guess otherwise. > > I considered rte_log_dump() too much verbose for the help text. > It is printing the global level and the logtype ids. Yes, it gives all the info about the log subsystem. > The need for the end-user in the help is different of a debug dump. The result of rte_log_list_types is a list in link-time order. At least it is worth sorting alphabetically for users. What about default log levels? -- David Marchand