From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DCE51A034D; Wed, 16 Feb 2022 11:15:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C839D4113E; Wed, 16 Feb 2022 11:15:49 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BFC2C410FB for <dev@dpdk.org>; Wed, 16 Feb 2022 11:15:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645006548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=97hfBSz0ss8WAZ+P60K3zbjjJLPCmnv3J9zz2MkXiX4=; b=YdRdCAudfdnAx5kwsGJ+qZ48371sREh2hYfX/e4gJgKGEg6j2WbKwzNL2VYo+ZF2FszvuF JcexEb7UdxVdRdwOUPOah2S/VhaMgrg+UbWe4ngD2R9wUUk3YUBmSii9gNNBrtxpZfmnbL pzb/z5KicWai/JazcfX47ZTTSmoGG9Y= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-bsl2YuZjOombPgxEfV5h7Q-1; Wed, 16 Feb 2022 05:15:47 -0500 X-MC-Unique: bsl2YuZjOombPgxEfV5h7Q-1 Received: by mail-lj1-f198.google.com with SMTP id k33-20020a05651c062100b002460b0e948dso485614lje.13 for <dev@dpdk.org>; Wed, 16 Feb 2022 02:15:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=97hfBSz0ss8WAZ+P60K3zbjjJLPCmnv3J9zz2MkXiX4=; b=hQIocpmhX4qQ9wisR7VNRUkCyUancQvm+xCj1FpGoYXLRZ1OcEnztZuZ9/cWMKqpNq K6i+U8ZtYvIwE7oWRxK5mGjQNZsgAx2ioz42USMK1EFMC9gqNojXitMNicdfwQgQg2xq /+VuW9Z5sSNGVTNFRZp1QmK8g0nmGjBvHL1Mto+QNpn9D5CScuxg+iAV2lbvqdm+EYZ2 0VSmsWYVO9hoRucoz90kfdWhCZ4SMtPpHv3TvjzjA0Y7+n/ByOekIGkdanmtGkSqiNoX ApfsB1Epzk0I/OgKmgSV7+othSiO6X854mY6GYVIT0j2LpPWImkf6N2M0GNP0gsmX3Dh FOHg== X-Gm-Message-State: AOAM531WuUxJBjR6kHSep4Dc8QxtjnjwXu91ipJvylYcSMcFVZ7rrWN5 Pn6LPRrj/7vJyjtp5grU5H8lm4KXP1gsB9bYEF6vgTiMhNic8kIiUdjn86fugUqGrvdJL5oHL+R fbL6i7dbQqhHmzZ3ZHvA= X-Received: by 2002:a05:6512:3b9a:b0:43e:da0a:cab with SMTP id g26-20020a0565123b9a00b0043eda0a0cabmr1491850lfv.575.1645006545494; Wed, 16 Feb 2022 02:15:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJwko1fstLtA7t3KCp3gi/0N20g79rEHvO6Fp0lCZ6SY1JuxhwcwycVg1+iQToBe/Ghqv9PSp3f0KghxzGZxJLE= X-Received: by 2002:a05:6512:3b9a:b0:43e:da0a:cab with SMTP id g26-20020a0565123b9a00b0043eda0a0cabmr1491841lfv.575.1645006545309; Wed, 16 Feb 2022 02:15:45 -0800 (PST) MIME-Version: 1.0 References: <20220215101853.919735-1-robinx.zhang@intel.com> <CH0PR11MB5523F5FD89A71198DB0538359B359@CH0PR11MB5523.namprd11.prod.outlook.com> <CAJFAV8zY6FOW5d1br49m0VgNhZANGNmEzQ2CTVmMD=bBiTzJbA@mail.gmail.com> <1696182.K4a6FZZPjd@thomas> <YgzETN7EytbgKkDB@bricha3-MOBL.ger.corp.intel.com> <CAJFAV8wXnkuY7H2W43jYqG8jEnXMg=SLScjXexfxfpX+_4UsPw@mail.gmail.com> <YgzLwe/zRSvZKn4N@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <YgzLwe/zRSvZKn4N@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Wed, 16 Feb 2022 11:15:34 +0100 Message-ID: <CAJFAV8zWaeh0p40fFRQH+3FO3yUEu8dBPa805Owrn3Wo9k+pZA@mail.gmail.com> Subject: Re: [PATCH] app/testpmd: format dump information of module EEPROM To: Bruce Richardson <bruce.richardson@intel.com> Cc: Thomas Monjalon <thomas@monjalon.net>, "Zhang, RobinX" <robinx.zhang@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Singh, Aman Deep" <aman.deep.singh@intel.com>, "Zhang, Yuying" <yuying.zhang@intel.com>, "Guo, Junfeng" <junfeng.guo@intel.com>, "Yang, SteveX" <stevex.yang@intel.com>, Ciara Power <ciara.power@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Wed, Feb 16, 2022 at 11:02 AM Bruce Richardson <bruce.richardson@intel.com> wrote: > On Wed, Feb 16, 2022 at 10:41:43AM +0100, David Marchand wrote: > > On Wed, Feb 16, 2022 at 10:31 AM Bruce Richardson > > <bruce.richardson@intel.com> wrote: > > > > > I see that we have other telemetry callbacks for stats, link status > > > > > which might already have the issue. > > > > > > > > You mean there is no lock protection? Neither in the API, nor in > > > > telemetry? > > > > > > > For reporting out stats or link status, I'm not sure a lock should ever > > > be needed since both are just read-only operations. Therefore, I don't > > > believe we have a general issue here. > > > > Ok, if you are sure about this for all drivers for stats and link status, > > you can discard my comment. > > > No, I'm not 100% sure about it, but if any driver has issues with multiple > threads reading stats simultaneously I would hope that that should be > resolved at the driver level. Normally, one would expect read-only > operations to be implicitly multi-thread safe, and I also see that the > documentation on e.g. rte_eth_stats_get() makes no reference to needing > locks or not being thread-safe. I agree, resolving at the driver level is better. -- David Marchand