From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3393A0545; Tue, 11 Oct 2022 15:10:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 938C942DE1; Tue, 11 Oct 2022 15:10:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 99E2542B7D for ; Tue, 11 Oct 2022 15:10:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665493844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CnhG675mK6LYV0tQ9AuYJsB2ljpfwtoIEUv+o8KCbME=; b=X8oNc1UNmHG4gtYqsKbCq0pIv3OyKKp7LPIRcsrPXk3oE8NpoACBV+KJowSy0KpxPDiXCs GGMXFqjz+mEVD9mprCjMZXuFtyU4H7L5hvC7OG24DOl8AX7AzjjFggP1h2WRIjVx9IxpnL FHAJ3hzNpxnERkDRhtbdpEHLpVOsISk= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-619-WKwgaAMQOcGOECyMNVsHCg-1; Tue, 11 Oct 2022 09:10:43 -0400 X-MC-Unique: WKwgaAMQOcGOECyMNVsHCg-1 Received: by mail-pj1-f72.google.com with SMTP id z9-20020a17090a468900b00202fdb32ba1so5470563pjf.1 for ; Tue, 11 Oct 2022 06:10:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CnhG675mK6LYV0tQ9AuYJsB2ljpfwtoIEUv+o8KCbME=; b=u/k4LhC5k6PhclOa2Fp7Fq9UiIYw4fTg8cdk/zgs3HESC+u7DnWQ3n8/gpMjm2byS8 60Su779k/z3KVV/h/Wk7C0WRabJK58x7uZtzw0vuGnaipuocf2upHZOgJO1vg+uP4Eyk WeVGbQYKJ14UDf63eCc1k/vxgFrDSHMaT85Cje4DX0vnLzK/jduvPmIxCPi4y82JIkSz FKG6YFhAxYZuG0Ejz1wVjdUcaIxeG8K/mQeudb6s/Nt5LFzS58wjYJrbwU6RZfLPcKQB IWjMgowXhOHEZyFH/+p4aosBROms+RyhihwU9XZwVcdxs8Cu0Q+V+y71jBGApdql8VQt DiiQ== X-Gm-Message-State: ACrzQf1QBjYAzw5WiRyDVy5GcOElSKcnr+CMO+9+8ovX5d8CEb1ua5bn FZhHCETG5L4X8pTjOeyxXQ1LXd4X1bwYDPDq7K+/YnGqOdJpM3WwDXGOUrSKoz13vbrMEB0tn0a fgpb5jC3MEBkk4zTo7B8= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr27060568pjg.33.1665493841988; Tue, 11 Oct 2022 06:10:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4CGp1sfpoi6rCPzZRNc8PlJmRBcDDBlvQA/U6l4pz3+qf4mbybcxVxppWiWIGBJy8dVlcfNcdyC9eXzwCyyZU= X-Received: by 2002:a17:90a:428e:b0:205:d5fe:e0b3 with SMTP id p14-20020a17090a428e00b00205d5fee0b3mr27060543pjg.33.1665493841678; Tue, 11 Oct 2022 06:10:41 -0700 (PDT) MIME-Version: 1.0 References: <20221011110850.604496-1-omer.yamac@ceng.metu.edu.tr> <20221011110850.604496-2-omer.yamac@ceng.metu.edu.tr> In-Reply-To: <20221011110850.604496-2-omer.yamac@ceng.metu.edu.tr> From: David Marchand Date: Tue, 11 Oct 2022 15:10:29 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] drivers: remove the unnecessary version.map To: =?UTF-8?B?QWJkdWxsYWggw5ZtZXIgWWFtYcOn?= Cc: dev@dpdk.org, Ferruh Yigit , Bruce Richardson , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 11, 2022 at 1:09 PM Abdullah =C3=96mer Yama=C3=A7 wrote: > > With the previous patch, some version.map files are not necessary. > In this patch, we removed them. > > Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 > Suggested-by: Ferruh Yigit I'd like some check added as part of this series. Something like: $ git diff diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh index 32e1fa5c8f..9d2f85ed73 100755 --- a/devtools/check-symbol-maps.sh +++ b/devtools/check-symbol-maps.sh @@ -60,4 +60,18 @@ if [ -n "$local_miss_maps" ] ; then ret=3D1 fi +find_unneeded_maps () +{ + for map in $@ ; do + [ $(buildtools/map-list-symbol.sh $map | wc -l) !=3D 0 ] || echo $= map + done +} + +unneeded_maps=3D$(find_unneeded_maps $@) +if [ -n "$unneeded_maps" ] ; then + echo "Found unneeded map files:" + echo "$unneeded_maps" + ret=3D1 +fi + exit $ret It helped me catch: $ ./devtools/check-symbol-maps.sh Found unneeded map files: drivers/net/mana/version.map --=20 David Marchand