From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3888D45D13;
	Fri, 15 Nov 2024 15:54:45 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C4DB142FEB;
	Fri, 15 Nov 2024 15:54:44 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mails.dpdk.org (Postfix) with ESMTP id B888042F95
 for <dev@dpdk.org>; Fri, 15 Nov 2024 15:54:43 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1731682483;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=O96TZBMS5eWylLvYWKH0UVO0LZ21NFKWL40/FsJTZoA=;
 b=GYb8XWp88x2992Y5tjqhlyhvf0gnhmoZm9oLmr/njMCuU1VkZRXxeUfY7Y8611vm49K33Y
 3k7mEonNlpmEeAvoYzh6cAlOrark2r8EZm1weZ5ztlZIxbH+TcdQ/6xgFqnI/NXjrPKpTV
 MgbJlxMZeccFRA4wubmM2Ti3Aty0NI0=
Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com
 [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
 us-mta-463-dCX9MshnPJ23Q85Ji1_bHw-1; Fri, 15 Nov 2024 09:54:42 -0500
X-MC-Unique: dCX9MshnPJ23Q85Ji1_bHw-1
X-Mimecast-MFC-AGG-ID: dCX9MshnPJ23Q85Ji1_bHw
Received: by mail-lj1-f198.google.com with SMTP id
 38308e7fff4ca-2fb4dddaa01so13339101fa.1
 for <dev@dpdk.org>; Fri, 15 Nov 2024 06:54:41 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1731682480; x=1732287280;
 h=content-transfer-encoding:cc:to:subject:message-id:date:from
 :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=O96TZBMS5eWylLvYWKH0UVO0LZ21NFKWL40/FsJTZoA=;
 b=Y6mI6lixhhQxEbtBhmVqsjz/qgJ3G8CpnA55ztFxi4aNIZV1UBJSqMgI7sy6/19aDN
 N3tarAQm+S2NMhCKtpOlTv/+3UZY4oOERZB0XinP7OTSPUJWZKnVK19JPYjFryJXQ0O0
 C0nuEd34GWajhUVcBKMUh8AOPzKIWAOUOXLGJqZikDN+RsxD6amnHKNrrAbD/dtG2LUx
 8DPgsRG/PdIOLUtsqAZMdwllm71KUeTN4b5SR/udHft6de8Czmb/fulpNrltG0OGDaMc
 TyCUPrQUUUXkpmAEyYeEiaERetWXD06/9GGHG3Koh0cMSqMJhlEMgxMnIfPJy/K15m2d
 J03g==
X-Forwarded-Encrypted: i=1;
 AJvYcCXTj5IEdt4ShO2XH4RuOM655V5UWzT8hlK6e9xVwVvjMjD1ZjFVZSoEZgQH4yhIO7H1oKc=@dpdk.org
X-Gm-Message-State: AOJu0YwkuAbSs3we5E9flzHRbh79iQBq17corul7bQU+rFMLocrzajPu
 3p1dnqQV66ywycPXGeiuRFGr1DZq39RZ042lLROHeluW6h4boSywE0q4m6OQcK4dCeAtm17MTaE
 71aNyT3qUAkKZFxlxkl7faAcfUjEyErPtABT3MPzwQuZVMXcvc2FXiARqeBhhSzKg4G/4TJzl4n
 COs3rY5j1ULvW69NA=
X-Received: by 2002:a05:651c:50d:b0:2fb:527a:815b with SMTP id
 38308e7fff4ca-2ff6098d13emr20745161fa.28.1731682480479; 
 Fri, 15 Nov 2024 06:54:40 -0800 (PST)
X-Google-Smtp-Source: AGHT+IHk+nmzD73fxLPN116MiajQeHbv1EITGi3oeuR5v82oV3Cru9jmnM9UR4lEWxMymEIRQ2Eo4VN5WEU3JEseOHY=
X-Received: by 2002:a05:651c:50d:b0:2fb:527a:815b with SMTP id
 38308e7fff4ca-2ff6098d13emr20744911fa.28.1731682480094; Fri, 15 Nov 2024
 06:54:40 -0800 (PST)
MIME-Version: 1.0
References: <1731451713-24543-1-git-send-email-andremue@linux.microsoft.com>
In-Reply-To: <1731451713-24543-1-git-send-email-andremue@linux.microsoft.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 15 Nov 2024 15:54:29 +0100
Message-ID: <CAJFAV8zWv3cpKyY2kJwn0MuvyG0Atk+-qpkE5q2P4BJtwSj+sg@mail.gmail.com>
Subject: Re: [PATCH] argparse: enable code to be compiled with MSVC compiler
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: Chengwen Feng <fengchengwen@huawei.com>, dev@dpdk.org, 
 Tyler Retzlaff <roretzla@linux.microsoft.com>,
 Thomas Monjalon <thomas@monjalon.net>
X-Mimecast-Spam-Score: 0
X-Mimecast-MFC-PROC-ID: WYsfos0F4WwXzeZVDcL45bfIJ3f6JA3trqWFBPw98NE_1731682481
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Nov 12, 2024 at 11:48=E2=80=AFPM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> The issues that were preventing argparser from getting compiled with
> MSVC were fixed, so now it should not be excluded from the
> compilation anymore.

Just to be sure, it relates to fixes of bz 1409, right?

It's cool no new regression was introduced in the mean time.
Enabling libraries the sooner is better for getting a larger MSVC
support, I see no problem in taking this patch for rc3.


>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>


--=20
David Marchand