From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E15944019; Mon, 13 May 2024 13:47:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66571402D1; Mon, 13 May 2024 13:47:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4EE964003C for ; Mon, 13 May 2024 13:47:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715600838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I15xnlHQhKsz97OBlI0VJ7SOE8IhmcEKeLtqbpFr0qM=; b=iRjmbT73BlqI1R3RxEt92MSvKa6lkSdQnkdOBdwZ6e9dhEKs8BeKGaIcFXp+ffKq81D+Bj FFy9+ZkHyfKaTe8deXAhs7OMGI6CiSTr4IFM76NNK5orMk++Xy+/3stlRbF+o72DgJfwwo Yjne97d/DW4UPEcbGcrnFJ9d6NhWqPw= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-MIscNvU4Nv2JVG0DK_hasQ-1; Mon, 13 May 2024 07:47:17 -0400 X-MC-Unique: MIscNvU4Nv2JVG0DK_hasQ-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2e2035036f5so41042761fa.0 for ; Mon, 13 May 2024 04:47:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715600836; x=1716205636; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I15xnlHQhKsz97OBlI0VJ7SOE8IhmcEKeLtqbpFr0qM=; b=K9VJcpO78ZU9B+htQLd9DwkogSJEa0j/JP50o2vks3eEoovJBfx2n0YhNSLHv52r8p yFsIjEzSXSI3y810uEbPJqJvSgwpKTec0QaWnCBY2pOlNJM2R3foDSiQigJ18hgmAeI3 1K7sM8Qvdc3OnAIg3GL8AvGPmfkY788avDd8Pcgcke56rzQzbbttj8q50vj7wlQ8UpCX y5b2qFHFj4X5s5qkKCmokSU3bI0huH7aK8QQNBj3Ml1OXiAxDBOnFGqsvf8Uhmk8uVJK UAWxHHAtJjKEUNSJveAfVyf5v6mPxqadEnQL3YGfFN4CB8eqwSYkCVKBiypxEdB8A6fy pKzw== X-Gm-Message-State: AOJu0YzeU9eZg5fCoNPh7Kns3nHhbh/W29KD7OiFUtv3YwzD0q1oBtAT 1aIMVc9s45ACaodBMa2C3QJVJ94LYIL0fxFfzNv5Nfxt3/AycSgSStr1DNDBSJPxORmegIS38ob P3+Zgr2NNj3vVWNjHqxayP586xtiUvYNsvmmJ/dIPQtMODx557rh5mFdvt2sygUKfUVnG03HGdG 8/WL+Y9b+zQEaytrY= X-Received: by 2002:a05:651c:546:b0:2df:1e3e:3280 with SMTP id 38308e7fff4ca-2e51ff5da7dmr105737601fa.28.1715600836177; Mon, 13 May 2024 04:47:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIs9eP0FTUBLyYRUT3u+rqtbkteboA5/vn2jBSk7vziODTH5IxQcbUbDQrrp7vVsoXuZeZdJtkaJIX8JqyPio= X-Received: by 2002:a05:651c:546:b0:2df:1e3e:3280 with SMTP id 38308e7fff4ca-2e51ff5da7dmr105737391fa.28.1715600835798; Mon, 13 May 2024 04:47:15 -0700 (PDT) MIME-Version: 1.0 References: <20240508095214.2541115-1-david.marchand@redhat.com> <20240513111204.3120460-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 13 May 2024 13:47:04 +0200 Message-ID: Subject: Re: [PATCH v2] eal/unix: support ZSTD compression for firmware To: Bruce Richardson Cc: dev@dpdk.org, Yu Jiang , stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Bruce, On Mon, May 13, 2024 at 1:37=E2=80=AFPM Bruce Richardson wrote: > > @@ -16,6 +16,8 @@ > > #include "eal_firmware.h" > > #include "eal_private.h" > > > > +static const char * const compression_algorithms[] =3D { "xz", "zst" }= ; > Very minor nit: these are the suffixes used to find the files, more than > they are the compression algorithms. There I'd suggest renaming to > "compression_suffixes". > [Perhaps just fix on apply if taking this suggestion] I'll fix when applying. Thanks for the review and tests. --=20 David Marchand