From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36D3A41D79; Mon, 13 Mar 2023 11:52:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC6C5406BC; Mon, 13 Mar 2023 11:52:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9D10440151 for ; Mon, 13 Mar 2023 11:52:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678704736; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EM+JFEWetSYPgiWWSkvylq4Pv3XbHk/+jFLTHiHoFck=; b=Id6SMYibltQFyCyRGSWOr6NruvDUxUSCrVWp2XsJ8RY+cG9jbFwPRtF9NwC4XlrxV64aYD q81IxoHI+DtMTe6RkYkmmoVSK5reH6mr/jCOfsIbtXYQ/PvsQcZ5KHY7sOAD4vX+TPu6Jl nrtgaPJl4qesBH8iPhHfizfmipT7QZI= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-436-86gYiLpCPde-8R_UaLvQjw-1; Mon, 13 Mar 2023 06:52:14 -0400 X-MC-Unique: 86gYiLpCPde-8R_UaLvQjw-1 Received: by mail-pj1-f71.google.com with SMTP id pb4-20020a17090b3c0400b00237873bd59bso4274398pjb.2 for ; Mon, 13 Mar 2023 03:52:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678704734; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EM+JFEWetSYPgiWWSkvylq4Pv3XbHk/+jFLTHiHoFck=; b=QuXHITujmRe2CbyRFpYg+F31zJiEGY78WgLtwIf4iyD/tE9QHWgBT+euCpvjICpssH kDpC79ogopm3kr0XPvi/o78DO5MCBGBFTdYaRUQFZ8s/8oQu/yKQJhiIvrwwxxArJguD c9jqzJEaFNZKgHKVAGozkyoBXQfY7E4QXwoY+YyZxWuMN/WGJFwGNSae46P+o9GlKm0C Qh5VnvdChNbXox/NAWsgox1JYuCY+2/moab/vflI8eTYR1k/PJlvTJoCmqIt/5MZToo5 zsusE5kCnCB6NJLxXe5xtrYCk0j0EX+t9xLgMqX9pyrA+ZPI1L+QCRma/M/EsTt3WQS9 Md2Q== X-Gm-Message-State: AO0yUKX1oGAbgUI2Ja3BVzWjJm+9wK7B/WATlVVZEU4R9znrHFvH03Eh gHZ/UTmprJMS8oyiBhn80SeiK5XVVdj94qAO5C310o3lmRTo2T8SdJuaY6tGACwqHowqHGenqW0 dBgXoammnFeeFmLkUhK0= X-Received: by 2002:a63:8f17:0:b0:507:4d05:15ef with SMTP id n23-20020a638f17000000b005074d0515efmr8693114pgd.11.1678704733998; Mon, 13 Mar 2023 03:52:13 -0700 (PDT) X-Google-Smtp-Source: AK7set9g4aybrW9xiILNBJ3xNE+gLIWoRlw2QZdnxzWNQmaLu3Y0AzN6Cj3elRPpCmCAakujfBTMZASpuFRcBdWNFgQ= X-Received: by 2002:a63:8f17:0:b0:507:4d05:15ef with SMTP id n23-20020a638f17000000b005074d0515efmr8693108pgd.11.1678704733725; Mon, 13 Mar 2023 03:52:13 -0700 (PDT) MIME-Version: 1.0 References: <20230311145056.16386-1-syalavarthi@marvell.com> In-Reply-To: <20230311145056.16386-1-syalavarthi@marvell.com> From: David Marchand Date: Mon, 13 Mar 2023 11:52:02 +0100 Message-ID: Subject: Re: [PATCH] mldev: remove weak symbols use in type conversions To: Srikanth Yalavarthi Cc: dev@dpdk.org, sshankarnara@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Sat, Mar 11, 2023 at 3:51=E2=80=AFPM Srikanth Yalavarthi wrote: > > Drop use of weak symbols to select the type conversion > functions. Select NEON implementation only on Aarch64 > builds. Enable windows build. > > Fixes: 3c54f91ad8c9 ("mldev: disable build on Windows") Strictly speaking we are not fixing this change above, but rather Fixes: 9637de38a2e3 ("mldev: add scalar type conversion") > > Signed-off-by: Srikanth Yalavarthi The change looks good to me and the UNH Windows build target seems to agree= :-). Reviewed-by: David Marchand Thanks Srikanth. --=20 David Marchand