From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-ua1-f68.google.com (mail-ua1-f68.google.com
 [209.85.222.68]) by dpdk.org (Postfix) with ESMTP id 072782BA3
 for <dev@dpdk.org>; Mon,  4 Mar 2019 10:53:53 +0100 (CET)
Received: by mail-ua1-f68.google.com with SMTP id g1so3832931uae.10
 for <dev@dpdk.org>; Mon, 04 Mar 2019 01:53:52 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=U8MtISCjmWZB3BFva9ugblYoWu0uwkLJzr2HjnX7A50=;
 b=iH1j8PJYdzfwnSePseE5kn/LXA9WikzoZYHuLHzv9CCp0j44CfBIIsMilUdvlqr8/L
 ZVeezMazCRkv2Ca1gJi9nrA1lidtsF+TR09MMXrUryi2mnTc/Waz2fk+fp8c0zzE2v4E
 cnl5ATucny9r9jfI8ChpklHV8whaQ7qRjPJZ7X3x/dXxFhT/lS1kJrrv1Cka1FXXL5S7
 Er/kHQMEUhActdAsreUbX11b6hiBofp1LmRu8ZaREtPWm3luOB0rGOU2deJTPk4oDizQ
 ZKk1QWDaxjNYgAOQ1WGP4US8mrXeKY7sXVQ5VFmel+RbBOh0ROyNLgjGXGCsR03vqZ82
 URRw==
X-Gm-Message-State: APjAAAXQY8d85QYNUR1ZF140wUw8gblNKeRLnkiGkDlKSAGsIQ/ef+J9
 p+qD1mvSyFvMeX+j362hZpuxN4Yf0W/9DMLLLyFCUQ==
X-Google-Smtp-Source: APXvYqzySgSEyMfCqg8vHYvWhNPK8TdqVU4aet1sU8cWpOwGjyYVBWx7h8I7m7TzxcZ6IooYAl0HM/MyqL+2nClQ9WA=
X-Received: by 2002:a67:ef90:: with SMTP id r16mr9153289vsp.141.1551693232362; 
 Mon, 04 Mar 2019 01:53:52 -0800 (PST)
MIME-Version: 1.0
References: <1551185824-5501-2-git-send-email-cernay@netcope.com>
 <1551451054-111249-1-git-send-email-cernay@netcope.com>
 <20190301105014.17cffa3f@shemminger-XPS-13-9360>
In-Reply-To: <20190301105014.17cffa3f@shemminger-XPS-13-9360>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 4 Mar 2019 10:53:41 +0100
Message-ID: <CAJFAV8zXHqokkG1_HKTksBXRQO+pUOpg5LeBkxKm7dnUL3yUyQ@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Rastislav Cernay <cernay@netcope.com>, dev@dpdk.org, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3] net/nfb: new netcope driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Mar 2019 09:53:53 -0000

On Fri, Mar 1, 2019 at 7:50 PM Stephen Hemminger <stephen@networkplumber.org>
wrote:

> On Fri,  1 Mar 2019 15:37:34 +0100
> Rastislav Cernay <cernay@netcope.com> wrote:
>
> > From: Rastislav Cernay <cernay@netcope.com>
> >
> > Added new net driver for Netcope nfb cards
> >
> > Signed-off-by: Rastislav Cernay <cernay@netcope.com>
> > ---
>
> Please fix these obvious style issues from checkpatches
>
> ERROR:SPACING: space required before the open brace '{'
> #934: FILE: drivers/net/nfb/nfb_ethdev.c:380:
> +       if (!is_valid_assigned_ether_addr(mac_addr)){
>
> WARNING:ONE_SEMICOLON: Statements terminations use 1 semicolon
> #935: FILE: drivers/net/nfb/nfb_ethdev.c:381:
> +               return -EINVAL;;
>


And if you look carefully at checkpatches.sh output, you can see:
[dmarchan@dmarchan dpdk]$ ./devtools/checkpatches.sh

### net/nfb: new netcope driver

[snip]

total: 1 errors, 2 warnings, 1884 lines checked
./devtools/checkpatches.sh: line 65: res: command not found

I will post a fix on checkpatches.sh for this, then a new warning appears:

Warning in /doc/guides/nics/nfb.rst:
Using explicit .svg extension instead of .*


-- 
David Marchand