From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A843A0C3F; Thu, 15 Apr 2021 16:59:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AFDDF160E1C; Thu, 15 Apr 2021 16:59:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6761E160AA6 for ; Thu, 15 Apr 2021 16:59:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618498760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a9B4aDnDoDaulJd0U65fSWm5DW5GiGiDUnbigDo/8w4=; b=MdhMf49WP7T6jpj6a1yMSIHjxbzQbQp5KazNQ/xhNNQyyvS6S5X8w2G+ICR7CBcCCje956 GhuYG2SQvt6K8aWiePM3Bdi+OFU0/cFo14Eaxzpp68dGc9L1nLE//mXvhx4wDX5qKhRky3 LWNOJFdAiAyC6BkOr0TlzsQw38ocX3U= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-138--xKhMdBxNcuwJfx_iVLxQg-1; Thu, 15 Apr 2021 10:59:17 -0400 X-MC-Unique: -xKhMdBxNcuwJfx_iVLxQg-1 Received: by mail-vk1-f198.google.com with SMTP id a133-20020a1ffc8b0000b02901ca14ac4722so1342711vki.23 for ; Thu, 15 Apr 2021 07:59:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=a9B4aDnDoDaulJd0U65fSWm5DW5GiGiDUnbigDo/8w4=; b=GLgHFWe0gpTRWo7dwv1RPeFnI4+T8pM0cMNIOT1NTp8YtIyx21vDkdHvKdZouWg8H2 Psi8YVDL07bGUbyPv69k035Ws5nuxRWeKEmuxLgEbuX9l3/zZe/zuqQenOEYdK/7HKR9 cOtCXv5wgLeX5wamp96G3w1XeYlhcW5EqXehkbDw8Zb7gUIqVSKAOg/GAjYuXBtvnQnh sgQwuqnW1DcKoRCKzYDvEOeX9TfbZjsAl0KBkfatPRcn84hdWUbPn8KUiY8GhjHeRwmn fCqaK8Uou1MJbESpoajRSOhnstTAOwrm4ZGx3jfNHV2svVbjb7Ny2KsduTNMvxrlf60d IRCQ== X-Gm-Message-State: AOAM531jQ2q0ZKo4dj4OPqZfrqsoE3iYzHq9/9PzokaZnEgbdwj994OU vrBbg8HVuIwey2wnA3SqfcdpCRfAwl/zThHXLfazpPt+my3l0tCJa8zrtvRZQF092epxZWW8fLH U8R6lEoJiEb/FNMSZdiY= X-Received: by 2002:ac5:c0c8:: with SMTP id b8mr2526279vkk.18.1618498756648; Thu, 15 Apr 2021 07:59:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLXg/YyKXG2gMzQgYooqlRiActysFRKNBXVxvaiBmUU5bvOxU0y9yLdbADHjZg3URZ5NeRRn3JBIAdO9XP+Ws= X-Received: by 2002:ac5:c0c8:: with SMTP id b8mr2526267vkk.18.1618498756490; Thu, 15 Apr 2021 07:59:16 -0700 (PDT) MIME-Version: 1.0 References: <20210402105252.1145821-1-conor.walsh@intel.com> <20210406111106.2020555-1-conor.walsh@intel.com> <20210406111106.2020555-6-conor.walsh@intel.com> In-Reply-To: <20210406111106.2020555-6-conor.walsh@intel.com> From: David Marchand Date: Thu, 15 Apr 2021 16:59:05 +0200 Message-ID: To: Conor Walsh Cc: Jerin Jacob Kollanukkaran , Stephen Hemminger , "Iremonger, Bernard" , "Ananyev, Konstantin" , Vladimir Medvedkin , "Burakov, Anatoly" , "Mcnamara, John" , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 5/5] doc/guides/l3_forward: update documentation for FIB X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 6, 2021 at 1:11 PM Conor Walsh wrote: > + /* populate the FIB table */ > + > + for (i = 0; i < IPV4_L3FWD_NUM_ROUTES; i++) { > + struct in_addr in; > + > + /* skip unused ports */ > + if ((1 << ipv4_l3fwd_fib_route_array[i].if_out & enabled_port_mask) == 0) Little extra comment, this code is not using the same variables as the code. Pasting all this code in the documentation does not help, I would just remove it and/or reference the code example to avoid doc and example being out of sync in the future. > + continue; > + -- David Marchand