From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76774A0524; Mon, 7 Dec 2020 11:51:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 990A0F12; Mon, 7 Dec 2020 11:51:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 28A89CF3 for ; Mon, 7 Dec 2020 11:51:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607338271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3vqp0Lk/Pm/EoR/CBRhQ2/ad8fgB5tejKoSYqvb83H8=; b=MA8BO/y5wl59vSq5fCFOtNYCh31dmz5pFhHk7sXheBhQEr8wPiLAD4tS5MpoDlAuD+bQBI mIvrtkeSxtXcRr8PDOqYJteduCa0/HqIO8qsruYs4VfWUnkufKc+WDYTG7JLEH8nz1SPdB cdpGMNr9Qc0kMa0ZsgqR7R5MlavKZ3E= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-63-mITm6xzkPYyqsd9Us3IYlA-1; Mon, 07 Dec 2020 05:51:07 -0500 X-MC-Unique: mITm6xzkPYyqsd9Us3IYlA-1 Received: by mail-vs1-f70.google.com with SMTP id x16so443192vsx.6 for ; Mon, 07 Dec 2020 02:51:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3vqp0Lk/Pm/EoR/CBRhQ2/ad8fgB5tejKoSYqvb83H8=; b=OIBYzce5RAcPS8jXYjfP7ES8DoArbZeTKw+6BCndEapRqIjZnSS2E9LDnwJv5p2WeI IRJnElGAIZI9qpfl29I6zpXH2m08GpLb1Ut4kBudo9MJy7c1JPAcX0KtIi9PycEEElnz l8DDFm+nOCWj7JtwIkGZkQajJa+1LPd9o9/Fscl3kt5zKI6W4jvCF5UvpJ1oTVZcU/mn f4c69RiVyfPTKXtPl4Fi57SYZS+e9cfa5WPlww/dDwralQvc0jvBcn2Rclc+jI0Qwyv0 l3yGrpDnOjUDVpxU2+Ek+o0WSqkC67HyFPZ+HqJAPxjvgTdkavt3Ln29JfxTTB6p9yZq rNAw== X-Gm-Message-State: AOAM532m3lipnKXX/p1bDNeNlIeaJab0BtB+OpfClB6nm6oVL8jVWltQ Cb8/4cX45oCQJuAnPRo/Sa36vZ7L7TRx4qnsnBBD3d+CDbx9eXTvi7caMHcAbcuxeNk5tK2bKF7 2l+0YDwFXOVhFiamw1qM= X-Received: by 2002:a67:6781:: with SMTP id b123mr12316934vsc.10.1607338267269; Mon, 07 Dec 2020 02:51:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJy2OQu255HmpuWkMWBMGHGbgjtWV6RXOtSqPC8ik19/1ibtRd/dswI53T3jUoSiQnIP/Vfiq57M4RmuSfqP1iQ= X-Received: by 2002:a67:6781:: with SMTP id b123mr12316930vsc.10.1607338267066; Mon, 07 Dec 2020 02:51:07 -0800 (PST) MIME-Version: 1.0 References: <20201124123249.14451-1-ibtisam.tariq@emumba.com> In-Reply-To: <20201124123249.14451-1-ibtisam.tariq@emumba.com> From: David Marchand Date: Mon, 7 Dec 2020 11:50:55 +0100 Message-ID: To: Ibtisam Tariq Cc: Maxime Coquelin , "Xia, Chenbo" , Cristian Dumitrescu , "Singh, Jasvinder" , "Mcnamara, John" , "Pattan, Reshma" , "Ananyev, Konstantin" , "Kovacevic, Marko" , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/7] examples/fips_validation: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 24, 2020 at 1:33 PM Ibtisam Tariq wrote: > > Instead of using getopt_long return value, strcmp was used to > compare the input parameters with the struct option array. This > patch get rid of all those strcmp by directly binding each longopt > with an int enum. This is to improve readability and consistency in > all examples. > > Bugzilla ID: 238 > Cc: marko.kovacevic@intel.com > > Reported-by: David Marchand > Signed-off-by: Ibtisam Tariq > --- > v3: > * None. We lost the version prefix in the patch title, please do not forget it in the next revision. [snip] > diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c > index cad6bcb18..36ed4b546 100644 > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -15,17 +15,26 @@ > #include "fips_validation.h" > #include "fips_dev_self_test.h" > > -#define REQ_FILE_PATH_KEYWORD "req-file" > -#define RSP_FILE_PATH_KEYWORD "rsp-file" > -#define MBUF_DATAROOM_KEYWORD "mbuf-dataroom" > -#define FOLDER_KEYWORD "path-is-folder" > -#define CRYPTODEV_KEYWORD "cryptodev" > -#define CRYPTODEV_ID_KEYWORD "cryptodev-id" > -#define CRYPTODEV_ST_KEYWORD "self-test" > -#define CRYPTODEV_BK_ID_KEYWORD "broken-test-id" > -#define CRYPTODEV_BK_DIR_KEY "broken-test-dir" > -#define CRYPTODEV_ENC_KEYWORD "enc" > -#define CRYPTODEV_DEC_KEYWORD "dec" > +enum { > +#define OPT_REQ_FILE_PATH "req-file" > + OPT_REQ_FILE_PATH_NUM = 256, > +#define OPT_RSP_FILE_PATH "rsp-file" > + OPT_RSP_FILE_PATH_NUM, > +#define OPT_MBUF_DATAROOM "mbuf-dataroom" > + OPT_MBUF_DATAROOM_NUM, > +#define OPT_FOLDER "path-is-folder" > + OPT_FOLDER_NUM, > +#define OPT_CRYPTODEV "cryptodev" > + OPT_CRYPTODEV_NUM, Nit: could you realign those two strings? > +#define OPT_CRYPTODEV_ID "cryptodev-id" > + OPT_CRYPTODEV_ID_NUM, > +#define OPT_CRYPTODEV_ST "self-test" > + OPT_CRYPTODEV_ST_NUM, > +#define OPT_CRYPTODEV_BK_ID "broken-test-id" > + OPT_CRYPTODEV_BK_ID_NUM, > +#define OPT_CRYPTODEV_BK_DIR_KEY "broken-test-dir" > + OPT_CRYPTODEV_BK_DIR_KEY_NUM, > +}; [snip] > @@ -248,108 +266,113 @@ cryptodev_fips_validate_parse_args(int argc, char **argv) > return -EINVAL; > } > > - while ((opt = getopt_long(argc, argvopt, "s:", > + while ((opt = getopt_long(argc, argvopt, "", Passing "s:" was a bug (since nothing was done with it). But this was not an issue requiring a separate fix + backport from my pov. Let's at least mention it in the commitlog. > lgopts, &option_index)) != EOF) { > > + if (opt == '?') { > + cryptodev_fips_validate_usage(prgname); > + return -1; > + } Why a separate check here? The default: block below will handle an unknown option fine. > + > switch (opt) { [snip] > + > default: > - return -1; > + cryptodev_fips_validate_usage(prgname); > + return -EINVAL; > } > } > -- David Marchand