From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47CF3A0563; Mon, 23 Mar 2020 09:13:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2300E1C036; Mon, 23 Mar 2020 09:13:38 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by dpdk.org (Postfix) with ESMTP id 8F6D01C029 for ; Mon, 23 Mar 2020 09:13:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584951216; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4QKDU82BHtfgGG5aVRynHfK9pzAnli/BA17uXLZJZkI=; b=bKyPTBZE2ibltyKqG/bui4wpsEE9Jnvv5ahKo4molhp2r5JSid0PbZozmIYLOqpvkIDGKc U4i3dHUR94+ykeNn/C1O4S/hSNNcJiHW25cN912vxC8tZpiAHR8l/oN41cwSNLfBbuBr++ qM263Zo212ZTVv+x8PsWx+8IBTl1mD4= Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-183-CsQyFVEANC-6V0GFbFiP1w-1; Mon, 23 Mar 2020 04:13:34 -0400 X-MC-Unique: CsQyFVEANC-6V0GFbFiP1w-1 Received: by mail-il1-f198.google.com with SMTP id a2so11965506ill.13 for ; Mon, 23 Mar 2020 01:13:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v/PNDyYAZeEehLTZrP71mTZvUHjpVhkuJkQ13C3CF7k=; b=W1pARbxIVAHtoK8kmstUvv3Kq9pFAaTxor6mjpnA1OiM7E4sHzPLbXz8U0AHXJ1HoZ sLfyGIINY6sxInBkSZPqX/VE6RUn56OyW433rD/GeV9Msum7dKve+AYO/0n/l412HTvu qhjTmBgenWgIy1MiR/Z4e4fA9gItn14jMioNvPyBnfOQgT4rfy0A7cgICNOAqxAYssjq HT8pTGVU4eySg6Ej+2ea+wfmhBJ7j/JJGNyT7tW0EOJa21ECyr2THlKYX3DfzEngztNN ZkTisaUCFo2IbaSTBTOm1m7S+3KzbMNnPk7bbhY3hsPiYXMdY+rDOxo8BFJlsN4vavcp ks+A== X-Gm-Message-State: ANhLgQ0x6zpdJc1+bNXScy4sYPtwb+4qnN7y1hmChlsPX1dlb5d70duF 2FiPGYnt5uR8KpKWpQU2di1ixfpkKnGqCxvG5+IInQvO+dziahQNJplx8kOyEoccM9t/+eDiYpm bkj9bjB24X2eTuM0B8lI= X-Received: by 2002:a6b:491a:: with SMTP id u26mr18397471iob.30.1584951213699; Mon, 23 Mar 2020 01:13:33 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtqq16hC1WqVIpeYiG7LQ6Smtu5L5hdxIHMX+mgs4X3WIGgMAmvREHtlmhEAqj5j7/n9Omiv6FrDpbNFjM2W7E= X-Received: by 2002:a6b:491a:: with SMTP id u26mr18397456iob.30.1584951213382; Mon, 23 Mar 2020 01:13:33 -0700 (PDT) MIME-Version: 1.0 References: <20200319144418.15661-1-ndabilpuram@marvell.com> In-Reply-To: <20200319144418.15661-1-ndabilpuram@marvell.com> From: David Marchand Date: Mon, 23 Mar 2020 09:13:22 +0100 Message-ID: To: Nithin Dabilpuram Cc: Thomas Monjalon , Neil Horman , dev , Jerin Jacob Kollanukkaran , dpdk stable , bingz@mellanox.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] devtools: fix check symbol change script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram wrote: > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-chan= ge.sh > index c5434f3..19ce82f 100755 > --- a/devtools/check-symbol-change.sh > +++ b/devtools/check-symbol-change.sh > @@ -17,13 +17,13 @@ build_map_changes() > # map files are altered, and all section/symbol names > # appearing between a triggering of this rule and the > # next trigger of this rule are associated with this file > - /[-+] a\/.*\.map/ {map=3D$2; in_map=3D1} > + /[-+] [ab]\/.*\.map/ {map=3D$2; in_map=3D1} > > # Same pattern as above, only it matches on anything that > # does not end in 'map', indicating we have left the map = chunk. > # When we hit this, turn off the in_map variable, which > # supresses the subordonate rules below > - /[-+] a\/.*\.[^map]/ {in_map=3D0} > + /[-+] [ab]\/.*\.[^map]/ {in_map=3D0} [^map] does not mean "not word map" but actually "none of the character m, a or p". So potentially, any file extension starting with m, a or p could trigger an issue. For example, a change in .mk files, .py files and ./devtools/check-forbidden-tokens.awk ./devtools/libabigail.abignore could lead to incorrect symbol check. How about the following change: diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change= .sh index c5434f3bb0..ed2178e36e 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -17,13 +17,11 @@ build_map_changes() # map files are altered, and all section/symbol names # appearing between a triggering of this rule and the # next trigger of this rule are associated with this file - /[-+] a\/.*\.map/ {map=3D$2; in_map=3D1} + /[-+] [ab]\/.*\.map/ {map=3D$2; in_map=3D1; next} - # Same pattern as above, only it matches on anything that - # does not end in 'map', indicating we have left the map ch= unk. - # When we hit this, turn off the in_map variable, which - # supresses the subordonate rules below - /[-+] a\/.*\.[^map]/ {in_map=3D0} + # The previous rule catches all .map files, anything else + # indicates we left the map chunk. + /[-+] [ab]\// {in_map=3D0} # Triggering this rule, which starts a line and ends it # with a { identifies a versioned section. The section nam= e is --=20 David Marchand