From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 627FCA0487 for ; Mon, 1 Jul 2019 18:46:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8691B1B9F2; Mon, 1 Jul 2019 18:46:01 +0200 (CEST) Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) by dpdk.org (Postfix) with ESMTP id 5E75D1B9EA for ; Mon, 1 Jul 2019 18:46:00 +0200 (CEST) Received: by mail-vs1-f44.google.com with SMTP id q64so9349268vsd.1 for ; Mon, 01 Jul 2019 09:46:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sV4tJW7+L0LrXvbotMsnd7m/ek4qBQvj54zitRb20vI=; b=YYDQoTqbiOgCIoNaGDLNHkFHZwv0hT+WJeDPrKrM4qDVZYQnKybn2GfAwbIj77RSyk YAQuyA03jRFz9GIz1WIsYl0TvCTSY3FOH1St2Fozk7s9U3v2AFfKTMBXb6AGaGJCSSKt kL5yPAEA0BTpxA5hjV+GQwYkDPiel9zAKgYfkj0tKlBMluS4puO37g6d6ruC8f5DhWRt k1pfM8FuuJN2s0JHGSRUSnrkYI35+DF23V00/UWPkjqar4FwZwOQVKTWfBigYoqIae87 WRiMFbw2qYO8KFYpV9kxHl0+O2naCKowIt4ITKBWL6kxjr5IJ6gZ1T1dq8qdInrQFy4P EBJw== X-Gm-Message-State: APjAAAW+00HPPRw/5/l26+iHNTgXvaV83wMHBnGUe8GXnIROrq0aRSF5 Mtteuxsic3Phf6QHdi7ZYnL7iZ75xnNjzmxH7Ok9Hw== X-Google-Smtp-Source: APXvYqzUNwFvr++jQWKqtWX2QZ79aiSy7bF92Ipb5bqLrjtabqT97sGxI2i6LDUk6dRZgDf0hBKVLgyqKYLo9w7p5bo= X-Received: by 2002:a67:2ec8:: with SMTP id u191mr15741447vsu.39.1561999559772; Mon, 01 Jul 2019 09:45:59 -0700 (PDT) MIME-Version: 1.0 References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-1-git-send-email-david.marchand@redhat.com> <70986373.KVGszKu7e3@xps> In-Reply-To: From: David Marchand Date: Mon, 1 Jul 2019 18:45:48 +0200 Message-ID: To: Aaron Conole Cc: Thomas Monjalon , dev , Michael Santana , JananeeX M Parthasarathy Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 00/15] Unit tests fixes for CI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 1, 2019 at 6:04 PM Aaron Conole wrote: > >> - rwlock_autotest and hash_readwrite_lf_autotest are taking a little > more > >> than 10s, > > Occasionally the distributor test times out as well. I've moved them as > part of a separate patch, that I'll post along with a bigger series to > enable the unit tests under travis. Michael and I are leaning toward > introducing a new variable called RUN_TESTS which will do the docs and > unit testing since those combined would add quite a bit to the execution > time of each job (and feel free to bike shed the name, since the patches > aren't final). > Seeing how the distributor autotest usually takes less than a second to complete, this sounds like a bug. I don't think I caught this so far. Yes, we need a variable to control this and select the targets that will do the tests and/or build the doc. About the name, RUN_TESTS is ok for me. What do you want to make of this variable? Have it as a simple boolean that enables everything? Or a selector with strings like unit-tests+doc+perf-tests? > >> - librte_table unit test crashes on ipv6 [2], > > I guess we're waiting on a patch from Jananee (CC'd)? > Yep. -- David Marchand