From: David Marchand <david.marchand@redhat.com>
To: Jim Harris <james.r.harris@intel.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: fix unused-but-set-variable error
Date: Thu, 4 Nov 2021 13:19:02 +0100 [thread overview]
Message-ID: <CAJFAV8zYF7EbC2RV34QX3cqED+bORX_tX=SsO0-8FUyu7+cBbA@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8w6OUcARd+RGy+b0EoiMRtAfECrfot09MBJamZGO34OOQ@mail.gmail.com>
On Fri, Oct 29, 2021 at 8:48 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Oct 29, 2021 at 7:17 PM Jim Harris <james.r.harris@intel.com> wrote:
> >
> > clang-13 rightfully complains that the total_mem
> > variable in eal_parse_socket_arg is set but not
> > used, since the final accumulated total_mem
> > result isn't used anywhere. So just remove the
> > total_mem variable.
>
> Fixes: 0a703f0f36c1 ("eal/linux: fix parsing zero socket memory and limits")
>
> > Signed-off-by: Jim Harris <james.r.harris@intel.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-11-04 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 17:14 Jim Harris
2021-10-29 18:48 ` David Marchand
2021-11-04 12:19 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zYF7EbC2RV34QX3cqED+bORX_tX=SsO0-8FUyu7+cBbA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=james.r.harris@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).